From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id btOuB2aLmmDjPgAAWB0awg (envelope-from ) for ; Tue, 11 May 2021 09:49:26 -0400 Received: by simark.ca (Postfix, from userid 112) id 105F61F11C; Tue, 11 May 2021 09:49:26 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6CE8B1E01F for ; Tue, 11 May 2021 09:49:25 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2AEAE3839C45; Tue, 11 May 2021 13:49:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2AEAE3839C45 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1620740965; bh=pfy2UIWYRDVH6lZqI2nxuVwlA5linomOGth0Xg4/o6g=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=WibOEFZ9lgV5/lwfChHynWuK2DhKAUE+Jsz0C4PLusEKAjw5m+59zX4/frscUtHi+ T1cWSdoh6Fvj/MFeG+9eiXqateghUvh+lI92rWBho4elmTC9OKrUTVUnrJqvXtktr6 wtNivVBtQX9N8kqkAAruCMaSNdkrmRQfGRluZo7E= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 8FD93388A41D for ; Tue, 11 May 2021 13:49:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8FD93388A41D Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 14BDnHsw016580 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 May 2021 09:49:22 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 14BDnHsw016580 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 2AFC01E01F; Tue, 11 May 2021 09:49:17 -0400 (EDT) Subject: Re: Proposal: format GDB Python files with black To: Luis Machado , Tom Tromey , Simon Marchi via Gdb-patches References: <87lf8p9pwg.fsf@tromey.com> <086580a9-b3e8-1aa7-d7ac-b52792b8b8e1@linaro.org> Message-ID: <944f25ef-95cd-767b-0632-12d8df5f3706@polymtl.ca> Date: Tue, 11 May 2021 09:49:16 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <086580a9-b3e8-1aa7-d7ac-b52792b8b8e1@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 11 May 2021 13:49:17 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-05-11 7:38 a.m., Luis Machado wrote: >> Indeed. It's perhaps easy for me to say, because I get to choose what >> Linux distro and version I work on (so I opt for something recent), but >> I would still lean towards just following whatever the current latest >> stable version is. There might be new options in the latest stable >> version we want to use, it would be nice not to have to wait years >> before we can use them. And I suppose there's a not too painful way to >> get it for all the major distros out there (and for Windows and macOS, >> there are binary releases). And you can always run it in Docker or >> something. > > I suppose we could have scripts to automate this sort of task. Something that checks for the latest stable release and downloads it? A helper to make things easier and more consistent. Download from where? > > Can we do this server-side and take the burden off of the developers to have to do this as an additional step before pushing changes? We can check server-side if the formatting is good and reject the commit if not, but I don't think we can modify the commit being pushed (I don't think it would be a good idea if that was possible). But just like black (it's on my todo list to check that), we can have a commit hook that runs clang-format (at least just to warn you, "Hey, you code needs to be formatted" if clang-format would change something). Simon