From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119894 invoked by alias); 17 Oct 2017 01:05:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 119880 invoked by uid 89); 17 Oct 2017 01:05:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=claim X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Oct 2017 01:05:35 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CA906820E5; Tue, 17 Oct 2017 01:05:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com CA906820E5 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9452160851; Tue, 17 Oct 2017 01:05:32 +0000 (UTC) Subject: Re: [PATCH] Record and output access specifiers for nested typedefs To: Keith Seitz , simon.marchi@ericsson.com References: <1508189538-6733-1-git-send-email-keiths@redhat.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <9431dc9a-2156-10d7-8fbd-b46d5af9a72f@redhat.com> Date: Tue, 17 Oct 2017 01:05:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1508189538-6733-1-git-send-email-keiths@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-10/txt/msg00495.txt.bz2 On 10/16/2017 10:32 PM, Keith Seitz wrote: > @@ -13274,6 +13274,28 @@ dwarf2_add_typedef (struct field_info *fip, struct die_info *die, > > fp->type = read_type_die (die, cu); > > + /* Save accessibility. */ > + enum dwarf_access_attribute accessibility; > + struct attribute *attr = dwarf2_attr (die, DW_AT_accessibility, cu); > + if (attr != NULL) > + accessibility = (enum dwarf_access_attribute) DW_UNSND (attr); > + else > + accessibility = dwarf2_default_access_attribute (die, cu); > + switch (accessibility) > + { > + case DW_ACCESS_public: > + /* The assumed value if neither private nor protected. */ > + break; > + case DW_ACCESS_private: > + fp->is_private = 1; > + break; > + case DW_ACCESS_protected: > + fp->is_protected = 1; > + break; > + default: > + gdb_assert_not_reached ("unexpected accessibility attribute"); > + } > + Please don't gdb_assert on invalid input. Bogus input caused by a buggy compiler shouldn't bring down gdb. (I can't claim that I've really read the patch; I've barely skimmed it, there may be other instances. Please double check.) Thanks, Pedro Alves