From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59989 invoked by alias); 6 Dec 2017 22:50:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 59980 invoked by uid 89); 6 Dec 2017 22:50:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Dec 2017 22:50:52 +0000 Received: from ESESSHC017.ericsson.se (Unknown_Domain [153.88.183.69]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id E5.09.10723.944782A5; Wed, 6 Dec 2017 23:50:49 +0100 (CET) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.69) with Microsoft SMTP Server (TLS) id 14.3.352.0; Wed, 6 Dec 2017 23:50:48 +0100 Received: from [100.94.229.189] (129.192.64.65) by AMSPR07MB310.eurprd07.prod.outlook.com (2a01:111:e400:802f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.282.3; Wed, 6 Dec 2017 22:50:46 +0000 Subject: Re: [PATCH 2/2] target_set_syscall_catchpoint, use gdb::array_view and bool To: John Baldwin , Simon Marchi , Pedro Alves , References: <1509377531-21044-1-git-send-email-palves@redhat.com> <1509377531-21044-3-git-send-email-palves@redhat.com> <19e8ceb2-8c71-9d94-eeff-324200f2582b@simark.ca> <4f91f6f2-9b0f-d750-5d03-30fc23c0613d@FreeBSD.org> From: Simon Marchi Message-ID: <942455ac-2fbb-01b6-97ac-0096af2bf9f5@ericsson.com> Date: Wed, 06 Dec 2017 22:50:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <4f91f6f2-9b0f-d750-5d03-30fc23c0613d@FreeBSD.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DM5PR04CA0037.namprd04.prod.outlook.com (2603:10b6:3:12b::23) To AMSPR07MB310.eurprd07.prod.outlook.com (2a01:111:e400:802f::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1220684f-9412-4987-239b-08d53cfbcae8 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603286);SRVR:AMSPR07MB310; X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB310;3:QkN1K2FCQM70vTulkP8hFlnRZCWM9gguYbtfSgIbSEGdiCRiqTSEOWeSjroQfjZmNdV5LGu+XtuzHL+kL0E/R5kFRKkacFooFQdbSLtyh4qdeVR39HtxQE2lwe1vEAqXRbO8q0cUI5ngii9PiSNOR4W85DLCQ7XHXm6NuQTr9zmAAOzxYuMpXcigC8C6sE2CcdVHFHFGhJSK78ZPnUIMBH6cd3Q5zXiV3b04SxzK71d9ZNI2bC+VoVUawcNDnpHa;25:nx5wtDT3sHeqDeqh2o0AWDEwu8CIR1frtzBlCP4Z3pRKopqgf6dwicp4RNNhMoJ9l4MpQudPN4LEcuQdFXhOqR6g/wc7HSg5x0yenJT79LLlzihjCfNfyFqI9ymtjrQJAvuthEdGetWgl4dX9p4OeauBRZf2LfsS6Y4annwB2QAc0IMRlUhE9b/W0CO8owkrfMCCuId69kbncb5FTVBY4KjIh+MoIChhCOcDQ4YezkKpiFphin5uRNGK3cCi7O2YiX/E5oa+D1ZGyz6lpjA0wXeSMe4iEroPiULm5PcMRdcRGskhNJWUdEW0pYwj1gtCPbGn7T24W2xdOMphg8CTtMngh6OsK3mEsAx5ngT5B3I=;31:3SvUahASa8VByDLNdjBaIG+yk9MzaoRPWIe2J6QclH+P/naOH2+kxZc6N5R0vhT0jaGxNPPRTHvXreD34ftrX5O6byfRLRXyXmkCNT2RTy9jiIBdBeo4IZma7M40WqApES4msTDqx91xIAu8dML9TiKLW2R33sLmIpjnAUDscKqr0KHYWoQnvlVwKnN5gqNKKqZJerBPG6CLgMXX2vysrY6hT1ee58NicUPHR7yktz0= X-MS-TrafficTypeDiagnostic: AMSPR07MB310: X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB310;20:EJCDpS+66gz7fSNgw7mDhN52EyvvEqFlVFUoyovAL6iDC6oGfcxD1IYNtHfLdQo0DWqSANuprzg+Lj2zv6P1ixA9adpEukprSj0sy1BpAljEz0si8LtiPvKYOHESqVqMaT9gmnLv4r/osIJ02h/BEvrOaG6IwAQ8iDCUxRBScRhJmEx5JIGFinQzzlyUfNMD07gcyJ0J83xvhNl+TFzXCGdFe9ZQH7gg8gS8C+7dEQVmGxXOwGBSv5OTpuh53Q/a3ayl/DRVErOMVYsZSIKvYILtjA8Hb4r/MLUI8yMqADimYKnG/sg8/MVG92fa6dNE+44tA30LSFgERSCIWXoSzVNpbR5duR6lK+d2oZDa/yQsm8sj4hjgy7J+Py8WivI9opPeJrPypuJvpA6En5G9Flh/9L8uBUiuMHrGkSAGLWB/Q/gb6TjlFVERBDzivdIA4hKSz0BcKLTlax7GcVfi+ECtSEF5h4mivL3nAEk9C/sNMrS1TeLNopUrZ1XPixeZ;4:nwIYXLhVN9iVLfxoCvJAeFru701GokZfCHnGHhDmQ0OxjPeeRWNArUcZ5TQjtsvXwC81sbTKzzb76YBp51FKPDlF/oW7UG1HnaTidClddzrpcNargxKqpCHxoAbpyRc9dPzasmuQCTejeEjO5ujfSLToEr6b+Ac39AD9iVLBYZwmY6ptXh5qxYKshJnMjDAUb/JQLX6sB76jQ/nN8hPbrDrs6SkTJYqszQe47gN/DhMPPB+6g7mW+p/zm6FWr/JZ/f1Z8CxrN0vckb7rr5H90A== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(5005006)(8121501046)(10201501046)(3231022)(3002001)(93006095)(93001095)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123555025)(20161123560025)(20161123562025)(20161123558100)(6072148)(201708071742011);SRVR:AMSPR07MB310;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:AMSPR07MB310; X-Forefront-PRVS: 05134F8B4F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(366004)(346002)(39860400002)(376002)(377424004)(199004)(189003)(54534003)(24454002)(6486002)(81166006)(6666003)(316002)(305945005)(105586002)(93886005)(31696002)(33646002)(106356001)(83506002)(6116002)(229853002)(76176011)(2950100002)(4001150100001)(6246003)(2486003)(50466002)(97736004)(65826007)(81156014)(3846002)(8676002)(25786009)(52116002)(52146003)(5660300001)(7736002)(23676004)(64126003)(66066001)(65806001)(47776003)(2906002)(101416001)(65956001)(16526018)(49976008)(16576012)(86362001)(110136005)(68736007)(58126008)(230700001)(8936002)(31686004)(478600001)(36756003)(53546010)(53936002)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:AMSPR07MB310;H:[100.94.229.189];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTVNQUjA3TUIzMTA7MjM6YlpjUGhEa1hCcGhrM0FZODhQVmxtNTVPeTk4?= =?utf-8?B?ZHFLemNpUVgycDBvSWpNWE96MVlCRU82Qm45eTl4Q1plZEpQV0VZay80eCts?= =?utf-8?B?RWRJK0pzekhTOWw0TCtmOVNJc0NYU1dSWXpGQ1FIL3FMbXlEMUc5NEVCcEZ5?= =?utf-8?B?UWlPYk8xQ05IVWpSQUJzU0MrVGxHOHgrMEoydGJ5SmZFNHJFVHdabnpkdVVk?= =?utf-8?B?bGcvbXVRWHd4SEFxN1ErSmdSbWxkaStMaWlma00zeksxbEhiRzhicmxIeFMz?= =?utf-8?B?TzBvQVY4M0tQZmFMZFdyWVJ3T0szK0V2dmQ3dS9rclJTeWM2M1Ira3pQYUJv?= =?utf-8?B?blI3UVJENHJtR3hyMDEzWm9HZUg1cnRPYkJiUGw0Wk92cWVFR05RRCtTUzMz?= =?utf-8?B?bmUybHMvZGkrNzlJWEE2b1NjYkhnZUp2Y3NKT2U3Z3ArY2RzdnhYTkhZOUho?= =?utf-8?B?NXIwdHVWNnpWRkRmM1o1azRHU2thMFBCS25IMXZnWDdiVTJBdUhLYlNRb3Nw?= =?utf-8?B?LzYycVF3SFVrUjVXUnNxUytzTGtwckNFekJHcW45a2hZTGRZaGtKcXF1OFNq?= =?utf-8?B?L2pwNnpURGVQRHhrSTl0TnBVMUNXbjZCdWFrQ2JMckVsbnR0VnVuZTE4N3Z1?= =?utf-8?B?TXVNL3ZvTnhpL2xLOWd3bnB6dDI3YXM4TUxlV2x2MHlpT1ZhTHlmdWRMSkRa?= =?utf-8?B?dGd4aTRjT0RMUjhPS2FYQXRnQ2grNHBCL0ZrRnJvY0lPd29JRTZsdWFzbUNu?= =?utf-8?B?dkNzRUFtWlQrUDZOTzJxSzJucTJSVXQ5c3RwNGJtaXlMOFlhSzcra3FVU0tT?= =?utf-8?B?dURYNGVSblhIVnBPQXdSU3g2N1BvemlwcklOWjBlQng0TW5BbnBiUE9LSlZs?= =?utf-8?B?VU9RUnFYb1hESXpYODQ4N28vbm9vaGYwQnZUTlF6UHB1NmxGTVFHLzBSY3R2?= =?utf-8?B?KzZld3NURG55by94a092NmRJejJBTnVDQ01DaTh1UGZ1b0pGWGtUSG10NzdJ?= =?utf-8?B?b2RmbTNzU3hkRDgxb3lYMTlSUmFNcUJtSjNtand1Zm1qZDBiM0Y3UmJDS3Yy?= =?utf-8?B?SDhXa3JMb285OWxZMkx5eEl2Tk5CMDd3N3Y3Rk5wakJDaE9ZOXFjVm5WVkNm?= =?utf-8?B?M1lrTTdBK2t1QUxtNFFLK3VUaVQyYlZycER0VDNFdEdPTjZrKzVtQ20va2M3?= =?utf-8?B?U1JRY3pIalErZnhudDVjRW9NWVkxQnFzOXVVTzNuM2VaOHphNWN1cnVWQkRo?= =?utf-8?B?MHJ6QVBkZGxHSnl5MWR5WnErcDlVaHBxREdqaVUzN0w5VDRzRGZHbGFwc2la?= =?utf-8?B?T1NPZ0VBSEJWOUNEQ1QrZUNUWk1XWHJQaTlxTUVVaWdXbDlwTWVsayt6UVpY?= =?utf-8?B?UlBjQ3NQVC85WVV4WnZlT0w0UHA2NmFCSWVxNmpSOEJJdkUrQ2VPeFRxNVM1?= =?utf-8?B?c3VxTnRLVktCWU5TRnM3Z1haZ3lCeis1eUlkQUZQUGdRTFIrN0tpNVNFN1NI?= =?utf-8?B?SngxWnBobk40aG91U1czTHF2ZldBSWV4QzRCclFheU56eHFyLzZPN0wzODVV?= =?utf-8?B?dEJVM0Rlc0FjRHNGQURuNEV6RGpzeHlXVTcrZkQ5bXZXZ2xEUHRKL2txaitK?= =?utf-8?B?WHFTdm5CVnhsQnZjSXJ6dHlneW1aSzYyNmhrUFcrL1JVQnZFcGw4MzVLR3pt?= =?utf-8?B?bGwrcjU2dkZNcTBaa2hobUJvRFhXUU0wVWs3cnl1NFRnY29KZEdqWEViZFIz?= =?utf-8?B?NWVjdnIwNmgrWUlvZEMwWnQxSy9xd2xYV0w1RkNWN3QrQVcydFUzcmxsSnFG?= =?utf-8?B?bDBMaC9ubkZvTDNjRHJmYWF6U0txUk1idnVKeEVQZkE4eVVpaEFzeURrT2tI?= =?utf-8?B?NUZVTzNqWFhZNVowdjZJRVIwcklrT0xPbThMNndaMWRTSVdFMjV5dFNwYnB5?= =?utf-8?Q?tsoQDjE6VPzVNK+iZKz7HGutZhOtY=3D?= X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB310;6:mdQ61x7uUyar/EPnjwMYGU5trK1Fi7dhgpbcWxU2zY3A6NkM+TKwIyIlZPbuq9cFngT8ryQkfoK9c0zbgS+TtXe53JrplrS4h/FnLEw4oXX6sCUa4gWgrpEu4Ce0DYllDWDGlecKWbuOlKt3n0IRGMZVKipLc+Ww7VNPnj/lNFAAYTCExjKx8n97fUnbxF7WUdJUzbbz39gLS3vob3YkvfBneYEPy8C2H0Q9vi7aOTNAmsJhKbI1OmEI0/ojlZyACucFwSVsfW/PILTgrDnCxOXrr6S9SSa5+weQUX5pTF5bnH2Hb4xpYOQzGKAVOHKQWaC3z8ZJtEk9DRhZ36AHlUrAJMUFaJ4kbmR0jhbR8/M=;5:Q1OIlwrq2YB0axDRsi/iw3++OUsMMSmkmIl0b7gqn3bFZaa/otWUvhnlVsEdaDiHmlMf2k7qAMysJLnNvblP031ba6lcNLGZgnNgBY76rOLpswk1ifmEU/xzmjl7A03fR7pf0Ac/m5lFArN/e5cwTbnvuEeaRGufmyODnAhZAfc=;24:TbDZzLa1irMZMdCYgLQl3AV9b0Nj+cmES8DjTvxI1danAMXHyDjZYIlBB3VpXqoBxXiklxATD8axj1NjJ5X8foIZP/8TVPc4t4OYSS+CX/8=;7:atywdjQM49OELzvTPV0uiEJhATeMcS0bYpZXCyBapU3RlihfAGRyE/np1djZQs9fP5ZfUjrtZdgQCl9QovFRprHpx/tWdeoHccIR1wCUyod7aiHNC4jgs9bOYYiSyLDcLng2Bxxev8tbsTk8OXzHRrCtfQ4a1zpOBIdlYQPgljGd7s1W9pSGbFft17EizrBgyn/0jfIdymWPtilAa+T4fkDJrwAz24QcmIVYjsc4imtYfleysttsC/cbKpJbHIjL SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2017 22:50:46.8493 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1220684f-9412-4987-239b-08d53cfbcae8 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR07MB310 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00128.txt.bz2 On 2017-12-06 05:38 PM, John Baldwin wrote: > On 12/3/17 10:18 AM, Simon Marchi wrote: >> On 2017-10-30 11:59 AM, John Baldwin wrote: >>> On 10/30/17 3:32 PM, Pedro Alves wrote: >>>> I noticed that we're passing down a data/size pair to >>>> target_ops::to_set_syscall_catchpoint. This commit makes use of >>>> gdb::array_view instead. While at it, use bool where appropriate as >>>> well. >>>> >>>> gdb/ChangeLog: >>>> yyyy-mm-dd Pedro Alves >>>> >>>> * break-catch-syscall.c (insert_catch_syscall) >>>> (remove_catch_syscall): Adjust to pass reference to >>>> inf_data->syscalls_counts directly via gdb::array_view. >>>> * linux-nat.c (linux_child_set_syscall_catchpoint): Adjust to use >>>> bool and gdb::array_view. >>> >>> I believe fbsd-nat.c will need a similar fixup? It doesn't use the >>> values passed but does implement the target method. >> >> Hi John, >> >> Can you check if this updated patch builds properly on FreeBSD? >> >> Thanks! > > Just one typo below: > >> diff --git a/gdb/fbsd-nat.c b/gdb/fbsd-nat.c >> index 265175a769..1a36414837 100644 >> --- a/gdb/fbsd-nat.c >> +++ b/gdb/fbsd-nat.c >> @@ -1163,8 +1163,9 @@ fbsd_remove_exec_catchpoint (struct target_ops *self, int pid) >> >> #ifdef HAVE_STRUCT_PTRACE_LWPINFO_PL_SYSCALL_CODE >> static int >> -fbsd_set_syscall_catchpoint (struct target_ops *self, int pid, int needed, >> - int any_count, int table_size, int *table) >> +fbsd_set_syscall_catchpoint (struct target_ops *self, int pid, bool needed, >> + int any_count, >> + gdb::array_view syscall_counts)) > > Double close paren here should be a single, but builds fine aside from that, thanks! > Thanks, I pushed the patch with that fixed. Simon