From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32648 invoked by alias); 19 Feb 2003 20:27:40 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32641 invoked from network); 19 Feb 2003 20:27:40 -0000 Received: from unknown (HELO external1.doc.com) (63.119.183.65) by 172.16.49.205 with SMTP; 19 Feb 2003 20:27:40 -0000 Received: (qmail 20240 invoked from network); 19 Feb 2003 20:27:52 -0000 Received: from cpe-24-221-209-215.co.sprintbbd.net (HELO doc.com) (24.221.209.215) by external1 with SMTP; 19 Feb 2003 20:27:52 -0000 Date: Wed, 19 Feb 2003 20:27:00 -0000 Subject: Re: [RFA] Compile objc-lang.c, objc-exp.tab.c [1/5] Content-Type: text/plain; charset=US-ASCII; format=flowed Mime-Version: 1.0 (Apple Message framework v551) Cc: GDB Patches To: Elena Zannoni From: Adam Fedor In-Reply-To: <15955.54735.457114.404621@localhost.redhat.com> Message-Id: <941A376E-4448-11D7-A4B3-000A277AC1A4@doc.com> Content-Transfer-Encoding: 7bit X-SW-Source: 2003-02/txt/msg00436.txt.bz2 On Wednesday, February 19, 2003, at 12:06 PM, Elena Zannoni wrote: > Adam Fedor writes: >> Now that I'm almost done, I finally understand the patch lingo (Thanks >> Michael)! This is a repost of the first of five final patches for ObjC >> suppport: >> >> http://sources.redhat.com/ml/gdb-patches/2003-01/msg00049.html >> >> The other two that I also need approval for are: >> >> http://sources.redhat.com/ml/gdb-patches/2003-01/msg00050.html >> http://sources.redhat.com/ml/gdb-patches/2003-01/msg00080.html >> >> and two more (symtab.c, and linespec.c) will be coming soon. >> >> --- >> >> A new year brings a final push to get Objective-C support in gdb. This >> patch enables compilation and linking of the Objective-C files. I need >> this now since the remaining patches require so many of the >> Objective-C >> functions that it would be pointless to submit them otherwise. >> >> 2003-01-02 Adam Fedor >> >> * Makefile.in (COMMON_OBS): Add objc-lang.o >> (YYOBJ): Add objc-exp.tab.o >> (maint.o, utils.o): Add $(objc_lang_h) >> * maint.c (maintenance_demangle): Uncomment language_objc case. >> * utils.c (fprintf_symbol_filtered): Likewise. >> * parser-defs.h (start_msglist, add_msglist, end_msglist): Declare >> Objective-C parsing functions (from objc-lang.c). > > > I think this is just 'obvious' in a sense given the code has been > already approved, and it is just dormant. However, do we have > testcases already? I think we should have a gdb.objc > subdirectory. (sorry, i don't remember if you posted them). I would > feel uncomfortable enabling objc w/o having tests, even very simple > ones, it could bitrot fast. > > Yes I have one. I was going to wait till all the patches were in, since, AFAIK most of the tests won't pass until all my patches are in. How should I submit it? I suppose it would have to be a tar file.