From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sonic302-21.consmr.mail.ir2.yahoo.com (sonic302-21.consmr.mail.ir2.yahoo.com [87.248.110.84]) by sourceware.org (Postfix) with ESMTPS id 5C98E3858D34 for ; Wed, 8 Jul 2020 18:52:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5C98E3858D34 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=yahoo.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=ssbssa@yahoo.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1594234369; bh=2OgdmjwBR0pQpQ+btFP8oieqyl9pJ4xYWKo2bENKKTs=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From:Subject; b=Fs3OWZfiGTD1ojt+Xv/ibsykR3gJzXBPy0pU2bbTJI4bDlsu/c/jR7RDzHeziYwxyGPGL+A3Cx80zFLIpf7FXX2o89Tc8f1/vUhHdvOVAtQzn7V8sxa3x/9ihzrf1BZmPVt7DiU8yi2Crk0kbFqzdF9VBPFbjOWKe4K6C7/WHR+rV/ATEVM5XqVdzdz806dC3Wtg+c95YQW0CIydrxDR7Ksi94P1/nSyoRRI9rqdJ0om143UgPKgKl+xe9kGxdlT2miePlGF3reVKoKTI5nbzUE+v8Jz/ZHE/3dItWZZzD8o8AFLCRWcxQJTWHljVbLWc0DugmE/O4meJoLXbY2wfQ== X-YMail-OSG: jc0H3WgVM1l3OrkwzCMMuX7Byd3piwxkFHtJDnC2JIzUwKwP1_DWxD6.YrYTxy4 vD62T8ade6nHBERToSGGU6kZ6GFQMkNbDC115woG2siECvUSRFkZTakjgHFQOYhqYmdS1t0WAXtn cYx7gbs2pX6jLivxzUZhJ3tHf8FkahWxwgRl6aCedVOOR2nqKgBu696FtsoL.wqbKa7iI9bEkaur DYxLsrVqwD8kg5d5HCXdNyIfK7Pv8VIrkQ_9p.y__nPvZWwflalp5sM68J.S2I.n2bo5pzyZU6RS NhvgiKGDdeaDs6oG3CaG_0SY_Cl.r5S8WjyTfgrl87HRSS1uerAp3mRIoOgMocrO0hJnLAenQpxU gWA6iISVITjHEBGKJNPRwU8cjUWCkiKZTZrQGBQinQmx9QpB18WdB98aovGZoP_9rNH0yMQcTyqs IyBf1ojnqgfkX6buKrriuwFFM1wMYb.ZmAWrA8y1BFXu1b6.W8FW5m1uXgJpiB2ZBvcXpGBTilTr rRP3pcuBY0PI_RFUW_aL7Me5.8yP62ZTCqSq.JTr4gq6T7mGxvYWKjBf7UDKlLOi9V6ocGM5A9MN Mv13HVi1XJqNyg3PCtKwdluGC9YZorgnmxvG9l7juOI_SrtD9fgB7pDT8sHQMVkYWlSSQHMbgCcM dm1wSB34z7n1DfkruOuZDtVAsX_po7zFMNnff55m6skUr4xuWJ_F2d_gs966MM2REgvE9AxP.8Vz ne0ROelbfnLOrgu.IvbxpowfExYp5UY1Mwwik9gzOdlDsRGaRKoqFZ5Av.OfnFKvOy1FpHJCv2go Y1C1.iV0oM4I7CTEc5mZhJkPM3rl9BddsX.KSBchHdMFhTc7w0H9zbForevCGfJVLFj9A.DP3SZd upQAYAIPf.xZe42pPv3ASJCUkWl26qiUPWHdx_sX8a_nJ9Y.MBPdoTC1gvL7ngJbKt2614GQllvZ WGZfaM9YcXsnWFKb35V51lm17G9OssnF3DIbVxIZbQSNssL.BTnKmlhuiQv7xIi.1f7AS0ESRPvw eGd1scC2zWBY3uMSWBn8sjhpAeyEbs.sHvwhI.qXjS1HUv_UHNJ9kztFxsy26XlBWV07pylP0CEx U2TeVccJgfzrucsO0fyeI3Ieg_Vxi59w1IAA7VzDdeU4qrdt.7.lXAmtaER5Fi9w6svHIQObjO_z BlYBUBYwSNk3et6bHTx.p2dwjjgfdgaEZFzXJ115HofPcQLW_sPoW8IvwDH50cCAdDalTHJp4bdU wT6o6WIzRi9UTqQ5ziZqHOhau21BbF17ZbbeOXZwW1uv3dgRFlJKIN.vYB6lc70pMslYeMLhDYQ2 IPZ5MivatxNSkZd3tDOpQssYkS8AHPA-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.ir2.yahoo.com with HTTP; Wed, 8 Jul 2020 18:52:49 +0000 Date: Wed, 8 Jul 2020 18:52:44 +0000 (UTC) From: Hannes Domani To: Eli Zaretskii Cc: gdb-patches@sourceware.org Message-ID: <941705205.7950021.1594234364964@mail.yahoo.com> In-Reply-To: <838sftrihf.fsf@gnu.org> References: <20200708171957.15720-1-ssbssa.ref@yahoo.de> <20200708171957.15720-1-ssbssa@yahoo.de> <838sftrihf.fsf@gnu.org> Subject: Re: [PATCH v3] Handle Windows drives in auto-load script paths MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.16197 YMailNorrin Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:76.0) Gecko/20100101 Firefox/76.0 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jul 2020 18:52:52 -0000 Am Mittwoch, 8. Juli 2020, 20:04:28 MESZ hat Eli Zaretskii = Folgendes geschrieben: > > From: Hannes Domani > > Date: Wed,=C2=A0 8 Jul 2020 19:19:57 +0200 > > > > Fixes this testsuite fail on Windows: > > FAIL: gdb.base/auto-load.exp: print $script_loaded > > > > Converts the debugfile path from c:/dir/file to /c/dir/file, so it can = be > > appended to the auto-load path. > > > > gdb/ChangeLog: > > > > 2020-07-08=C2=A0 Hannes Domani=C2=A0 > > > >=C2=A0=C2=A0=C2=A0=C2=A0 * auto-load.c (auto_load_objfile_script_1): Con= vert drive part > >=C2=A0=C2=A0=C2=A0=C2=A0 of debugfile path on Windows. > > > > gdb/doc/ChangeLog: > > > > 2020-07-08=C2=A0 Hannes Domani=C2=A0 > > > >=C2=A0=C2=A0=C2=A0=C2=A0 * gdb.texinfo: Document Windows drive conversio= n of > >=C2=A0=C2=A0=C2=A0=C2=A0 'set auto-load scripts-directory'. > > This LGTM, as I said earlier. > > One minor aesthetic nit, though: > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 debugfile_holder =3D STRIP_DRIVE_SPEC (= debugfile); > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 filename =3D std::string("/") + debugfi= le[0] + debugfile_holder; > > > Perhaps it is slightly better to use "\\" here instead of "/", since > on both sides of that "/D" thing all other separators are backslashes, > so this forward slash looks like the odd one out. Pushed with this change, thanks. Hannes