From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 86B7B3858D35 for ; Thu, 6 Aug 2020 20:27:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 86B7B3858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 54D1F1E599; Thu, 6 Aug 2020 16:27:33 -0400 (EDT) Subject: Re: [PATCH 0/4] Regcache fix and optimization To: Simon Marchi , gdb-patches@sourceware.org Cc: Morichetti@sourceware.org, Laurent References: <20200720204101.2849535-1-simon.marchi@efficios.com> From: Simon Marchi Message-ID: <93f5388f-744c-5fd7-945b-be46460d1399@simark.ca> Date: Thu, 6 Aug 2020 16:27:25 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200720204101.2849535-1-simon.marchi@efficios.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Aug 2020 20:27:35 -0000 On 2020-07-20 4:40 p.m., Simon Marchi via Gdb-patches wrote: > The main goal of this series is patch 4, and is about changing the > regcache storage from a linked list to a map, to make lookups and > removals more efficient. > > Patches 1 and 2 are cleanups. They are not necessary, but I think they > would be nice to have. > > Patch 3 addresses a potential bug I spotted while reading the code. > > Simon Marchi (4): > gdb: rename regcache::current_regcache to regcache::regcaches > gdb: move regcache::regcaches to regcache.c > gdb: pass target to thread_ptid_changed observable > gdb: change regcache list to be a map > > gdb/dwarf2/index-write.c | 1 + > gdb/infrun.c | 78 +++++++++++- > gdb/observable.h | 6 +- > gdb/record-btrace.c | 1 + > gdb/regcache.c | 259 +++++++++++++++++++++++++++++---------- > gdb/regcache.h | 7 -- > gdb/sparc64-tdep.c | 2 +- > gdb/thread.c | 2 +- > gdbsupport/ptid.h | 16 +++ > 9 files changed, 291 insertions(+), 81 deletions(-) > > -- > 2.26.2 > I pushed the first two patches, since they had the ack of Pedro. Simon