From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gd2TI+KRz1/ibgAAWB0awg (envelope-from ) for ; Tue, 08 Dec 2020 09:46:58 -0500 Received: by simark.ca (Postfix, from userid 112) id 849511F096; Tue, 8 Dec 2020 09:46:58 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 247D01E552 for ; Tue, 8 Dec 2020 09:46:58 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A974A385800D; Tue, 8 Dec 2020 14:46:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A974A385800D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1607438817; bh=edyHShphJkkXheJw3qWTO0DZFQNGLdeIkYgQ/nTyiHg=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=Ayz/WK6v81okI4xMG7q88yZ4ndOp4PkgA6uXDHg9IydQpKieLsR+29Z5E6hx4+Rqe +wWw2l2AYcYSMx6xTBRptsldaeQKNFTq5rD+VeHFylVZnnOdXJ7/3czNl0Q4VUS0SC 69Sd185f1/0YzQqpI0OS7aQjfQs0GhnwDswkZQ2A= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 84B63385800D for ; Tue, 8 Dec 2020 14:46:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 84B63385800D Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 0B8EklMo024464 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 8 Dec 2020 09:46:52 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 0B8EklMo024464 Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id D8AF41E552; Tue, 8 Dec 2020 09:46:47 -0500 (EST) Subject: Re: [PATCH] gdb/gdbsupport: Use LOCALAPPDATA for index cache on windows To: Alexander Fedotov , gdb-patches@sourceware.org References: Message-ID: <93d41b96-d11e-ed21-2a63-6a8270b5fbfe@polymtl.ca> Date: Tue, 8 Dec 2020 09:46:47 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 8 Dec 2020 14:46:48 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2020-12-08 5:16 a.m., Alexander Fedotov via Gdb-patches wrote: > Hi all > > When running GDB on Windows using native command line (not Msys2 or > another) I see nasty warning Couldn't determine a path for index > cached directory" > > So I have decided to use LOCALAPPDATA as a last resort. > > Comments are welcomed. > > Alex > Hi Alex, I made a few changes to your patch: - I adjusted you comment message a little bit and added a ChangeLog entry - I Changed "#ifdef _WIN32" to "#ifdef WIN32", because we use the latter a few lines below. My only question is about: return string_printf ("%s/" HOME_CACHE_DIR "/gdb", abs.get ()); That would give a final path like: C:\Users\Simon\AppData\Local\.cache\gdb The ".cache" part is not typical in this directory. Should we instead just have: C:\Users\Simon\AppData\Local\gdb ? Simon