From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yKOaOkiRCGCIZAAAWB0awg (envelope-from ) for ; Wed, 20 Jan 2021 15:23:36 -0500 Received: by simark.ca (Postfix, from userid 112) id D6B7C1EF84; Wed, 20 Jan 2021 15:23:36 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RDNS_NONE,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 443541E590 for ; Wed, 20 Jan 2021 15:23:36 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0E0E73971826; Wed, 20 Jan 2021 20:23:30 +0000 (GMT) Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by sourceware.org (Postfix) with ESMTPS id B94873857830 for ; Wed, 20 Jan 2021 20:23:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B94873857830 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wr1-x433.google.com with SMTP id a9so20867170wrt.5 for ; Wed, 20 Jan 2021 12:23:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3rcBEnTDMHGgwROUdyqg2tRhJMJ712w7wbgmoYqbAiA=; b=aXREqqhz3ryPlXHu1qbfklSdEB6A9fWLYv8Yqx6ZM9YxmnNpEVvW1a6G0S6lnKg4k1 Mz07QajzGosA2JNac1TsuqGyRDTWpWzx5NW7a3kQFIf67QQk+Fzbcj33xlTrtNSrJXgK ey1meZ72dBfKn/rApBMSvVGv4N11EM1WAj4w4NH+9QprEm2E+hJIKgjbShGoABDh64mG +GKf9UxuHyDlZYy6f9YKc1jkXUmug/FeECHKk3ilxaxRUuk3fFlz3uOM5DohWXQ7qU5/ V4n15Za9mZrvgKzc+bCV/HLKcN8qhadEK3r0RvFOJr0RU7Tk9mJ6m8cEm/u7lvKtkpcH gD6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3rcBEnTDMHGgwROUdyqg2tRhJMJ712w7wbgmoYqbAiA=; b=kguC0yMQpK0eniPpi67FPxrASU+HhiaT65Prq1n99IsYszQAMj7T/V1yRnVq9F2tnu bm/rpOJugCaYHbO5fNxjtx+k++h5dLIedyud/+h0JjEAG1gdSnyGCTyhgzzmQmqCgIUN 88g6Lc+7A9IPnbk/NyCuLsA4Ol5b+LLT7ZfUsWrPE6kvTqH2lmw9OQHBH4dey7NzOM/G ynweIDhM8znmsPqkAJEatajbk/TImUWksU0HOHVswXkOUFvuZWAC2tnefubdGi60dVto mkjQZkPu+29n3kVE+89mTlstcfxAWdjvMiRnvk2mSPL7SZ0u50CDEheaaEHSa/AMRBSk AbeA== X-Gm-Message-State: AOAM530kn2+FmdN96APXchHivrc/88my2YyxCIffqHtDblguzwhs6CuJ ssiHoX7W7UbkM1sE0245Ekd1t4f0Rml1LQ== X-Google-Smtp-Source: ABdhPJzHTD6XQyLFms4JzQI+TksYnYkZgX7zRheRBlRIn5J56U6Bi+DMCjjFMcEIH9dal+i0YEyqZg== X-Received: by 2002:adf:90e3:: with SMTP id i90mr11449759wri.248.1611174205686; Wed, 20 Jan 2021 12:23:25 -0800 (PST) Received: from localhost (host86-180-62-229.range86-180.btcentralplus.com. [86.180.62.229]) by smtp.gmail.com with ESMTPSA id u17sm5476800wmj.35.2021.01.20.12.23.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Jan 2021 12:23:25 -0800 (PST) From: Andrew Burgess To: gdb-patches@sourceware.org, binutils@sourceware.org Subject: [PATCHv2 4/9] bfd/riscv: prepare to handle bare metal core dump creation Date: Wed, 20 Jan 2021 20:23:10 +0000 Message-Id: <9379a3e1af978103cfa47e869594f0df91d807ea.1611172468.git.andrew.burgess@embecosm.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fredrik Hederstierna Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" When creating a core file GDB will call the function elfcore_write_prstatus to write out the general purpose registers along with the pid/tid for the thread. However, for a bare metal RISC-V tool chain the prstatus*_t types are not defined so the elfcore_write_prstatus function will return NULL, preventing core file creation. This commit provides the `elf_backend_write_core_note' hook and uses the provided function to write out the ptstatus information. In order to keep changes in the non bare metal tools to a minimum, the provided backend function will itself return NULL when the prstatus*_t types are available, the consequence of this is that the generic code in elfcore_write_prstatus will be used just as before. But, when prstatus*_t is not available, the new backend function will write out the prstatus information using predefined offsets. This new functionality will be used by a later GDB commit that will add bare metal core dumps for RISC-V. bfd/ChangeLog: * elfnn-riscv.c (riscv_write_core_note): New function. (elf_backend_write_core_note): Define. --- bfd/ChangeLog | 6 ++++ bfd/elfnn-riscv.c | 72 +++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 78 insertions(+) diff --git a/bfd/elfnn-riscv.c b/bfd/elfnn-riscv.c index b2ec6a29fbf..70a683b45a3 100644 --- a/bfd/elfnn-riscv.c +++ b/bfd/elfnn-riscv.c @@ -4886,6 +4886,77 @@ _bfd_riscv_relax_section (bfd *abfd, asection *sec, # define PRPSINFO_OFFSET_PR_PSARGS 56 #endif +/* Write PRSTATUS and PRPSINFO note into core file. This will be called + before the generic code in elf.c. By checking the compiler defines we + only perform any action here if the generic code would otherwise not be + able to help us. The intention is that bare metal core dumps (where the + prstatus_t and/or prpsinfo_t might not be available) will use this code, + while non bare metal tools will use the generic elf code. */ + +static char * +riscv_write_core_note (bfd *abfd ATTRIBUTE_UNUSED, + char *buf ATTRIBUTE_UNUSED, + int *bufsiz ATTRIBUTE_UNUSED, + int note_type ATTRIBUTE_UNUSED, ...) +{ + switch (note_type) + { + default: + return NULL; + +#if !defined (HAVE_PRPSINFO_T) + case NT_PRPSINFO: + { + char data[PRPSINFO_SIZE] ATTRIBUTE_NONSTRING; + va_list ap; + + va_start (ap, note_type); + memset (data, 0, sizeof (data)); + strncpy (data + PRPSINFO_OFFSET_PR_FNAME, va_arg (ap, const char *), 16); +#if GCC_VERSION == 8000 || GCC_VERSION == 8001 + DIAGNOSTIC_PUSH; + /* GCC 8.0 and 8.1 warn about 80 equals destination size with + -Wstringop-truncation: + https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85643 + */ + DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION; +#endif + strncpy (data + PRPSINFO_OFFSET_PR_PSARGS, va_arg (ap, const char *), 80); +#if GCC_VERSION == 8000 || GCC_VERSION == 8001 + DIAGNOSTIC_POP; +#endif + va_end (ap); + return elfcore_write_note (abfd, buf, bufsiz, + "CORE", note_type, data, sizeof (data)); + } +#endif /* !HAVE_PRPSINFO_T */ + +#if !defined (HAVE_PRSTATUS_T) + case NT_PRSTATUS: + { + char data[PRSTATUS_SIZE]; + va_list ap; + long pid; + int cursig; + const void *greg; + + va_start (ap, note_type); + memset (data, 0, sizeof(data)); + pid = va_arg (ap, long); + bfd_put_32 (abfd, pid, data + PRSTATUS_OFFSET_PR_PID); + cursig = va_arg (ap, int); + bfd_put_16 (abfd, cursig, data + PRSTATUS_OFFSET_PR_CURSIG); + greg = va_arg (ap, const void *); + memcpy (data + PRSTATUS_OFFSET_PR_REG, greg, + PRSTATUS_SIZE - PRSTATUS_OFFSET_PR_REG - ARCH_SIZE / 8); + va_end (ap); + return elfcore_write_note (abfd, buf, bufsiz, + "CORE", note_type, data, sizeof (data)); + } +#endif /* !HAVE_PRSTATUS_T */ + } +} + /* Support for core dump NOTE sections. */ static bfd_boolean @@ -5000,6 +5071,7 @@ riscv_elf_obj_attrs_arg_type (int tag) #define elf_backend_grok_prstatus riscv_elf_grok_prstatus #define elf_backend_grok_psinfo riscv_elf_grok_psinfo #define elf_backend_object_p riscv_elf_object_p +#define elf_backend_write_core_note riscv_write_core_note #define elf_info_to_howto_rel NULL #define elf_info_to_howto riscv_info_to_howto_rela #define bfd_elfNN_bfd_relax_section _bfd_riscv_relax_section -- 2.25.4