From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id CBEDD385C426 for ; Tue, 26 May 2020 19:36:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CBEDD385C426 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-313-TdcwgrfFN9GOQEh7NyUANw-1; Tue, 26 May 2020 15:36:01 -0400 X-MC-Unique: TdcwgrfFN9GOQEh7NyUANw-1 Received: by mail-wm1-f70.google.com with SMTP id j128so207899wmj.6 for ; Tue, 26 May 2020 12:36:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kSWER2XHbMRGzcqwknPxpE3580a7GEcKgdjmeWo9MJM=; b=I9or20Lyh3EkWJiC5AdmKSP/1LeTvFvuRUpLN1+j5f9d0SC7BjKwaZYxgDa3DQ10hx 6sp5y1NoNGXB8ueOcIXbIDYZFS6MxZyUcK/dKSSm9FTUYEdyCaMKHxsnfFrrb9cLKHNf siDcsSz+xdGrXzwkrLjZgZnZ4q0QhM+AhOlyATkbpqVblLbwSldLRmx0epEfWsKSaamU i8NPVyLRTfFjf8wMob/gjay4vmuVlQ1wMmYBLbXjc7y2Lqty0UHR76flWKAFHHPeCKBz 8G2hjuVaNl+k3RxkLUIMsSQGYUqwkToW8LI7tJbkDIe6tFCEMrADLc9V9lUKaJPv0sLi 8dpA== X-Gm-Message-State: AOAM530QRiJEd+qWC/eBq+vlWfMFH85bQpZQDSTCRlMwXX7c7RtHmOjz MqzlURZqWgZAxrXa6MEs7yucPoJD3avOzv+bRXfqEl/L5Ul80cpC56I7ESXV+0HMwsMoHkFVhJY xRV0kOiY3hnMEeZiSwpP1uw== X-Received: by 2002:adf:f702:: with SMTP id r2mr22172507wrp.191.1590521760328; Tue, 26 May 2020 12:36:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxENjKA8qzCYQlZrai9Fbk1AW7mpOhpfdWceJa5+8qGEbATC6hLT6ne9MjeZs1eoo/HDVoYdg== X-Received: by 2002:adf:f702:: with SMTP id r2mr22172494wrp.191.1590521760166; Tue, 26 May 2020 12:36:00 -0700 (PDT) Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id n17sm701258wrr.42.2020.05.26.12.35.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 May 2020 12:35:59 -0700 (PDT) Subject: Re: [PATCH,v3 testsuite] Fix some duplicate test names To: Luis Machado , gdb-patches@sourceware.org References: <20200526141848.22771-1-luis.machado@linaro.org> <20200526190224.755-1-luis.machado@linaro.org> From: Pedro Alves Message-ID: <935ac55c-e195-0aa7-c8ed-63e77f8f9c96@redhat.com> Date: Tue, 26 May 2020 20:35:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20200526190224.755-1-luis.machado@linaro.org> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 May 2020 19:36:06 -0000 On 5/26/20 8:02 PM, Luis Machado via Gdb-patches wrote: > @@ -45,10 +45,10 @@ proc break_at { breakpoint where } { > > set test "break $breakpoint" > set bp 0 > - gdb_test_multiple "$test" "$test" { > + gdb_test_multiple "$test" "$test inserted as number $bp" { As discussed, this change should be backed out, and replaced with with_test_prefix, right? $bp is always zero here. > -re "Breakpoint (\[0-9\]*) at .*$where.*$gdb_prompt $" { > set bp $expect_out(1,string) > - pass "$test" > + pass $gdb_test_name > } > } > return $bp Thanks, Pedro Alves