From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22492 invoked by alias); 4 Oct 2017 16:13:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22051 invoked by uid 89); 4 Oct 2017 16:13:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=itd, Hx-languages-length:925 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Oct 2017 16:13:29 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 57F037E439; Wed, 4 Oct 2017 16:13:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 57F037E439 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7412F5C1A1; Wed, 4 Oct 2017 16:13:27 +0000 (UTC) Subject: Re: [PATCH] Fix -list-thread-groups --available logic and add test To: Simon Marchi , gdb-patches@sourceware.org References: <7b48234b-1a7d-b4b4-2de0-2514d70cc59c@redhat.com> <1507132859-27807-1-git-send-email-simon.marchi@ericsson.com> Cc: tom@tromey.com From: Pedro Alves Message-ID: <92fed2cd-29a3-f074-3419-c066f2134577@redhat.com> Date: Wed, 04 Oct 2017 16:13:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1507132859-27807-1-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-10/txt/msg00086.txt.bz2 On 10/04/2017 05:00 PM, Simon Marchi wrote: > New in v2: > > - Match more precisely process entry in output. Actually, match two, to > test that giving more than one pid works. > Great, thanks! I noticed something else. Don't we need to kill/reap the spawned spawn_id's? There's kill_wait_spawned_process for that, but it operators on build, not on target. Maybe it'd be OK to limit the test to local testing, and so you'd use can_spawn_for_attach instead of use_gdb_stub. Hmm, actually, I do think that you should do that, given: proc can_spawn_for_attach { } { # We use exp_pid to get the inferior's pid, assuming that gives # back the pid of the program. On remote boards, that would give # us instead the PID of e.g., the ssh client, etc. if [is_remote target] then { return 0 } (the "we" above refers to spawn_id_get_pid.) Thanks, Pedro Alves