Re: [PATCH] Turn value_field into a method

[Simon Marchi <simark@simark.ca>]

On 2026-02-06 13:40, Tom Tromey wrote:
> diff --git a/gdb/value.h b/gdb/value.h
> index 1ef3acd6054..201db773a84 100644
> --- a/gdb/value.h
> +++ b/gdb/value.h
> @@ -626,6 +626,14 @@ struct value
>    struct value *primitive_field (LONGEST offset, int fieldno,
>  				 struct type *arg_type);
>  
> +  /* Given that this value is of a struct or union type, extract and
> +     return the value of one of its (non-static) fields.  FIELDNO says
> +     which field.  */

For future work: that comment makes me think it would be nice to have an
assert (probably in value::primitive_field) to check that the type is
indeed a struct or union.  If calling with a non-struct/non-union type,
this assert in type::field would probably trigger:

  gdb_assert (idx >= 0 && idx < num_fields ());

But it would be nice to check the precondition in primitive_field too,
it would be clearer.

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Simon