From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qT+8AfFGCWie/QEAWB0awg (envelope-from ) for ; Wed, 23 Apr 2025 16:00:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1745438448; bh=BGuwUGUNKcbU3wBWJ6N8H9JFgXLHKbbIS8JtdMBeU6k=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=r2L+Hc2Vs5YtIsLFT+j+RcTpFANzUubtTvkXf0nYFjaPLkSBua3m/NLJLvRBN8stR /5spgY52dFieSt6rg8iCbJXClyxJF85RxBLf3dgiyDy5uDlUgHBf+p06ycipMiE+4g aqJxeKFiw5BO8R/FGD2NOPcNQFveLWZ3iUXhVyrk= Received: by simark.ca (Postfix, from userid 112) id E5ACF1E0C3; Wed, 23 Apr 2025 16:00:48 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=qz/a17Ag; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=GE/yWn4S; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 539301E05C for ; Wed, 23 Apr 2025 16:00:48 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EEA4E3857BB6 for ; Wed, 23 Apr 2025 20:00:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EEA4E3857BB6 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=qz/a17Ag; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=GE/yWn4S Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 9207A3858C41 for ; Wed, 23 Apr 2025 20:00:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9207A3858C41 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9207A3858C41 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745438419; cv=none; b=kkswHMdYnRb3WM0yv2nBZPwNXe7syZtZZ1WP96s43AKuteKLKMn5V1AMKTDjNU4PbkM16Gjy3nIQriLO2kPvSpa4hF5M3Ec9lVW528f2GjF68np8Mk/DJa1ovLZkkIT1qd3/62ELz9BRgd1c6rTXFQftbHVKjDm4j7//C67DyiU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745438419; c=relaxed/simple; bh=BGuwUGUNKcbU3wBWJ6N8H9JFgXLHKbbIS8JtdMBeU6k=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=N3PEQGLKfQAcrLhLhCQ8EGN3zwTUiPpcO9YvKTxaXZDIl+RKLPC7pKcg7goDJEzW+ZWJSbNsvrLdH2ORPXmFzMh//G8ivi8m7OEeEbrT3JwwZGnqbRcS2WzkYlFlA79hTv98nFU/7R75oNlpfFZawu4CicZpoIolP6UrzfoZnsI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9207A3858C41 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1745438419; bh=BGuwUGUNKcbU3wBWJ6N8H9JFgXLHKbbIS8JtdMBeU6k=; h=Date:Subject:To:References:From:In-Reply-To:From; b=qz/a17Agu7IrQkSo50elmsXgsCsinGaJUMu0ivCnfYG3jtSygVAG6nXWD9qKYSAi9 2pBlZic5Uadn7dRo4vSTWaEHk5ItG4qoIWkfUz3o/JSrA2SpE/QgQ6F4l1GPZrJdr9 oewgI1F0fZ9YTbLFLwSDxV5lBVZ9l8bw1eWJBFzs= Received: by simark.ca (Postfix, from userid 112) id 280711E100; Wed, 23 Apr 2025 16:00:19 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1745438417; bh=BGuwUGUNKcbU3wBWJ6N8H9JFgXLHKbbIS8JtdMBeU6k=; h=Date:Subject:To:References:From:In-Reply-To:From; b=GE/yWn4S1gJevso4nkPZ1uOfEQjYsK+AJAXFJcJ7fCYfH7sljB3NiICUgyRpHz0if BmFlQRpKYFoZo5nQN2flNEhzTg6qWdaD22B5dmHiA98hnBjXTa77twbcJuc54u+7wX fWe95ITuaLW/r5K5/UFscOoPZ5BW/TfPXTW3F8VM= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id C4EEE1E05C; Wed, 23 Apr 2025 16:00:17 -0400 (EDT) Message-ID: <92ed741b-8931-45fe-a87d-7a1edb6d8887@simark.ca> Date: Wed, 23 Apr 2025 16:00:17 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 27/28] Make dw_expand_symtabs_matching_file_matcher static To: Tom Tromey , gdb-patches@sourceware.org References: <20250402-search-in-psyms-v2-0-ea91704487cb@tromey.com> <20250402-search-in-psyms-v2-27-ea91704487cb@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <20250402-search-in-psyms-v2-27-ea91704487cb@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > @@ -1961,9 +1966,11 @@ dw2_expand_symtabs_matching_one > return true; > } > > -/* See read.h. */ > +/* If FILE_MATCHER is non-NULL, set all the > + dwarf2_per_cu_quick_data::MARK of the current DWARF2_PER_OBJFILE > + that match FILE_MATCHER. */ The name dwarf2_per_cu_quick_data sounds outdated, the comment could perhaps be refreshed, while at it. Simon