From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13076 invoked by alias); 9 May 2013 18:49:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13050 invoked by uid 89); 9 May 2013 18:49:33 -0000 X-Spam-SWARE-Status: No, score=-7.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 09 May 2013 18:49:33 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r49InVH3004791 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 9 May 2013 14:49:31 -0400 Received: from barimba (ovpn-113-133.phx2.redhat.com [10.3.113.133]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r49InUDD018818 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 9 May 2013 14:49:31 -0400 From: Tom Tromey From: Tom Tromey To: gdb-patches@sourceware.org Subject: [PATCH 06/40] remove erroneous return from setup_user_args In-Reply-To: References: Message-Id: <92e6b6a1fe3fd7885440b6980377af3ea3214374.1368124285.git.tromey@redhat.com> Date: Thu, 09 May 2013 18:49:00 -0000 MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-05/txt/msg00321.txt.bz2 This fixes setup_user_args to drop a useless and confusing "return". * cli/cli-script.c (setup_user_args): Don't return after error. --- gdb/cli/cli-script.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/gdb/cli/cli-script.c b/gdb/cli/cli-script.c index 3b24799..43fd479 100644 --- a/gdb/cli/cli-script.c +++ b/gdb/cli/cli-script.c @@ -689,11 +689,8 @@ setup_user_args (char *p) int bsquote = 0; if (arg_count >= MAXUSERARGS) - { - error (_("user defined function may only have %d arguments."), - MAXUSERARGS); - return old_chain; - } + error (_("user defined function may only have %d arguments."), + MAXUSERARGS); /* Strip whitespace. */ while (*p == ' ' || *p == '\t') -- 1.8.1.4