From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17568 invoked by alias); 26 Oct 2011 15:11:33 -0000 Received: (qmail 17560 invoked by uid 22791); 26 Oct 2011 15:11:32 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from qmta12.emeryville.ca.mail.comcast.net (HELO qmta12.emeryville.ca.mail.comcast.net) (76.96.27.227) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 26 Oct 2011 15:11:18 +0000 Received: from omta19.emeryville.ca.mail.comcast.net ([76.96.30.76]) by qmta12.emeryville.ca.mail.comcast.net with comcast id pSXx1h0031eYJf8ACTBB3t; Wed, 26 Oct 2011 15:11:11 +0000 Received: from [10.127.238.91] ([65.206.2.68]) by omta19.emeryville.ca.mail.comcast.net with comcast id pT7x1h00U1U2a2h01T7zDJ; Wed, 26 Oct 2011 15:08:10 +0000 Subject: Re: [RFA] Python: iterator for deep traversal of gdb.Type struct/union fields Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Paul Koning In-Reply-To: <83bot4de4v.fsf@gnu.org> Date: Wed, 26 Oct 2011 17:14:00 -0000 Cc: gdb-patches@sourceware.org, tromey@redhat.com, raise.sail@gmail.com Content-Transfer-Encoding: 7bit Message-Id: <92BF63C1-0118-4ED9-BB22-ACB406D2D22D@comcast.net> References: <4E8595F6.7080004@gmail.com> <2460DAAE-C437-469A-BA1A-47343C5DBB45@comcast.net> <4E8F0244-3A3F-4AE2-A13C-DA9503282A97@comcast.net> <4C0389F5-A2DF-4864-8E33-BB893C885C98@comcast.net> <83bot4de4v.fsf@gnu.org> To: Eli Zaretskii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00697.txt.bz2 On Oct 25, 2011, at 4:12 PM, Eli Zaretskii wrote: >> From: Paul Koning >> Date: Tue, 25 Oct 2011 14:54:21 -0400 >> Cc: Tom Tromey , Li Yu >> >> +@item deepitems (@var{type}) >> +Returns a Python iterator similar to the standard >> +@code{gdb.Type.iteritems ()} method, except that the iterator returned > ^^ > Please lose the parentheses. You just want the method's name, and you > already say that it's a method. So the parentheses don't add anything > except potential confusion. > >> +@end smallexample >> + >> +Then in gdb: > > You want @noindent before "Then in gdb", to make it look like > continuation of the previous paragraph, not a beginning of a new one. > > Also, please use @value{GDBN} instead of a literal "gdb". > >> +(gdb) python import gdb.types > > We use @value{GDBP} instead of a literal "(gdb)". > > OK with those changes. Thanks. Committed with those changes. paul