From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id iobUHTLtfGrcXiEAWB0awg (envelope-from ) for ; Wed, 12 Aug 2026 18:01:22 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=lokDPdcX; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 68BC51E09B; Wed, 12 Aug 2026 18:01:22 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E73C61E09B for ; Wed, 12 Aug 2026 18:01:21 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 001F24BA2E2D for ; Wed, 12 Aug 2026 22:01:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 001F24BA2E2D Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=lokDPdcX Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by sourceware.org (Postfix) with ESMTPS id AD7E64BA2E2D for ; Wed, 12 Aug 2026 22:00:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AD7E64BA2E2D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AD7E64BA2E2D Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::330 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786572055; cv=none; b=rxGcZ6Dq+u6AK94bco1I+xsuzv/vQalCmVIqL+nmfInfDJjqKV7T/P2wh0M0tFfeqwDPFVcufYXLcRRPgvN5ekoxP3LuK92/p935DHi4B0hBoKHCVXTJMU3rNzy7uuVf+JiRiMAHuErx45CMkzk1S6N/+VpcZSk4zllrUjpzW4s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786572055; c=relaxed/simple; bh=PmW8StMkAOXuSVMKKExQVSg0dDdWVppguXfBRtpIpT0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=deK+D2no9J67kkQ8o+6f4vmF+i5jLytKVNIQynqBN8mCFbYijKFdrpgHMWTeZ+X/t5yuyPf+x7u10f/eFGj7x5VRTpdHQYojUnqXqsirGn9nhAFL5YzDcZ6bUJScmkPa1TG2A/Zao2nuBIj+HUQCVcNWHRiRsKnqEdO4/8lh3Pk= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=lokDPdcX DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AD7E64BA2E2D Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-496bb7cdf51so17441865e9.2 for ; Wed, 12 Aug 2026 15:00:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786572054; x=1787176854; darn=sourceware.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to:content-type; bh=oZDzgeIrATOHhVoYVejspLVFWn6UEFrTVbWDu7ilCOQ=; b=lokDPdcXXvILhQK8kkYBiC22PR8Z2gVji6bAm5DMWdec1Q9rBOq4UUxQdrEOVrwm30 +di1yJK/IrEXzwW/9LeHc+Z2smtU+X0Wz4F7by/yufthYZt61vDIrxkAwSmQvKPIUxSO 0b6zvAdzivtSD2/Q+IH7KD0rDgKBpKd4BY+JL/50S0jh62BJlIMP40DQNjprkG5+M0mK I+DKQnutiB0QBQ0hbHrT7LjNvJ+WHjRwePoEsp7ylgUB9PlElRsIGamIJlOd3i8XjgTS RmZ3tIloU+/ssZBfq9mEhF7y3BfwQ0TZ+t9a/wbnZriCKyM0NClJJO9cLXNH5xBIfbW4 FMbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786572054; x=1787176854; h=content-transfer-encoding:content-type:in-reply-to:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=oZDzgeIrATOHhVoYVejspLVFWn6UEFrTVbWDu7ilCOQ=; b=SWamz/qKT+DBkDIKEnP7+i7/8AXT3UWX++stJFAsusGWFuyCrVB7DJZDNdkiqY6Prw HvCGeTIaSaSavMHIeysA++DrDeVVR72fK1ORXGF0WI8dX8C7e73P/kertXOYTDa1iKtA 3AwaoEg7ssslUjyMz27rzw3UrNxP87Rt28rc/pboy37i0bBih2myI7YuLhqD55pIhxAe O02S8VwDEfHTUdxPQtSvwjbtSess2597qLlUMlOWae+Imf4l2xiq+6+dfarfc5TfC3/s oS2F8Avn924qsKf82C1hbTeoP6RXvrnIJPZLhfdFzDrA52R0/DmDXtEmlGlQzyIoKwuN DaVg== X-Forwarded-Encrypted: i=1; AHgh+Rq7pkNBXX1qjsZ0Ab054jWOy2BfBgYLceGlcniBwFqoXnVPa6B1J2fsOxMv5NR8iEFyYgdEMRkJl9VdwQ==@sourceware.org X-Gm-Message-State: AOJu0YzLHW6KdX3ajwWpA54rXLozXwhWvRAZ2LSViV9kDFw6s2cV3CIv FhpbNa4ADhKYluX5DXx1TxlfT01WyYwW/DdOKi7LnCEJtAjSii6kVnBr X-Gm-Gg: AR+sD10fGODDNJB5cT/UUYCo+DuKVyVXZFVxQQth0KcQHYsbIJ8V2lQ5+nhLRAv3QKH ViFUz619Jd4CPQdnMwi9A+hE9ZAGly+uTJagMJ2t853wHTEEt1EEzWwWTjGPj/r0bxWxJQS0qju eSKUFaUXzRIANuFHUdOPSnQQlXZn+BNKwFAU/YzIH8znIGXcVA5JRxozfmDelBSjhaXxE/r2/pz PAh9SiGzeccTcdODoqtFMPWc6subV6a3eyA609S/ctb5fspKXobSX/AGMFbYo0bPgd+EmGDy6v4 LGZT5R7ke4JiTtkdbNJJczgo8CBl362RISQ7pN5fDE2EadRG3s6mfTOpWdrntwMTd+x9K72g3qY u2F6GJJ1Znx1XBbnNkDRw60aq5xNVIomKMyQhTf2+gTAcrjbk4aNJK/FL3amfXI2Mun8MldPt/H TbU0DYmpXvnLE1a0l2ioIKLAskCF9rS3NDefDITIMoBXtlaVr0Qnw1AhtiprGQ3dPqv97MHgN+m g== X-Received: by 2002:a05:600c:1da8:b0:495:4fd4:619b with SMTP id 5b1f17b1804b1-499821c36f1mr10512865e9.1.1786572054610; Wed, 12 Aug 2026 15:00:54 -0700 (PDT) Received: from [192.168.0.38] ([86.12.216.189]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49982121649sm10255675e9.1.2026.08.12.15.00.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Aug 2026 15:00:54 -0700 (PDT) Message-ID: <9284f90c-cf85-4b3c-b8d8-d1631c9d257a@gmail.com> Date: Wed, 12 Aug 2026 23:00:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/8] gdb/testsuite: Add Windows replacement for aligned_alloc Content-Language: en-US To: Hannes Domani , gdb-patches@sourceware.org References: <20260727174619.1089041-1-ssbssa.ref@yahoo.de> <20260727174619.1089041-1-ssbssa@yahoo.de> From: Luis In-Reply-To: <20260727174619.1089041-1-ssbssa@yahoo.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi, Just wondering if there are any tests planned or if the current tests are enough and what their results are. On 27/07/2026 18:42, Hannes Domani wrote: > _aligned_malloc has swapped arguments, and you have to use _aligned_free > to free the memory afterwards. > > This is enough to make i386-sse.exp pass, and i386-avx.exp will pass at > the end of this series. > --- > v2: > - Mention which test pass after the change in the commit message > --- > gdb/testsuite/gdb.arch/i386-avx.c | 2 +- > gdb/testsuite/gdb.arch/i386-sse.c | 2 +- > gdb/testsuite/lib/precise-aligned-alloc.c | 20 ++++++++++++++++++++ > 3 files changed, 22 insertions(+), 2 deletions(-) > > diff --git a/gdb/testsuite/gdb.arch/i386-avx.c b/gdb/testsuite/gdb.arch/i386-avx.c > index b6cd89e5bea..229093e5164 100644 > --- a/gdb/testsuite/gdb.arch/i386-avx.c > +++ b/gdb/testsuite/gdb.arch/i386-avx.c > @@ -116,7 +116,7 @@ main (int argc, char **argv) > > puts ("Bye!"); /* second breakpoint here */ > > - free (allocated_ptr); > + aligned_free (allocated_ptr); > > return 0; > } > diff --git a/gdb/testsuite/gdb.arch/i386-sse.c b/gdb/testsuite/gdb.arch/i386-sse.c > index 21264ed74e7..5210aee12c3 100644 > --- a/gdb/testsuite/gdb.arch/i386-sse.c > +++ b/gdb/testsuite/gdb.arch/i386-sse.c > @@ -134,7 +134,7 @@ main (int argc, char **argv) > puts ("Bye!"); /* second breakpoint here */ > } > > - free (allocated_ptr); > + aligned_free (allocated_ptr); > > return 0; > } > diff --git a/gdb/testsuite/lib/precise-aligned-alloc.c b/gdb/testsuite/lib/precise-aligned-alloc.c > index 888814f12ef..1db35528bc8 100644 > --- a/gdb/testsuite/lib/precise-aligned-alloc.c > +++ b/gdb/testsuite/lib/precise-aligned-alloc.c > @@ -21,6 +21,26 @@ > #include > #include > > +#ifdef _WIN32 > +static void * > +aligned_alloc (size_t alignment, size_t size) > +{ > + return _aligned_malloc (size, alignment); > +} > + > +static void > +aligned_free (void *ptr) > +{ > + _aligned_free (ptr); > +} > +#else > +static void > +aligned_free (void *ptr) > +{ > + free (ptr); > +} > +#endif > + > /* Return true if address P is ALIGNMENT-byte aligned. */ > > static int