From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66588 invoked by alias); 10 May 2017 03:06:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 65303 invoked by uid 89); 10 May 2017 03:06:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 10 May 2017 03:06:52 +0000 Received: by simark.ca (Postfix, from userid 33) id 73CF31E4A4; Tue, 9 May 2017 23:06:53 -0400 (EDT) To: Tim Wiederhake Subject: Re: [PATCH v3 07/12] btrace: Remove struct btrace_thread_info::{begin,end}. X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 10 May 2017 03:06:00 -0000 From: Simon Marchi Cc: gdb-patches@sourceware.org, markus.t.metzger@intel.com In-Reply-To: <1494312929-22749-8-git-send-email-tim.wiederhake@intel.com> References: <1494312929-22749-1-git-send-email-tim.wiederhake@intel.com> <1494312929-22749-8-git-send-email-tim.wiederhake@intel.com> Message-ID: <9281516a3c72ea0fe56f4d97208c2946@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.5 X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00237.txt.bz2 On 2017-05-09 02:55, Tim Wiederhake wrote: > These are no longer needed and might hold invalid addresses once we > change the > vector of function segment pointers into a vector of function segment > objects > where a reallocation of the vector changes the address of its elements. > > 2017-05-09 Tim Wiederhake > > gdb/ChangeLog: > > * btrace.c (ftrace_new_function, ftrace_new_call, ftrace_new_tailcall, > ftrace_new_return, ftrace_new_switch, ftrace_new_gap, > ftrace_update_function, ftrace_compute_global_level_offset, > btrace_compute_ftrace_bts, ftrace_add_pt, btrace_compute_ftrace_pt, > btrace_stitch_bts, btrace_fetch, btrace_clear, btrace_insn_number, > btrace_insn_end, btrace_is_empty): Remove references to > btrace_thread_info::begin and btrace_thread_info::end. > * btrace.h (struct btrace_thread_info): Remove BEGIN and END. > * record-btrace.c (record_btrace_start_replaying): Remove reference to > btrace_thread_info::begin. LGTM.