From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MraXN1cZdmRe4hgAWB0awg (envelope-from ) for ; Tue, 30 May 2023 11:42:15 -0400 Received: by simark.ca (Postfix, from userid 112) id D57A41E11E; Tue, 30 May 2023 11:42:15 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=xX0I6oIb; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_HI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DEC611E0D6 for ; Tue, 30 May 2023 11:42:14 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D7D753858433 for ; Tue, 30 May 2023 15:42:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D7D753858433 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1685461332; bh=MDQGxHJP7S0WPVhINvlw7Kx7YPl1FH94rkXcdFMBFPE=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=xX0I6oIbQ+Y/dt6FV+auc9xJmH9k+fLbE/RJ1OYQHgw7sX4fkeb6MrJdKQ6D7ftg4 QHSsHbS31lng/E76PogdTMirhfNupLVRkBmNu3b6tw8h+52M0LD/9kRhFjWedqG8aU 65VkBR1vN9q+9qWyl0d42oczH1M6VTbc1zzSO9Pw= Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 106A03858D20 for ; Tue, 30 May 2023 15:41:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 106A03858D20 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3C4AE219DD; Tue, 30 May 2023 15:41:52 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2A94413597; Tue, 30 May 2023 15:41:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id WABmCUAZdmTeFAAAMHmgww (envelope-from ); Tue, 30 May 2023 15:41:52 +0000 Message-ID: <92070c95-9c75-a89b-70ae-695c3a1de219@suse.de> Date: Tue, 30 May 2023 17:41:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] [gdb] Mention --with/without-system-readline for --configuration Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20230530093344.12517-1-tdevries@suse.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 5/30/23 15:36, Simon Marchi wrote: > On 5/30/23 05:33, Tom de Vries wrote: >> Simon reported that the new test-case gdb.tui/pr30056.exp fails with system >> readline. >> >> This is because the test-case requires a fix in readline that's present in our >> in-repo copy of readline, but most likely not in any system readline yet. >> >> Fix this by: >> - mentioning --with-system-readline or --without-system-readline in the >> configuration string. >> - adding a new proc with_system_readline that makes this information available >> in the testsuite. >> - using this in test-case gdb.tui/pr30056.exp to declare it unsupported for >> --with-system-readline. >> >> Tested on x86_64-linux. >> >> Reported-By: Simon Marchi > > I confirm this makes the test skipped on my machine. > > Once the fix is merged and in a readline release, could we make the skip > conditional on the readline version? We could have a maintenance > command or something like that that outputs RL_READLINE_VERSION, and > skip only for old readline versions. We could do that, that sounds useful. I also considered printing the readline version string after --with/without-system-readline, but it looked a bit too different to all the other lines. Do you want have this implemented before, or are ok with the fix as is? Thanks, - Tom