From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7298 invoked by alias); 17 Apr 2014 12:44:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7278 invoked by uid 89); 17 Apr 2014 12:44:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=BAYES_00,KAM_STOCKGEN,SPF_PASS autolearn=no version=3.3.2 X-HELO: forward-corp1g.mail.yandex.net Received: from forward-corp1g.mail.yandex.net (HELO forward-corp1g.mail.yandex.net) (95.108.253.251) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 17 Apr 2014 12:44:35 +0000 Received: from smtpcorp4.mail.yandex.net (smtpcorp4.mail.yandex.net [95.108.252.2]) by forward-corp1g.mail.yandex.net (Yandex) with ESMTP id A0BA336601D9; Thu, 17 Apr 2014 16:44:31 +0400 (MSK) Received: from smtpcorp4.mail.yandex.net (localhost [127.0.0.1]) by smtpcorp4.mail.yandex.net (Yandex) with ESMTP id 6D4402C0885; Thu, 17 Apr 2014 16:44:31 +0400 (MSK) Received: from unknown (unknown [2a02:6b8:0:408:85c6:6eff:bc6:8181]) by smtpcorp4.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id ncgAmzKVjT-iVNKkVLo; Thu, 17 Apr 2014 16:44:31 +0400 (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client certificate not present) X-Yandex-Uniq: d2d131d8-6afe-4a9e-adc6-b5e798df75aa Authentication-Results: smtpcorp4.mail.yandex.net; dkim=pass header.i=@yandex-team.ru Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\)) Subject: Re: [PATCH v2 2/3] gdb/python: raise TypeError instead of abort on calling value method for label symbol object From: Maxim Bublis In-Reply-To: <8DDE7431-40A7-4C4F-9681-E60A712710A1@yandex-team.ru> Date: Thu, 17 Apr 2014 12:44:00 -0000 Cc: gdb-patches@sourceware.org Content-Transfer-Encoding: quoted-printable Message-Id: <91E92C60-717C-4B39-956F-F705E2AC6426@yandex-team.ru> References: <1394026864-4691-1-git-send-email-satori@yandex-team.ru> <1394026864-4691-2-git-send-email-satori@yandex-team.ru> <534B9118.9010307@redhat.com> <8DDE7431-40A7-4C4F-9681-E60A712710A1@yandex-team.ru> To: Phil Muldoon X-SW-Source: 2014-04/txt/msg00365.txt.bz2 Hi, Phil. > So, it doesn=92t look like some deeper problem in GDB for me, just incomp= leteness of Python API. > There is very similar =93if=94 condition for LOC_TYPEDEF in patched code. I=92ve inspected code some more. It seems to me there is a bug in gdb/findv= ar.c:466. According to gdb/mdebugread.c:694, it is pretty clear that label symbol alw= ays has type of builtin integer: SYMBOL_TYPE (s) =3D objfile_type (objfile)->builtin_int; but store_typed_address expects TYPE_CODE_PTR or TYPE_CODE_REF, so instead = of store_typed_address there should be something like store_unsigned_integer. Am I correct with my guess? >From gdb-patches-return-111876-listarch-gdb-patches=sources.redhat.com@sourceware.org Thu Apr 17 13:35:32 2014 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 4119 invoked by alias); 17 Apr 2014 13:35:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 4106 invoked by uid 89); 17 Apr 2014 13:35:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 17 Apr 2014 13:35:29 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 2937A1160B7; Thu, 17 Apr 2014 09:35:27 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id guNeo-WFyJZ2; Thu, 17 Apr 2014 09:35:27 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 0056A1160AD; Thu, 17 Apr 2014 09:35:26 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 3BDD1E041B; Thu, 17 Apr 2014 06:35:34 -0700 (PDT) Date: Thu, 17 Apr 2014 13:35:00 -0000 From: Joel Brobecker To: Marcus Shawcroft Cc: "gdb-patches@sourceware.org" Subject: Re: [PATCH] Drop srcdir from untested source path. Message-ID: <20140417133534.GX4250@adacore.com> References: <534FA596.6040502@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <534FA596.6040502@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-04/txt/msg00366.txt.bz2 Content-length: 1320 > 2014-04-17 Marcus Shawcroft > > * gdb.java/jnpe.exp: Drop srcdir from untested path. LGTM! > commit 0e3c473a07b06ebd742478b7a602fcb9ebfc7388 > Author: Marcus Shawcroft > Date: Mon Mar 31 14:25:36 2014 +0100 > > [PATCH] Drop srcdir from untested source path. > > diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog > index c230f8c..e9e8249 100644 > --- a/gdb/testsuite/ChangeLog > +++ b/gdb/testsuite/ChangeLog > @@ -1,5 +1,9 @@ > 2014-03-31 Marcus Shawcroft > > + * gdb.java/jnpe.exp: Drop srcdir from untested path. > + > +2014-03-31 Marcus Shawcroft > + > * lib/gdb.exp (gdb_compile_pthreads, gdb_compile_objc): Drop prefix > from unsupported source file path. > > diff --git a/gdb/testsuite/gdb.java/jnpe.exp b/gdb/testsuite/gdb.java/jnpe.exp > index 054ade8..bd47f109c 100644 > --- a/gdb/testsuite/gdb.java/jnpe.exp > +++ b/gdb/testsuite/gdb.java/jnpe.exp > @@ -17,7 +17,7 @@ load_lib "java.exp" > > standard_testfile .java > if { [compile_java_from_source $srcdir/$subdir/$srcfile $binfile "-g"] != "" } { > - untested "Couldn't compile ${srcdir}/$subdir/${srcfile}" > + untested "Couldn't compile $subdir/${srcfile}" > return -1 > } > -- Joel