Re: [RFC/dwarf-2] Add support for included files

Joel Brobecker
2004-05-03T16:25:05Z

> Let me make sure I've got it right. When we're calling
> dwarf_decode_lines for the partial symbol tables, we never call
> dwarf2_start_subfile anyway --- that's for building full symbol tables
> --- so the use of 'dirname' in that function doesn't matter. And
> since it's never used to compute the full name of the symtabs, it
> doesn't introduce inconsistencies to omit it.

That's right. I updated a bit the comment for that function to include
this information. I think it was worthwhile. Here is the new comment
describing the function. If you think any change needs to be made, let
me know, I'll gladly make them.

2. If PST is not NULL, this procedure reads the program to determine
the list of files included by the unit represented by PST, and
builds all the associated partial symbol tables. In this case,
the value of COMP_DIR is ignored, and can thus be NULL (the COMP_DIR
is not used to compute the full name of the symtab, and therefore
omitting it when building the partial symtab does not introduce
the potential for inconsistency - a partial symtab and its associated
symbtab having a different fullname -). */

> If that's correct, then this patch is ready to commit. Thanks very
> much!

Thanks a lot! This patch is now in.

--
Joel