Re: [RFC/dwarf-2] Add support for included files

Jim Blandy
2004-04-16T04:24:25Z

Joel Brobecker <brobecker@gnat.com> writes:
> Using the approach you suggest (which I like): We need to define a
> couple of wrapper functions around start_subfile and record_line
> because their profile will not match the profile of our callbacks.
> We'll need 3 callbacks per case (3 for psymtabs, 3 for symtabs).
> We'll also have to use void* pointers if we want to make the context
> generic, which I would prefer to avoid. It's great for heavily reused
> code, but is this worth it for this function.

Maybe not.

If you add a comment above dwarf_decode_lines explaining how it's
called, and that PST determines whether we're building psymtabs or
symtabs, we'll call it even.

I just approved Daniel's mondo psymtab construction patch, so one of
you is going to get in the others' way. Have fun.