From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86750 invoked by alias); 18 Jul 2017 22:31:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 85329 invoked by uid 89); 18 Jul 2017 22:31:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=progression, hel X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Jul 2017 22:30:59 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9F682C04B939 for ; Tue, 18 Jul 2017 22:30:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9F682C04B939 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 9F682C04B939 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id AA9EF67CD9; Tue, 18 Jul 2017 22:30:56 +0000 (UTC) Subject: Re: [PATCH 25/40] Introduce lookup_name_info and generalize Ada's FULL/WILD name matching To: Keith Seitz , gdb-patches@sourceware.org References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-26-git-send-email-palves@redhat.com> <596E6C31.1060908@redhat.com> From: Pedro Alves Message-ID: <918c8d65-4c5d-7c04-c2a3-736b7a20d454@redhat.com> Date: Tue, 18 Jul 2017 22:31:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <596E6C31.1060908@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-07/txt/msg00266.txt.bz2 On 07/18/2017 09:14 PM, Keith Seitz wrote: > On 06/02/2017 05:22 AM, Pedro Alves wrote: > > utils.[ch]? Wrong ChangeLog? Whoops. > > I'm seeing regressions with this patch (no subsequent patch seems to fix it, either): > > FAIL: gdb.ada/arrayidx.exp: print u_one_two_three, indexes off > FAIL: gdb.ada/arrayidx.exp: print u_one_two_three > FAIL: gdb.ada/disc_arr_bound.exp: print r > FAIL: gdb.ada/disc_arr_bound.exp: print r.a > FAIL: gdb.ada/mi_dyn_arr.exp: create bt varobj (unexpected output) > FAIL: gdb.ada/pckd_arr_ren.exp: print var > Fun. From the file names, sounds like they're all related to dynamic arrays. I don't see those. Likely this is compiler related. I'm on F23, with GNAT 5.3.1. This patch actually causes a progression for me: -KFAIL: gdb.ada/str_ref_cmp.exp: operator = works for strings (PRMS: ada/12607) -UNTESTED: gdb.ada/str_ref_cmp.exp: str_ref_cmp.exp +PASS: gdb.ada/str_ref_cmp.exp: operator = works for strings +PASS: gdb.ada/str_ref_cmp.exp: print String_Var (1 .. 3) = "Hel" +PASS: gdb.ada/str_ref_cmp.exp: print String_Var (1 .. 3) = "hel" (triple-checked this.) Here are the gdb.ada/ *FAILs I see before the patch: $ grep FAIL gdb.sum KFAIL: gdb.ada/array_ptr_renaming.exp: print ntp (PRMS: gdb/NNNN) KFAIL: gdb.ada/bad-task-bp-keyword.exp: break *break_me'address TASK Task TaSK 2 (PRMS: gdb/14111) XFAIL: gdb.ada/dyn_loc.exp: info locals XFAIL: gdb.ada/funcall_ref.exp: p get ("Hello world!") XFAIL: gdb.ada/funcall_ref.exp: ptype get ("Hello world!") FAIL: gdb.ada/fun_renaming.exp: print next(1) (timeout) FAIL: gdb.ada/fun_renaming.exp: print n(1) XFAIL: gdb.ada/fun_renaming.exp: print renamed_next(1) XFAIL: gdb.ada/fun_renaming.exp: print pack.renamed_next(1) FAIL: gdb.ada/mi_ex_cond.exp: catch C_E if i = 2 (unexpected output) FAIL: gdb.ada/mi_ex_cond.exp: run to exception catchpoint hit (unknown output after running) FAIL: gdb.ada/mi_ex_cond.exp: -break-list (unexpected output) KFAIL: gdb.ada/str_ref_cmp.exp: operator = works for strings (PRMS: ada/12607) Thanks, Pedro Alves