From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kXtUIlxn8mmGNgQAWB0awg (envelope-from ) for ; Wed, 29 Apr 2026 16:17:32 -0400 Received: by simark.ca (Postfix, from userid 112) id 895561E093; Wed, 29 Apr 2026 16:17:32 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1D6A71E093 for ; Wed, 29 Apr 2026 16:17:32 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id B0E744BBCDA3 for ; Wed, 29 Apr 2026 20:17:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B0E744BBCDA3 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by sourceware.org (Postfix) with ESMTPS id 56EC34BBCDBA for ; Wed, 29 Apr 2026 20:17:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 56EC34BBCDBA Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 56EC34BBCDBA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777493828; cv=none; b=dqW9iKOVXzRihJLtWkyV6tMeD2dY4nTC0kwPsSG3zA8XEHqoGXyfKToJpX4zkY5ghom00uiIQWYYn3bYf4oA8cSyJkSY+OekYcJ8SQgjNKQO5BijnWdCklO3WFN8V36o8sP/uu/CajzZFd3+64pYmj0KN4SVtMY3G+JhFXQZgns= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777493828; c=relaxed/simple; bh=05xpU8pbENdfaYmW6/5QzqtKbXTyY3ca1hV2P0USLug=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=GTOpdy39/wXhDlhK7qHNLnm1HgzfY/wGSujuzWoIkjzIivk5T7xzDW5d7741e2GKrEu2s6m43cIQHV2McwwSPRqgOAwvbwG3krkGSAf1SPKckXkwGxeZxC8cZd8J7imLA/YRnhSIQat3t2FRToVOGIemdLqLmj+ZmQhkhM3eTcY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 56EC34BBCDBA Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4891f625344so2137225e9.0 for ; Wed, 29 Apr 2026 13:17:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777493827; x=1778098627; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CemabZz5Q3j9qsOTe2UqrQTaSGgHwAEFwgDwJ0k4VvE=; b=BpLMMGkHhUMbXMjMa4hV9/taxGHSV3sJUSf5rIj9kNUUdASoZYV/4902FB3d2FVmNX 4iXt+khok9iE7vyIpFyvq1V0hhdG71P8aQU8VW+F2eHE3XcdtBY6E/tRI5eho7Az4W30 87m8G6PS5l9WSG732Vq49eL/jjWek8ZMcJfz3mZe0V9QYUaPxm5ptQNJTo7XT+kLEDZ6 fyY6ShAK9Fv65JsqHgSmrm64N2F6pwLGX+ACeo7jXVtBeCJI1zX9dNbAeCoHEPaUjI1a hcC1Hq2w0dpb2U4BCJG9cmcPpf2IZfgmgUfemaT4XtDYG4QospmKoz7H6G938ZRroBZO QVZw== X-Gm-Message-State: AOJu0YwNPyv/nIE452kNVC6iNLTI0jZ+AQiwISSD43/UozyhVrIWIpR9 C+9KpxPdva+n5VJOWeebZuD0Jzd2f3Rg8fyjlAfgLciHhSAt+2MU1QtG/K+BgQ== X-Gm-Gg: AeBDiev9nHF0xOwS0qBNkb0pdpxGgYZJnGAlE98+7DQjgB1DCpOXmrd91Gzfe/vXNfG BXLaSjx0VHSYeFCqzERAmhPFTwd3a+JdG6Sf9eZtFQO7TIbPW/SPkHwKpzdYsWYL727DnEGUk4X P0l4boEETCjBFBRfLEuVcl/d8/pSka9O9lQYbFamkrprgXB0CxJvbxovmgQNaZImKWmzE2zU4xy +21qBjFxPD7up35ivUieA1znf2U10tR8DxtiUkeBd+PSJY9A/nUcTDMn34Gp5v7mEY1+nTToz4+ v7mbCNxCKTBudWAriLL2HTSUCia4PwXVvf6sIKRXh/9qBdfmzoug72PIiN/BuI3xbBLBV2csYBZ O2yiGH2fu8D+7IVMMhyUBJIpwlTHnUB9EIHoXwrgIVjK+dW35RedmQGGA64IJE16r5bpa6uBSAI qx/H/IIpO5+U/YUr/g6ok+e0qyIAeGfRjjFyVNZERx6pKxW72rd/qg2bKmR/e2FlWh3SthOPHbZ g== X-Received: by 2002:a05:600d:84ca:20b0:489:1927:5c0 with SMTP id 5b1f17b1804b1-48a7c811a96mr51483665e9.0.1777493827226; Wed, 29 Apr 2026 13:17:07 -0700 (PDT) Received: from ?IPV6:2001:8a0:facb:a800:f22f:591f:e700:e91? ([2001:8a0:facb:a800:f22f:591f:e700:e91]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-447b7ca67b9sm6456647f8f.34.2026.04.29.13.17.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Apr 2026 13:17:06 -0700 (PDT) Message-ID: <917b4a78-7570-41c8-99ec-34b571939c93@palves.net> Date: Wed, 29 Apr 2026 21:17:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 41/47] Windows gdb: Watchpoints while running (internal vs external stops) To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20250519132308.3553663-1-pedro@palves.net> <20250519132308.3553663-42-pedro@palves.net> <87cybp258d.fsf@tromey.com> From: Pedro Alves Content-Language: en-US In-Reply-To: <87cybp258d.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi Tom, On 2025-05-30 21:50, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> Teach the Windows target to temporarily pause all threads when we > Pedro> change the debug registers for a watchpoint. Implements the same > Pedro> logic as Linux uses: > [...] > > I doubt I'll be able to understand this particular patch without > debugging it myself or something, but I read through it and didn't see > anything obviously out of wack. > > Pedro> and DR7. Defering the actualy writes to ::wait avoids a bunch of > > s/actualy/actual/ Thanks, fixed in v3. > > Pedro> +static void > Pedro> +debug_registers_changed_all_threads () > Pedro> +{ > Pedro> + auto *win_tgt = static_cast (get_native_target ()); > > Probably checked_static_cast? > I did this. > Reviewed-By: Tom Tromey > > Tom Thanks, Pedro Alves