From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id fS9fNkg/qV8PawAAWB0awg (envelope-from ) for ; Mon, 09 Nov 2020 08:08:24 -0500 Received: by simark.ca (Postfix, from userid 112) id D1A6A1F08B; Mon, 9 Nov 2020 08:08:24 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6011A1E58E for ; Mon, 9 Nov 2020 08:08:24 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C7F43388A418; Mon, 9 Nov 2020 13:08:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C7F43388A418 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1604927303; bh=aA9sfmNkKvpKVEiegJUnz49W1q0csTDk4+4AjtvORi8=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=r4NYjoUL+Oke0647jz4lphOHI0H5c1opryDcVzkzVIdstzwQej8LeHwqWycUkVyI7 8+DQrf5uQojilJyr+27lXrhJB/old3GOfUlodAJUwcO58JTIJ7Zj6fYZhj9UPU8YsP M+mKJu9EjFLt8n/WMhoN+AQfzGRrz+P2brpt6Ev4= Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id AEC77388A418 for ; Mon, 9 Nov 2020 13:08:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AEC77388A418 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0A9D3K8j059755 for ; Mon, 9 Nov 2020 08:08:20 -0500 Received: from ppma05wdc.us.ibm.com (1b.90.2fa9.ip4.static.sl-reverse.com [169.47.144.27]) by mx0b-001b2d01.pphosted.com with ESMTP id 34q5cwsyhn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 09 Nov 2020 08:08:20 -0500 Received: from pps.filterd (ppma05wdc.us.ibm.com [127.0.0.1]) by ppma05wdc.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 0A9D6pSj025988 for ; Mon, 9 Nov 2020 13:08:19 GMT Received: from b03cxnp07029.gho.boulder.ibm.com (b03cxnp07029.gho.boulder.ibm.com [9.17.130.16]) by ppma05wdc.us.ibm.com with ESMTP id 34nk78qb7v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 09 Nov 2020 13:08:19 +0000 Received: from b03ledav006.gho.boulder.ibm.com (b03ledav006.gho.boulder.ibm.com [9.17.130.237]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0A9D8C1Y17695278 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 9 Nov 2020 13:08:12 GMT Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 20DF2C6061; Mon, 9 Nov 2020 13:08:11 +0000 (GMT) Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 52788C6057; Mon, 9 Nov 2020 13:08:10 +0000 (GMT) Received: from localhost.localdomain (unknown [9.85.193.246]) by b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTP; Mon, 9 Nov 2020 13:08:09 +0000 (GMT) Subject: Re: [PATCH v1] [powerpc] Remove 512 bytes region limit if using 2nd DAWR. To: Ulrich Weigand References: <20201109021204.48664-1-rcardoso@linux.ibm.com> <20201109102434.GA12858@oc3748833570.ibm.com> Message-ID: <916089d8-f003-6e23-2180-8d96d7b3ce6b@linux.ibm.com> Date: Mon, 9 Nov 2020 10:08:09 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201109102434.GA12858@oc3748833570.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312, 18.0.737 definitions=2020-11-09_02:2020-11-05, 2020-11-09 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 phishscore=0 mlxscore=0 spamscore=0 adultscore=0 malwarescore=0 impostorscore=0 mlxlogscore=991 clxscore=1015 bulkscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011090089 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Rogerio Alves via Gdb-patches Reply-To: Rogerio Alves Cc: pedromfc@linux.ibm.com, gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 11/9/20 7:24 AM, Ulrich Weigand wrote: > On Sun, Nov 08, 2020 at 11:12:04PM -0300, Rogerio Alves wrote: >> Power 10 introduces the 2nd DAWR (second watchpoint) and also removed >> a restriction that limit the watch region to 512 bytes. >> >> 2020-11-08 Rogerio A. Cardoso >> >> gdb/ >> >> * ppc-linux-nat.c: (PPC_DEBUG_FEATURE_DATA_BP_ARCH_31): New define. >> (region_ok_for_hw_watchpoint): Check if 2nd DAWR is avaliable before set >> region. > > This doesn't look correct, the patch not only removes the alignment > requirement but actually removes support for 512 bytes ranges itself! > The patch doesn't remove the support. If we are using the second watchpoint (PPC_DEBUG_FEATURE_DATA_BP_ARCH_31) we don't limit the region_size to 512 (region_size = 512) instead we use hwdebug_info.data_bp_alignment right? Isn't region_size that create a 512-byte bondary? > I think for P10 we need to continue to allow watched ranges up to > 512 bytes in size, but they only need to be 8 byte aligned now and > may cross a 512-byte boundary. > Since the else case is region_size = hwdebug_info.data_bp_alignment; I guess this is what it do unless I am missing something here. > Bye, > Ulrich >