From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id fje4I3Sf6WWmFzwAWB0awg (envelope-from ) for ; Thu, 07 Mar 2024 06:05:24 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=iX4Kx57v; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 829731E0D2; Thu, 7 Mar 2024 06:05:24 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4A2E81E092 for ; Thu, 7 Mar 2024 06:05:22 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C4124385840C for ; Thu, 7 Mar 2024 11:05:21 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 1BBE43858401 for ; Thu, 7 Mar 2024 11:05:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1BBE43858401 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1BBE43858401 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709809502; cv=none; b=k+Tv6IM6sh8tTfU3+lGjURYT99C9gIUFGSOf/D9idccIwuHDys+xwpwFPrAHU99BF/oBeFFs+sbMw003+DE3i62N9D89PcheBJ/32CUCLjuOPJmXIkSDObGMdPB1CK0X6RTAxXZuRTwI8KX2eotbssjwCWU50hQvcshzTRv18wQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709809502; c=relaxed/simple; bh=SnDeKrUt4EqpADCKaPul+zjZ3TldUiTBykcwFuvcnC0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=uf3sLUXU8HAVuwllPBT8+XwSH20xl7cEs0rhkzAc1UZmyg9Tf1xo1Dek3xH6NfZGqqA1GrLfEVSJmn2ZLYwelvbPBZEdk3rqJ+X6Pp1PUGfQAYYIFgWkjNa/EaefnaLJdtlMj8eCFWiMj6FiIem31JyMGe5NIxiX52WzgkrPYRo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709809500; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ub3Q3GBv5cUWbgpn0ShuvLqXf8UZRVXG5dRRETcCQ44=; b=iX4Kx57vHTFqCKBv8reUrpqnqAl69k2Z5VnH25nG1mqW3a05c1Oe8LhKCHXX0hvREJhwxC 7VjH8BPYy2mpGDEiym3GlUAmqQljSUqMW56+gKB1EqTwlz7pkJTfNO3U1LgSAxupe13//F 4Vw8TCqxBdpep2f8PO189dqev5bgjvU= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-489-dQj95MRsMOOGOG-HV2pkNg-1; Thu, 07 Mar 2024 06:04:59 -0500 X-MC-Unique: dQj95MRsMOOGOG-HV2pkNg-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-5134251ef6eso822966e87.2 for ; Thu, 07 Mar 2024 03:04:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709809497; x=1710414297; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ub3Q3GBv5cUWbgpn0ShuvLqXf8UZRVXG5dRRETcCQ44=; b=JVMtuwTsSgEfENFCHber69TA0uyXNJBrMzYowaU6ICfMZxga1A7Mzl0zj3C1aAiiDq R6lvxdog1EFmvW8JqQEHlSiu5+oEAiBHevP7qHrLZLQDe6fQCLJDZGED8PJ0FYRoLUUA mjr2D32P5VbEUmKxxZ+zzgRkEMLYVIXxVUzLzzjawpjz+SpyDOB7A2UENTq1rCZxbJID Uf3xuYnd2BBlnM9zIyeoBu4qXtn+CU65+tNTNVCSUcjAV9oIvELz0AV8xhSv4TQRAmgd nhUXQnumLo7pi9fny9rX8ZERq3+VqFHQt6CnR4zViE60B75wv8P8ttXxmLCamQtG+xXl Rrbw== X-Gm-Message-State: AOJu0YzEqgGBOD2kycwFR8a2ViE6tEGek9lZWbeZDxi5IhGON+NYlzZ2 OGQuzMGjUOyzQAB3sVV9JNIZYFgNYJO85LM3LmK7TGST8+1ngF3uH3mH9nM3EjcwX2i10yLINHZ Tp5iOTJGj+amyewiZXCI1HGDTMM8VYwewLcBnwwXAJidAtyYIPpjywaJZh0c= X-Received: by 2002:a05:6512:4851:b0:513:54c6:9f68 with SMTP id ep17-20020a056512485100b0051354c69f68mr1106017lfb.18.1709809497680; Thu, 07 Mar 2024 03:04:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IHloCh+bKgGH/ZrlCcR/uyH8lYYJMXJlh7WBNdul7PZLCrb/cTAYG/z6LgSEFhpW/HAQ4Q0uQ== X-Received: by 2002:a05:6512:4851:b0:513:54c6:9f68 with SMTP id ep17-20020a056512485100b0051354c69f68mr1106002lfb.18.1709809497257; Thu, 07 Mar 2024 03:04:57 -0800 (PST) Received: from [192.168.0.129] (ip-94-112-227-180.bb.vodafone.cz. [94.112.227.180]) by smtp.gmail.com with ESMTPSA id d8-20020a05600c4c0800b004130889c7b3sm2204653wmp.34.2024.03.07.03.04.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Mar 2024 03:04:56 -0800 (PST) Message-ID: <91227694-38ae-4d2a-abe6-688d6c751746@redhat.com> Date: Thu, 7 Mar 2024 12:04:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] gdb: Migrate frame unwinders to use C++ classes To: Lancelot SIX Cc: gdb-patches@sourceware.org References: <20240306125135.766567-1-blarsen@redhat.com> <20240306125135.766567-4-blarsen@redhat.com> <20240307110133.lhu7kcqvmqnxmmw2@khazad-dum> From: Guinevere Larsen In-Reply-To: <20240307110133.lhu7kcqvmqnxmmw2@khazad-dum> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 07/03/2024 12:01, Lancelot SIX wrote: > On Wed, Mar 06, 2024 at 01:51:34PM +0100, Guinevere Larsen wrote: > > Hi Gwen, > > I have not read the specific of this series, but testing the patches as > is causes a build failure on amdgpu-tdep.c > >> diff --git a/gdb/amdgpu-tdep.c b/gdb/amdgpu-tdep.c >> index 8189de8e565..45c83a562e8 100644 >> --- a/gdb/amdgpu-tdep.c >> +++ b/gdb/amdgpu-tdep.c >> @@ -892,7 +892,7 @@ amdgpu_frame_prev_register (const frame_info_ptr &this_frame, void **this_cache, >> return frame_unwind_got_register (this_frame, regnum, regnum); >> } >> >> -static const frame_unwind amdgpu_frame_unwind = { >> +static const frame_unwind_legacy amdgpu_frame_unwind ( >> "amdgpu", >> NORMAL_FRAME, >> FRAME_UNWIND_ARCH, >> @@ -903,7 +903,7 @@ static const frame_unwind amdgpu_frame_unwind = { >> default_frame_sniffer, >> nullptr, >> nullptr, > ^ > Moving from the aggregate initializer to a regular constructor call, > this last coma must be removed. > > With this fixed, I tested this series on the gdb.rocm/*.exp part (both > on upstream GDB and our downstream port) and see no regression. Huh... it seems that the amdgpu target is not compiled when I used `--enable-targets=all`, since I didn't get this build failure locally. Thanks for spotting that, I'll update the patch locally! -- Cheers, Guinevere Larsen She/Her/Hers > > I'll try to actually read the actual later. > > Best, > Lancelot. > >> -}; >> +); >> >> static int >> print_insn_amdgpu (bfd_vma memaddr, struct disassemble_info *info) >> >> -- >> 2.43.2 >>