From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WwBIO05GjmflaBUAWB0awg (envelope-from ) for ; Mon, 20 Jan 2025 07:49:18 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=esqRXhKJ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E2AED1E100; Mon, 20 Jan 2025 07:49:18 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 777D81E08E for ; Mon, 20 Jan 2025 07:49:18 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 169A9385843B for ; Mon, 20 Jan 2025 12:49:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 169A9385843B Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=esqRXhKJ Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 0F02E3858431 for ; Mon, 20 Jan 2025 12:48:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0F02E3858431 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0F02E3858431 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737377309; cv=none; b=j1cnlb3n8QbjZx3zM+3HU9bn3ZSTrbrvcFrcG2HCG8nHJDhsFlebT2arH6Jy47qCWFxNsBz78kf6M+CsPpLLekODENZ7RD2Ghjz5VZQ9ZHiRgKvSyh1JWvyBnWedVgBW3h5T6nl4Rc7jF+8E2oM6l/Gh1K9mLK1skoCPPhAVGVE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737377309; c=relaxed/simple; bh=tNywUNjpJuRf7BSooD15aq15utT8Fk4A1cB6z+jAi7A=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=iFfT61yEbGs+G/XQiFll5plAURJCPyy7G1U0bHPBki3eadTdjUhS2HmtZk5IfhUFBo2SL/hbTji8GCxydGqggaMLlBpa7v3j7SMPn+PNTzK12+YP2WtHbPUMXJuetpRtXcpd+UM4WT5MJ53uihs9yg08iDxGWSvkN9EmemtCEjw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0F02E3858431 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737377308; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RgdQWQew41SAZWYFsjkQ69YMc2iBs2rW+JV7I/ZatAc=; b=esqRXhKJSyMerU3ahe4h09SaYE6VN+zQ/0u2Jv332GzNlJmiV+4zJ85zaYYOeaCGeUsOUn yX4VaqLOgCqKgqqwODbQQiDHJOY61b0aiuufIjmMY8ab4kpHtz7y0wFq7L7aByB28A057s zCLEoutOKNpcxVFHSYw03WkpbPKbKh0= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-694-Pat0DoekP6i4aSI6uw5OTQ-1; Mon, 20 Jan 2025 07:48:27 -0500 X-MC-Unique: Pat0DoekP6i4aSI6uw5OTQ-1 X-Mimecast-MFC-AGG-ID: Pat0DoekP6i4aSI6uw5OTQ Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-21631cbf87dso86207575ad.3 for ; Mon, 20 Jan 2025 04:48:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737377306; x=1737982106; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RgdQWQew41SAZWYFsjkQ69YMc2iBs2rW+JV7I/ZatAc=; b=gBiEQtvhb1XRAd77lmyGzipYcBIN/CxyVxi/Ug9To65VxVrHOh5HXEQU3uJM+bitWB 8zW1UrYoFlzSXXwusLCdTL4s7Ihc5L27TMM8/3NEcAyq1PpH3AJKMFqQ3yCfoKcSCsp5 an200xtRg1BWK7xUvSuyeqOc9mDVrrc2qE4Z8FuMLx82txMmV0LDIDSWuJhpndZBVHLp tBPJqE/0Ac9HtOqZ46kmECRUzx1/k8rIeYeZchQGPNz9PygRnNbbZJ/1ublkx9WWIDQs 1wQxewr/KZZxFPk4NYSgRkcTp8hoKdBd0SPtqnNFMhgOaTPbPwIXzTDdYd1S3HHcTCR4 D3iw== X-Forwarded-Encrypted: i=1; AJvYcCUf9LiQR77r7RV7WyBFLmxkzyXpCkk/g5oz/F3t59xT5wizyobM5TTBWWrLQKgLDjgYZcC83TfJLvTURg==@sourceware.org X-Gm-Message-State: AOJu0Yxcmy4ThnlQs1uyQKLyQODC/qiIly3sOsYHRFK1XiSPnCyT+zvE ifJvIIYaHHtrhF3SaMa749MUXggs4tGeaxTgeWZPoULXkkghDW4relW0l25K93yyCOqvl1umYpp OppDSFbTmC1msE/ogdpknpy2BtgZ0VUDxr9vW11ckXeHwzIJNJKJfxYKL9Tk= X-Gm-Gg: ASbGncva1O7ux/FqfGVakyoajy5264O7tmAjA3kAfLIye2QeIG4V5gRBqJsJEz7jYLc 7RPu2VxOBZanZpmasTwCLthS7ykbmttlAOq6LGF7WbEFq4JYlJ5CEilpvowLJIpy/+6p3Oo+TRg oD+dmhrnq0XMJLoIhw1cVbJyhwopcXch19v++BRUnN7nkoqDNB3E5NT0JPJs9Q+Hg8Ul0J/cgjp gkky9imNHHAYovodx7T14JpPWjlkR1mCNJ3iUPU1snoPVp8mIU4RyVEroU2zxsWVYyuTmet/tN/ 6MElJQ== X-Received: by 2002:a17:903:32c1:b0:21b:d126:6d30 with SMTP id d9443c01a7336-21c355c433amr167797185ad.33.1737377306338; Mon, 20 Jan 2025 04:48:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IEWjsEd8owlxeoKToKpG8xOO4dD6rP0tSfbOHmZQxA319aPL2RekiUPIGdtSgyufuNjw3MzUw== X-Received: by 2002:a17:903:32c1:b0:21b:d126:6d30 with SMTP id d9443c01a7336-21c355c433amr167796915ad.33.1737377305984; Mon, 20 Jan 2025 04:48:25 -0800 (PST) Received: from ?IPV6:2804:14d:8084:9a69::1000? ([2804:14d:8084:9a69::1000]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21c2ceb76dfsm60892875ad.61.2025.01.20.04.48.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jan 2025 04:48:25 -0800 (PST) Message-ID: <9110f182-7667-47c5-9a86-52ef550533a5@redhat.com> Date: Mon, 20 Jan 2025 09:48:22 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/testsuite: Fix file location for gdb.base/backtrace-through-cu-nodebug To: Tom de Vries , gdb-patches@sourceware.org References: <7fa350c1-a2b7-4284-a59b-be68c1af9221@suse.de> <20250120122608.115710-2-guinevere@redhat.com> <38f18a49-f283-45cb-9333-ee911ee76e73@suse.de> From: Guinevere Larsen In-Reply-To: <38f18a49-f283-45cb-9333-ee911ee76e73@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: uwy7LosL-x6zqMC6T5wFWKChOuRKyyFKChl_xeJFFWw_1737377306 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 1/20/25 9:46 AM, Tom de Vries wrote: > On 1/20/25 13:26, Guinevere Larsen wrote: >> The newly added test gdb.base/backtrace-through-cu-nodebug.exp had a >> problem in the call to gdb_comiple, that caused the .o files to be > > Hi Gwen, > > gdb_comiple -> gdb_compile > >> outputted in the GDB file tree. This commit fixes the issues in the >> calls. >> >> Reported-By: Tom de Vries > > I've tested this, and checked that it fixes the problem. > > LGTM. > > Approved-By: Tom de Vries Thanks for the quick review, I've pushed the patch! -- Cheers, Guinevere Larsen She/Her/Hers > > Thanks, > - Tom > >> --- >> >> Hi Tom, >> >> Sorry about that, this patch should fix it. I'm not sure if this counts >> as obvious, so I haven't pushed it yet, do let me know if this is ok :) >> >> --- >>   .../gdb.base/backtrace-through-cu-nodebug.exp      | 14 +++++++------- >>   1 file changed, 7 insertions(+), 7 deletions(-) >> >> diff --git a/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp >> b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp >> index d6e686539c9..53bf642a92c 100644 >> --- a/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp >> +++ b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp >> @@ -17,8 +17,8 @@ >>   # trace goes through a function with no debug information. >>     standard_testfile -caller.c -main.c >> -set objmainfile ${testfile}-main.o >> -set objcallerfile ${testfile}-caller.o >> +set objmainfile [standard_output_file ${testfile}-main.o] >> +set objcallerfile [standard_output_file ${testfile}-caller.o] >>     # Recompile the inferior with or without CFI information, then >> run the >>   # inferior until the point where the important test starts. >> @@ -28,7 +28,7 @@ proc prepare_test {has_cfi} { >>       if {$has_cfi} { >>       set extension "cfi" >>       if {[gdb_compile "${srcdir}/${subdir}/${srcfile}" \ >> -         "${srcdir}/${subdir}/${objcallerfile}" \ >> +         "${objcallerfile}" \ >>            object [list {additional_flags=-fomit-frame-pointer \ >>            -funwind-tables -fasynchronous-unwind-tables}]] != "" } { >>           untested "couldn't compile with cfi" >> @@ -37,7 +37,7 @@ proc prepare_test {has_cfi} { >>       } else { >>       set extension "no-cfi" >>       if {[gdb_compile "${srcdir}/${subdir}/${srcfile}" \ >> -         "${srcdir}/${subdir}/${objcallerfile}" \ >> +         "${objcallerfile}" \ >>            object [list {additional_flags=-fomit-frame-pointer \ >>            -fno-unwind-tables \ >>            -fno-asynchronous-unwind-tables}]] != "" } { >> @@ -45,8 +45,8 @@ proc prepare_test {has_cfi} { >>           return false >>         } >>       } >> -    if {[gdb_compile [list "${srcdir}/${subdir}/${objmainfile}" \ >> -        "${srcdir}/${subdir}/${objcallerfile}"] \ >> +    if {[gdb_compile [list "${objmainfile}" \ >> +        "${objcallerfile}"] \ >>           "${binfile}-${extension}" binfile {}] != ""} { >>       untested "couldn't link object files" >>       return false >> @@ -66,7 +66,7 @@ proc prepare_test {has_cfi} { >>   } >>     if {[gdb_compile "${srcdir}/${subdir}/${srcfile2}" \ >> -    "${srcdir}/${subdir}/${objmainfile}" \ >> +    "${objmainfile}" \ >>       object {debug}] != "" } { >>       untested "couldn't compile main file" >>       return >