From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101647 invoked by alias); 20 Mar 2017 22:24:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 101631 invoked by uid 89); 20 Mar 2017 22:24:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=H*f:sk:4107c32, H*i:sk:4107c32 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 20 Mar 2017 22:24:50 +0000 Received: by simark.ca (Postfix, from userid 33) id B9C8B1E81B; Mon, 20 Mar 2017 18:24:49 -0400 (EDT) To: Pedro Alves Subject: Re: [PATCH v2 2/3] spu: Use ptid from regcache instead of inferior_ptid X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 20 Mar 2017 22:24:00 -0000 From: Simon Marchi Cc: Simon Marchi , gdb-patches@sourceware.org In-Reply-To: <4107c32b-465f-59b8-35b2-3caf0f5085bf@redhat.com> References: <20170320215147.25887-1-simon.marchi@ericsson.com> <4107c32b-465f-59b8-35b2-3caf0f5085bf@redhat.com> Message-ID: <90ed46103ab4cafc50cec723e0906e9d@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.4 X-IsSubscribed: yes X-SW-Source: 2017-03/txt/msg00355.txt.bz2 On 2017-03-20 18:06, Pedro Alves wrote: > On 03/20/2017 09:51 PM, Simon Marchi wrote: >> From: Simon Marchi >> >> New in v2: use scoped_restore to save/restore inferior_ptid. >> >> The implementations of to_fetch_regiters/to_store_registers in the spu > > Typo: "regiters". Oops, fixed. >> code use some functions that rely on inferior_ptid. It's simpler for >> now to set/restore inferior_ptid. >> >> * spu-linux-nat.c (spu_fetch_inferior_registers, >> spu_store_inferior_registers): Use ptid from regcache, set and >> restore inferior_ptid. >> * spu-multiarch.c (spu_fetch_registers, spu_store_registers): >> Likewise. > > LGTM. Thanks, pushed. Simon