From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +otRN8w/RmJdJgAAWB0awg (envelope-from ) for ; Thu, 31 Mar 2022 19:57:00 -0400 Received: by simark.ca (Postfix, from userid 112) id CC0451F163; Thu, 31 Mar 2022 19:57:00 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 25F011E150 for ; Thu, 31 Mar 2022 19:57:00 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 265A03857C71 for ; Thu, 31 Mar 2022 23:56:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 265A03857C71 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1648771019; bh=GUVHqsCte9I0emYytY5Qvimjffv7/S7nAYTFAeEkcVg=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=OV2wZHWfDm0MNDn+i3jRYS79AgSfMfEnJjQE8doDo3NC7szDPl74AOeM+yV1YHSVN ENVOOXZx1yFglrbM9mtf8dv/Pn7rQnR7L4SRi40HWxwygucDP928/2LczzFQ+SgV0V 4C+G7PR8XHTHfT+UQ4aGA6maUpJhHhL01eGZX5cw= Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 2C0293858C52 for ; Thu, 31 Mar 2022 23:56:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2C0293858C52 Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 22VLwxL3007018; Thu, 31 Mar 2022 23:56:29 GMT Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com with ESMTP id 3f1tes5nm8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 31 Mar 2022 23:56:28 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 22VNlKiR021979; Thu, 31 Mar 2022 23:56:27 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2046.outbound.protection.outlook.com [104.47.66.46]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id 3f1s95gegj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 31 Mar 2022 23:56:27 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=exV/ZYafPe8+vvkYmNb7x47rojkIj6zuXYRebtIRmz/TdqjYZwSlG87yZHNWBK0ZJS441JjjcPv0PrPLBz5O51Lgpfh+k8pROluIhWQ7KobZ27L1zyLDVUDdSPGYitDw31lGlhhMzODlJuZgjJ9qUlf4JMKERUACc+aDB3PdrpyyRWABJP3XrfL/O6U37/97fBtf/n0xqQWeAMON+ccuyOpyy6Ak2O1r4pbKIHgyZcmdjEXWbUUFV6rXNHgR+MjyrfNMTeZHirX8YRdiDCIF6rGW1ptEZlkJaABJBmOT6jNUSBa1Yn0sfeWlqrtwN+5uoRUDFmf+DK9T5q3VARfElg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GUVHqsCte9I0emYytY5Qvimjffv7/S7nAYTFAeEkcVg=; b=ab67jOGPUeeB2IXcTcpmqCtnrmwr0MvkRblxQRkAodgbs3d3MEIWSd4lgUdAN17Ln6EPiZIT9f04ybeVaXcz1M2RmaGxccxUfC/gW/U+kR0X11ooDeOLnfTwauuaRdSOhRug2MiyZXRMeBMIApAvuc9l7ot2KBoH7uNlg7YY3JG6Tf2Oa4Qa0RMQvfHVNCKYWNLHGm1uCjGmlPGUk4mDDkSCn6Sjtd5L1/QFm7Jxgrup549lEaf21YjRitqqBaL06FhZOeH4ooeQuJ6XUpRDm0o0Fw4LOHmRBy0E6G5JNXkp+vQ+P0wer9o07R7LlTEFLyLDTpe3G/2ClbYFQ/IeNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from SJ0PR10MB4655.namprd10.prod.outlook.com (2603:10b6:a03:2df::23) by MN2PR10MB4381.namprd10.prod.outlook.com (2603:10b6:208:1d3::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.21; Thu, 31 Mar 2022 23:56:25 +0000 Received: from SJ0PR10MB4655.namprd10.prod.outlook.com ([fe80::8537:4552:d54f:e597]) by SJ0PR10MB4655.namprd10.prod.outlook.com ([fe80::8537:4552:d54f:e597%5]) with mapi id 15.20.5123.023; Thu, 31 Mar 2022 23:56:25 +0000 Message-ID: <90ec7aeb-6e9d-bd6c-236e-d74c2c6bf2a6@oracle.com> Date: Thu, 31 Mar 2022 16:56:23 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 1/3] gdb/ctf: don't create a buildsym_compunit when building partial symbols Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20220331212019.2811099-1-simon.marchi@polymtl.ca> In-Reply-To: <20220331212019.2811099-1-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DM6PR06CA0098.namprd06.prod.outlook.com (2603:10b6:5:336::31) To SJ0PR10MB4655.namprd10.prod.outlook.com (2603:10b6:a03:2df::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 83e8f41f-b32c-4711-9948-08da137210e2 X-MS-TrafficTypeDiagnostic: MN2PR10MB4381:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qFgG9T70k1ZfYJBZGL1pqxD7qnQxEXxk0+gzE4f+UubupwYKs6GIaixN6wANVhEHGvUr5BAQLwDd1xkSx8Q32HbjZ+Tr3lBGc3M89OXjT4e3u0FWl++aLAwWEmZ0GrfbRfQW5ne3xTQI32wnKum27TWfyXnmoJNdB3H+sApICHhUT6mHlJ3odOwyJxNviyJnZizunrqiTug0l0Y4JSBS3G5UwZYGB4TCAtvHh5J1OykJ44ecQbJ/v6y8JrmrrVzt82J7RAtatO0CL0Kbr53hWiO/PPSttlpNWeuZW/vXfB0QxGcSLlx+b2rkzsUeqJZ7sx+KzyIMhOCTf8wm0Bg3TOPJDoeTCCf0+t4K6cVnYvpDMvpSFRwKTi2i+D3S3t4qPZjDz7tpO4Tzm2JgYlvdsfcqCDAhKCJPuVTU7nzsiAIfCtKrRhGZ0pzzlzHnW3CQKqllTcJTSokfa9oQswQwh8JrXTgf5XqrWrsaRnLX+qqPvZ8dHI76NuNLv/ltvmks5/YOohQEDZgZ0E275U+WmMn4mYzkiS8O9gSeo1/tnJP4SL4Jkw/Gb6661O+5YaiJK5i6kQZYTEm6qnLu99TCrx/u7ffH2oqZMVpmqemhtH4QUrEM0b+O5tdlfb/yU5ib7vBKqvDDQ4aMs+iF1nq4hB8K+DW6aCAbbFQj49aA0cTtyLnPxIC71q3Ccj/a8F8Bfu/UTvm1twuYoq99OqQ72tAIMCZQV29LeAh7n+MR62s= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB4655.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(2616005)(31696002)(52116002)(316002)(53546011)(186003)(36756003)(6506007)(31686004)(8676002)(86362001)(66476007)(66556008)(2906002)(83380400001)(66946007)(38100700002)(6512007)(6486002)(508600001)(5660300002)(8936002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RDZpRkxoZWRBcWVQcmI0VHZ1cThycVFPcS9NaTd4WUQvZ2ZEZ1VCYWRnb2hH?= =?utf-8?B?VjhiK0lGYUpNeFNhbzQxQnNJOC9oZnppMnV5NlJEQkpnZnNjZVFHWmNoS1hq?= =?utf-8?B?WlcvOHphcGpqa3pLMHhPa2I2N2ZISkp4M0syTTJvTndKODZEbW8yVVQ4eG90?= =?utf-8?B?SW5sV2NTYm9qT3RzOU4wUmJBdC9INVdsaHZTZXZpVTltenNmZExGN3kvOVlv?= =?utf-8?B?bHdaSVFFU2lhWnh6MmVKYlc4TVFQWDRnV09sSUdnN0hhdmJGSXlYdEx0QUFn?= =?utf-8?B?T2ttM3p2UFNIcy8rQVNvSWZCcDk2bXRabUtTWlg2d2dHUUlQUi8wejhSZHcr?= =?utf-8?B?aW9FYms2WmpyZHFRUEgxcXRTV3MzM2g3REtqZksxSXRMU2NNeFp4ME5yQ1BN?= =?utf-8?B?M2dlSjlPSTR0MWpGTUxHOWJiVTh4b2NiOUh3TUdaVzFxQ0NwTE1XSDZ1NGdI?= =?utf-8?B?NnQ2cFFrOHFmeFp5blpWeFgxVk9sdHpIVjh6L3dqd3UwTVpDVEZaNG11Y1J2?= =?utf-8?B?Z0NwM2JCeTNLbmx1ZGtBZ3VLcjNqdDA0WDViMEdnSktNWTZycVFxRENhUi9K?= =?utf-8?B?UmltaEZtQmw4a3dzL3FxRmRFRE5PMm1MQ2FsYTAzWlJHVnNpRXZDcW14c0Nv?= =?utf-8?B?M3RjZk5Xc3JMSnNUVHBmc1RvTjFPMnJjRFNmSmhBc1dIQmNMVnlIYW95UTZB?= =?utf-8?B?akhsK1o1LzBUS2JUODRldlhlL1Q2RG4wYUNEQjcyazlmVDVkbEFWRHhJWjVO?= =?utf-8?B?MUJhZjlQb1JiWVlUMXo1dytzMzVkdDdKN01Tbzk4WUU4RHBNZGoyUHFLb3dk?= =?utf-8?B?Z0hIeGRNb01CWHFmWUV5MkkrWG45emhWNWFmWU9zUERzYXNad1NUcHZuUmxt?= =?utf-8?B?VVhVSnMwSVlOdlRPeGxqbnZvTnlabytVSnVIcTJHVHp6cHdWZjl5ZkNCYk5C?= =?utf-8?B?RUJsMGlLM3dPTUNoUnZDS2JEOTZ2S015bXUvcHpQcC8xMXFEb0hTMWdjOWl4?= =?utf-8?B?M0JsbTJiSzlGUDdJU2tKcEJVNVNpamtVUXVkZzkxM2UzclprNlVhVGRJWnBa?= =?utf-8?B?b20wQm1DSzZReFVPUFQ1ZjNqY2NwZzROc1RldmVEN25BcFVQR21PZ2pDS2NY?= =?utf-8?B?NVVKMkM0eTBBamJUR1NJcUFsZFAzNENsa1I4K2loSmlhN2ozMGRYdnZpK204?= =?utf-8?B?ZERuODRwZ2Z3UGRqOFNRVXRBRUFDSkc2V1V3bEdNQmVyRUt6SVlVSUhpTHRD?= =?utf-8?B?NkwrUllKRklUQzNoM0xCTGo5SDB3T0NRU05abFpLMXNjdGhYOHhmOXpWYnRT?= =?utf-8?B?VGVkek1aQVgrc0liSW9Db1ZlSzZhVWYyUlBHU25ic3pOOFpTMHVPbE5COWhG?= =?utf-8?B?MTE5THYxY0ZhVHUxU2phdEkvcERQdmxDQS91Y0I2L2hjeWxZMWYxV25yMTVW?= =?utf-8?B?NTBzVHVXS21IZlBsT3hMYVdLendlZjNndTFOV2hPTTJQTzFucWh0TTFOQy9R?= =?utf-8?B?Y0VqbUhmaVVxNnBDM3ZZQkU4WU5RR3l1OXpieW9oeXd0MnphczZ1UEVrOU5n?= =?utf-8?B?eGdQWGJ6TkQydFZubmw5NXFRdGM3dENxRmxORjJDMERqcnZ5SkpuWG5lbVFO?= =?utf-8?B?REc4R3Zhem9CeXZkRDUyR0gxSHdkWnNhWHRxZUlCRXpaMDNBOFRkdnRKL3ZN?= =?utf-8?B?WWMwQkYwNUlHQ3JyVzQxWVN2MzkyOEtZMXUwQTlxamxmNHgzNzVKVU9ybm1u?= =?utf-8?B?dDc3cjlGM2dHTCtFbi8rc3JMTFBuWGlWeWxUMDcyV3JDMnpCNExUYUtTZ3Ju?= =?utf-8?B?ejBJMEs2OVJZLzI2YVhxcE5PekVUY0hmSnd3eXBjMnRtNEdOU3B5MnpsRUtI?= =?utf-8?B?bXRTK3VHMVJsSU04MUpScEN6cFhHbGFhUEdDY1JWUUFqalR6UTNrbFhvY2U5?= =?utf-8?B?SFFRVUJNU2hxOTh1VE1KREt4M2M0ZTMrb3EzeHNvZVhndE9CNmxBSWZUaURo?= =?utf-8?B?akQzVldNY1A1TElzMUZONzdMN2JqUFlnbG80VjVuL05jSUZGOWVIUEFVNzVw?= =?utf-8?B?SVJLcGowV3pBdjlBaTJHTjlIMkxYeDVTYVJqalA5TVZaRUZkSDJ1Ri9pYzBw?= =?utf-8?B?N0tEcWR4MHhjdDlkN1cvT1ZndWlhYkRpVE1xYXZLZEF1WXJLRnZoVjA3cDFP?= =?utf-8?B?M3Q1N2VYQW8yRlIzS09CZVFqcGt6ekN2eFlzL0ZPVGRqNzgzeGFmYUE0VnBK?= =?utf-8?B?Q3ZMaUpXZmJuTmJReUl4aFZ6MG5xSDc2eXlvTGhNZ24wL3VJeVZMdDRQZlN2?= =?utf-8?B?c2I1SklWKzk3SFFZUGdGQWJBV2Q3dHdGK2lScjJQQy9DWThmazNVd28ySmdD?= =?utf-8?Q?GqZ64byqExb0rMq8h/230cNavIdauS/3++0/S?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 83e8f41f-b32c-4711-9948-08da137210e2 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4655.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2022 23:56:25.8228 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nWmJ75DG54LUOorOW0jlprAg0GYaq62xlIuGLcA9F+zyYsZsOrrHBOQ7gfhCKMz5nig2+DJs6wmEvrZyVzzQ/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4381 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425, 18.0.850 definitions=2022-03-31_06:2022-03-30, 2022-03-31 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 bulkscore=0 suspectscore=0 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203310119 X-Proofpoint-GUID: 2FLdg5rozK2s43tjC9w_rjYvZidt9UMU X-Proofpoint-ORIG-GUID: 2FLdg5rozK2s43tjC9w_rjYvZidt9UMU X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Wei-min Pan via Gdb-patches Reply-To: Wei-min Pan Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 3/31/2022 2:20 PM, Simon Marchi wrote: > I am trying to do some changes to buildsym_compunit, so I am auditing > the current uses. Something seems odd with this use of > buildsym_compunit (that this patch removes). > > A buildsym_compunit is normally used when building a compunit_symtab. > That is, when expanding a partial symtab into a full compunit symtab. > In ctfread.c, a buildsym_compunit is created in ctf_start_archive, which > is only used when creating partial symtabs. At this moment, I don't > see how that's useful. ctf_start_archive creates a new > buildsym_compunit and starts a subfile. But that buildsym_compunit is > never used again. It's just overriden in ctf_start_symtab, which means > we leak the old buildsym_compunit, I suppose. > > Remove ctf_start_archive completely. Add an assert in > ctf_start_symtab to verify that we are not overwriting an existing > buildsym_compunit (meaning we'd leak the existing one). This assert > triggers without the other part of the fix. When doing: > > $ ./gdb --data-directory=data-directory /tmp/babeltrace-ctf/src/lib/.libs/libbabeltrace2.so.0.0.0 > ... > (gdb) maintenance expand-symtabs > /home/simark/src/binutils-gdb/gdb/ctfread.c:1255: internal-error: ctf_start_symtab: Assertion `!ccp->builder' failed. > > Change-Id: I666d146454a019f08e7305f3a1c4a974d27b4592 > --- > gdb/ctfread.c | 20 +------------------- > 1 file changed, 1 insertion(+), 19 deletions(-) > > diff --git a/gdb/ctfread.c b/gdb/ctfread.c > index 8da38cc70af8..8636692e2e1b 100644 > --- a/gdb/ctfread.c > +++ b/gdb/ctfread.c > @@ -1531,21 +1531,6 @@ ctf_psymtab_var_cb (const char *name, ctf_id_t id, void *arg) > return 0; > } > > -/* Start a subfile for CTF. FNAME is the name of the archive. */ > - > -static void > -ctf_start_archive (struct ctf_context *ccx, struct objfile *of, > - const char *fname) > -{ > - if (ccx->builder == nullptr) > - { > - ccx->builder = new buildsym_compunit (of, > - of->original_name, nullptr, language_c, 0); > - ccx->builder->record_debugformat ("ctf"); > - } > - ccx->builder->start_subfile (fname); > -} > - > /* Setup partial_symtab's describing each source file for which > debugging information is available. */ > > @@ -1567,10 +1552,7 @@ scan_partial_symbols (ctf_dict_t *cfp, psymtab_storage *partial_symtabs, > > struct ctf_context *ccx = &pst->context; > if (isparent == false) > - { > - ctf_start_archive (ccx, of, fname); > - ccx->pst = pst; > - } > + ccx->pst = pst; > > if (ctf_type_iter (cfp, ctf_psymtab_type_cb, ccx) == CTF_ERR) > complaint (_("ctf_type_iter scan_partial_symbols failed - %s"), A CTF archive contains conflicting type info and is treated as a CU. Since one can't switch scope among CUs in CTF, not reading archives might not be a problem. Please go ahead and make the change. It can be revisited when we come up a test case that shows otherwise. Thanks. > > base-commit: 59f837cb11e3b96c581fe23b79f6995b7c8177ee