From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id HkW3L1nGX2hegyMAWB0awg (envelope-from ) for ; Sat, 28 Jun 2025 06:39:21 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=AqK+LMhY; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=AqK+LMhY; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B3E2C1E11E; Sat, 28 Jun 2025 06:39:21 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2B57D1E089 for ; Sat, 28 Jun 2025 06:39:21 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C0192385C6C2 for ; Sat, 28 Jun 2025 10:39:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C0192385C6C2 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=AqK+LMhY; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=AqK+LMhY Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazlp170130007.outbound.protection.outlook.com [IPv6:2a01:111:f403:c20f::7]) by sourceware.org (Postfix) with ESMTPS id 9E89B385781B for ; Sat, 28 Jun 2025 10:38:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9E89B385781B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9E89B385781B Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c20f::7 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1751107129; cv=pass; b=l+mfRasrWK6T08Pg0Snew2ji8ewEyCMieEWW4A5JF78r9ZVRxRZhn3wVslqwvRhhJy/MCMHQ2dmsc4DtsxOqtax8GwIQZImV45ZX19hVq0NEa6vxzLbZs6GceoOz0D4NuhJohGi6zDKuxEfgZkQtMI3HHJ0ax0KodTdNdW+M6Xw= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1751107129; c=relaxed/simple; bh=NMb+1y5jJhrfUg5t/9QtVckYrsArrnzxJ4VtbxSyKSI=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=wmk0GlNyEc8yntk+TjDWw26EZKYNWI9g7B3aNywst5aWPyYTMoSuWH8F+UyXnGH6a3xRGzFA9OtE9sKYGoyVafME8MDEXUj/m/OQkGmexeyiKKkD8kItELd9iYY9OLRKzalZzp7jAF9MJeKyolNE2Sx93EKMS6IzkzLeeka+T0k= ARC-Authentication-Results: i=3; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9E89B385781B ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=Ht41oz7UnluhbqBjiglmS1JHjgi8ldRmE/UprXOEVQsynTLQwn20XUR4RKZv6ePMviVtsJ6SFLtb9eV2q5TlBqVwACNUx9FArmpKPTmFIm8MkseW/Ohi9LLl57zBClb70s8LUsd0qCjVl9x8Y4CSJS3nyGuRbkUhjalkh3HziDBxvsoxaZRXn1+RvTe1LP86H030xmcfhcV5WA4JVBsg1Bc6PZrzwfv7SsLWOnAFAxbcu+pE36QnW0yOVVG79MgMDOgSHU+GiIaiYGDHfEDdrxGSsP88u35qpxVSCUoeYor3SUQMry0yWj+Ce0Kbq8ec59ws99bYCQ+7P7ks7Zm7Hg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5dQJtgNYEvFtTAMyGHxhr1R+20pMBDWgzQ6bE9TFMig=; b=XYN0xwXb8aHc1H7LwFXjlVKlyyw12KusWNIbAtMPPmn68JN4VyDCN9itTJtO5DIzoL6M8PE3vzsXkG660RK9U9RxKgZs00zCwd5Aa8JH9uTh5HrFAAeFJZIyDPfIWTFqBZFj00PMrpFXEUmtNBIH1AYaLK7OKV4qzT51SC8GpeZnxTcj7Aiy/V2mvNTH/ZjGnCtXbWGzsj5yLa3ODpWlzC9YGCRxo+PeKCPxq6w7E8h32Iexa+a/Mnpu0ffo4XFhP7794XA+YV/4wCJyaSUWtejXY+6bbrK2wGQ11YnDEq0rs/hAmkoal3M3NSZpRbs1zHeC07waKTCMfTJZfI1C2g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=intel.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5dQJtgNYEvFtTAMyGHxhr1R+20pMBDWgzQ6bE9TFMig=; b=AqK+LMhYUc6IylJUQfhqI0ATpqkYl/tPECqBKEI3E6Ue5AjqFOmlHS5ZnJIo7dB9DZ+Tefz61fDtOBaTHrXI1JTD4ETwEojrSf0kXJd/WDRj1F+18quLi/y9lDDPkidENnGQMme2ij322QuwookFaa/3mqu66DdBrrQGVQzFDxI= Received: from DU7P195CA0005.EURP195.PROD.OUTLOOK.COM (2603:10a6:10:54d::24) by AM9PR08MB6225.eurprd08.prod.outlook.com (2603:10a6:20b:2de::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.17; Sat, 28 Jun 2025 10:38:44 +0000 Received: from DU2PEPF00028D08.eurprd03.prod.outlook.com (2603:10a6:10:54d:cafe::36) by DU7P195CA0005.outlook.office365.com (2603:10a6:10:54d::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.20 via Frontend Transport; Sat, 28 Jun 2025 10:38:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by DU2PEPF00028D08.mail.protection.outlook.com (10.167.242.168) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.14 via Frontend Transport; Sat, 28 Jun 2025 10:38:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vkuL2SlC8te5hpH7+z2Q6RwK5bENP0HtNxCE5PGdkVRY7UwKmEeXgyMx8GA64u2CawS5AgOAYE51Jr8/xd3O9qTNJnDmHzGVV7oKgfNtgSUcgeEEZB+HCCGkyX5vsNgk1udhCv9U7lIdOPNVyQ/XLeoRH6kx/ZUIi1EdoIZF0RVMfi/QQbXGJHxEiJBmHzIKlthYMG4fkuVybWLaBOy5PJYde1Tgc/F44UOfly8k0QKnSGylUikQs05C3kWT9f0Ha3wt0bE/nN1PLYNquDIJWuosIU4nLMeyvpyU+pvWlG8RBGQKgit3DeRDNhOdH2C/ur1E/Ju3CTrhpMzBfBvr1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5dQJtgNYEvFtTAMyGHxhr1R+20pMBDWgzQ6bE9TFMig=; b=fsjZcTjqaZl5YCyeUKDEQ251mERuc6V0LiAPOvkPdckPYLIfMJ6sF3SBPBTIvfVVYLnoz9ovu0tRZtRabWEzrcjNq5Pfb86OY6bGdsQZYpi0mCiyoaHeudu9ZBr7CZm5nfFJuBS/qGlTsZSahKNnPNJ4W885t6FJaKbyFv221Io3Vpt1XZbmo5nkQfu6E0C026moTHk9MqYoWE8VcR0VkUoZa9YT9em9s4RPVrlviB4IC9E4+LQPFHfJrzI5GqBRFpMSJajids9Adjii2gVX4pxR2LazK38b8hd8QUnK6+cP+0b5YWhZp7D/XF3z8zI+hcTSdso/gUNc7K/IGSdV2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5dQJtgNYEvFtTAMyGHxhr1R+20pMBDWgzQ6bE9TFMig=; b=AqK+LMhYUc6IylJUQfhqI0ATpqkYl/tPECqBKEI3E6Ue5AjqFOmlHS5ZnJIo7dB9DZ+Tefz61fDtOBaTHrXI1JTD4ETwEojrSf0kXJd/WDRj1F+18quLi/y9lDDPkidENnGQMme2ij322QuwookFaa/3mqu66DdBrrQGVQzFDxI= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from PR3PR08MB5852.eurprd08.prod.outlook.com (2603:10a6:102:8e::21) by AS2PR08MB10228.eurprd08.prod.outlook.com (2603:10a6:20b:648::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.28; Sat, 28 Jun 2025 10:38:10 +0000 Received: from PR3PR08MB5852.eurprd08.prod.outlook.com ([fe80::f44:d113:1c29:825d]) by PR3PR08MB5852.eurprd08.prod.outlook.com ([fe80::f44:d113:1c29:825d%7]) with mapi id 15.20.8880.021; Sat, 28 Jun 2025 10:38:10 +0000 Message-ID: <90c58552-df58-4cf5-acad-d35b9eafab79@arm.com> Date: Sat, 28 Jun 2025 11:38:07 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 09/11] gdb: Implement amd64 linux shadow stack support for inferior calls. Content-Language: en-US To: "Schimpe, Christina" , "gdb-patches@sourceware.org" Cc: "thiago.bauermann@linaro.org" , "eliz@gnu.org" References: <20250617121147.1956686-1-christina.schimpe@intel.com> <20250617121147.1956686-10-christina.schimpe@intel.com> <8c72488c-44e1-4d0b-91ea-de362fcbd248@arm.com> From: Luis Machado In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0372.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18e::17) To PR3PR08MB5852.eurprd08.prod.outlook.com (2603:10a6:102:8e::21) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: PR3PR08MB5852:EE_|AS2PR08MB10228:EE_|DU2PEPF00028D08:EE_|AM9PR08MB6225:EE_ X-MS-Office365-Filtering-Correlation-Id: a720ab90-ab39-4892-09b0-08ddb62ff3e4 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info-Original: =?utf-8?B?SGF6UWprQ3EzNTZUYzV3aVVLUHJFclZOUEZKRGVxeUYzcmJkdzVOZE5rSnE1?= =?utf-8?B?OVVRR1dkZ3luT3B6RUtFRk1VeGlSRm9VdHhTTmxvM3crd0kxT2dGWTdTUmd4?= =?utf-8?B?TnJDRE1JS3FBQ21DZVB5YkdsaGRGVmY1Skxpc3dXajZhWEQveXlydHpiVGs5?= =?utf-8?B?ZGhobXBsRlV5TWdNMkVoOGMrZnp1bHREcG9sSzNWYTFxVEY1cXdjd0FNcFBU?= =?utf-8?B?THVEVFRtNUNUVThTY090a3Y4ZmxVYTBrMjJDejU0cGpQc1ZSUVFFN2JMNy8w?= =?utf-8?B?aVdETE1jZHBPM3F3c2lUVG1PME16TFFORVB3WmtVWnFpNW1lS1hPWlM4TzA1?= =?utf-8?B?a1JpcWl2dHdmVXdOc01QQkt4RDRBYU1yU2pqKzN6UlJKckp2Smwra2VuWHFG?= =?utf-8?B?eDNpNkJGTXF3NmVFclNxQ0QrZmtYcDJadTdNZ2daZVZBc2FjZTI2eDhHNGho?= =?utf-8?B?WWphRTdJYkp2eGVmZ3Z5UFVxaHRPWEhEOUViK0dPU2paM3JaRVhmRmYwQjQv?= =?utf-8?B?cU50UjNEOE5zdFcxTjhtR2ljK0pMYXluajR1SmQ5bGozdlVoUzBwZ0tEZGxk?= =?utf-8?B?aXJYYkpZN3g3RGpiT3cvMXpnTGxtanYvTS9YLy95dTZram8yWGhRYUNuK3Z2?= =?utf-8?B?MWJCQ0NmOXVTemQxaEtlMkFrUFZTbkNFTjNWVkd0eEw4TTQ4VWtwZVdJV1Nu?= =?utf-8?B?OUxBR2toOEp1cElETCtpLzNXS2lwVEg0L1Q4bzJmR0QrdWNoK1IxM0ZGcE1p?= =?utf-8?B?a2tpM3BPOEJoeTB3Y3MxYkRwdUwrQzV5NEV1ZVRmNUNYbHlmbzNMTy9TSVN4?= =?utf-8?B?V2t0ZjFXWkZhVHNxMXNFbU9SaDV2RWkwZjRudVl4M0VhTjNrWGIyWlVPVWV2?= =?utf-8?B?eElPdEtuZTBQY2ttQnozQk0xSlZXVmp2NWN6Y1FnU05HQlo0ZWtVdEhsR2JJ?= =?utf-8?B?OEtDQlFwQnUrc0pNZkFSdys5cGtkT1g0eS9wUDVCMmdQakFWNmw2UWZvdE51?= =?utf-8?B?aDU0OVZubi9MNVlrYy8wQnE5RVJ4Q3kzeUZiT3V5K0xaaVFoRWg4MWhpVUhp?= =?utf-8?B?WStXckJvOFZQS1F6SzZEVWZIVkxQSFRkd2NaeUNaWGVJYXVvdXp3TUlPbi95?= =?utf-8?B?UE1FVjRXZnA5SkI0czQ0K2xLMmdWSGtZbXYwam1RWXlpRWFjajM1LzE1emha?= =?utf-8?B?NllmL1VKL0NlME41S2xFRGQvYjNCYUVIMlJiTXdhS2hTQnh1eFRHYmVVNFBH?= =?utf-8?B?alFwQWtFc0JCWnNrZHMvRnB1dHEwdUdCRDNKK1pVdlV1Q3ZJdTRMSndHcWJ2?= =?utf-8?B?ZjJtNFpPUGdOU253eWozS0JndjZSY2lzVWNLRXpWRHRsRGVMYnZzazcwQTVD?= =?utf-8?B?Q1QrNE1IdTRDSlQ2VkFKeG5TMDFYVjJvOENUNkdBMUk1REVSZHlnMzRLcnBL?= =?utf-8?B?aWFRb3FUK2hyWVhYWXhlbVJpakZMOHpMbGtNRndqR0hhTGU0RG9RSHpqOVpu?= =?utf-8?B?MlpFT2VOZkdsbDI1Y1RYL2FhWmxDK1NSWWVvbmxsaXZVOENjV2FzeSt4SUw2?= =?utf-8?B?NTJxWEhJZzJUWUpheklaSlczVGxDTFdIRzVxcm9MUHM2ZHoxTVc0MXI4cWFF?= =?utf-8?B?MjQ1TmxzYmhIVzhFdm9YaHhRQnc0eGFEK1Z6Sjhna251WG9wVkthU3FKNEl1?= =?utf-8?B?VDhuZjBlY2RzVnZJQjZiMDJ1dSt5WTcxeWJJVkNqVllqOTBxL210c0RMNnIy?= =?utf-8?B?bkJXd0hnUysxZEwrc0FUY1I1VFgvMlBaWjBLRVdqeWlRSUp3VGFiWGlUNkxx?= =?utf-8?B?UmZNWENCL2tJODYxaCtjQnR4MkNOTW0ydExRSC8yM2hHMHgxMjZVZzB1N0Q5?= =?utf-8?B?c3M4MEpGWC92djdRTUhUTWNJWTRBVHJna2lCU2MxaWZ6REF1dktxU0Vnc2Rj?= =?utf-8?Q?ZrfoFP4ocAo=3D?= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PR3PR08MB5852.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB10228 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DU2PEPF00028D08.eurprd03.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 22bf8abd-ba0a-42f9-1a91-08ddb62fe0c4 X-Microsoft-Antispam: BCL:0; ARA:13230040|14060799003|376014|82310400026|1800799024|36860700013|35042699022; X-Microsoft-Antispam-Message-Info: =?utf-8?B?QVVDQnJlMkk1T2pkVUI5WGE0Nm1jWDh1RURBTU9ZSFVRRFJDVDNXWjJ1enRt?= =?utf-8?B?SjNPcUlSZXFIanZoNDhjRXJpcVZIS0NTRmd0U2lvaHFFTTlDeXJWNUh1Z2Jy?= =?utf-8?B?dXNKbUg5Zy9vUEE3SFQwSnpGdEtFYWw0YXBiS1lWNVdobCtHTE1PSzZaL3VI?= =?utf-8?B?M2FuM2RVcjVwR3RDMFVuWlNwU0JqdlBIOWR2OXZUN1FLcnNyZEpCRHhBTnI0?= =?utf-8?B?TDVENkJXV3g3MHFCVmZoM2kzSU5nR3lIek5Hcy9mdE9HUFRBU25aVWdUemdn?= =?utf-8?B?cDNkR3RuditRRThJdDNocnpoTm4vRnl6MzMzMzdSemxwNGVObEF6czZhS2tH?= =?utf-8?B?UU5EUEdoS0lnK1hWNkIyM1RSVktPQWJiaVRXc0pwb0l2ODV2Wlp1QmgrU3dC?= =?utf-8?B?ZDMvYmY3ZUh0MzdrK0p4cjl3K1JneHpEdEFkaUtKZGNJUzJCRDBvM1hQcGty?= =?utf-8?B?VlhadXVaRGF4MmtuM0d3K0EwWE5reGtFNUxudEp3V2xHOFY3UWE1QlgvbDJr?= =?utf-8?B?a09HNDB5RU51OVR2YU1sT2o1czRrVWVwU0FoRWNoNDRHUEg3eHcvYUVqWWZi?= =?utf-8?B?d3g4NXorZi9jNnk1VzVmREtHMThtdVdWM0Vaa3AvSjY0M09Pd2VIaTJRMUlY?= =?utf-8?B?eGxMNjJYZVV2Y0ZJTXpDRHJWL1FQMTJLUW93QndPdnlRMmxxdU1QWFM1RTdE?= =?utf-8?B?NkxKMVNUMUZNWUlNbG94ekxuL252Skc3MjZXN0g4RTV2aWhHMVlFN0RnYlNR?= =?utf-8?B?UTNDUkQxRENzYitIWXV1aStycTRpQW5HeXpkelZjNk9LUDlqSmhHL0dUaGdJ?= =?utf-8?B?WjJHWHcyWW9xK2JreUFnMVVJYmN5MHhKTnl4Y0VpRE82RUkwclVqNnIzU0w0?= =?utf-8?B?Nkc2SUNXSDFRc1pKSy9JOGdwdzZZeExtRS9wcDh1b0M2YTd0eXY3OUYzd2Vt?= =?utf-8?B?SFZiYWQyVDlyOFlnTXBHdGI1V2p0TGMvRjNMdkhLWVRNVnlZZW95TlMyR3BX?= =?utf-8?B?TXFDWjhISmY5bGVyMm1wWUFYRWNwL3ZLREs4N1RxWUFhRnJnKy9nWXIweFZO?= =?utf-8?B?aFFCaWx2TXdWb1JoVTY1cm5GRStqRVlkZWZ0bGluZGg1emszY1hQaks5RTkw?= =?utf-8?B?WU9vd2lYa3dFOHJXcmNpWHpMeUo4c1JvZlJvQmwzVVc2eTZMRUZlU0tvaEF0?= =?utf-8?B?STE0RGZrYi94UDNWN2xSS0ZDd2pTSGtuV245WjMxTlRsU3gwMWovbnJCbHoz?= =?utf-8?B?Y0hOa3o1WkxjSXdoK2VQdU0zSmJYVnk1U3duYWkyTHZoN2xBcTg4R1lwY0xR?= =?utf-8?B?azQzakU5ZHdiTXZuU20wVDc5MVhqTzl0a3ZGNzI1WURPRXBzUVR3SS9ncjQ4?= =?utf-8?B?Q1huMGwrbThoSGJJK2wzYjdBb2RIY1ZuYkpPOTRHZWFaS1Q1bHFOQWU0K0pv?= =?utf-8?B?cDk1T1pmZm5XemROUFF1dXk5Q2U4NFVJTVJRMVpBL3RRZlVCZ1lZZkhVK0N2?= =?utf-8?B?bVRRKzVtaHR3RDFCRVJlbllTazdkdkg2WXVQRFYvdWVnbUZ6b0xKVDJab2dp?= =?utf-8?B?REN0bmZTQnQvVXFwQ0JTbmFBZHV6TFpiYjJoM2xrOThBeEh5cjNuSTdUTDFk?= =?utf-8?B?SlNTME0vMEgydzA0M0c1V2xLaUlaZmx4TW4yU3VtWCsvMHdJbElHdU1ZTi8v?= =?utf-8?B?WWlFZ0svUXNjK1QyQi9nNVhVMzhhUWFVTzIrRy9IVTk1OUQzWVJhbjlGOTRP?= =?utf-8?B?ZjM5QXJHMTBUSUZrRlFyL2pMUldvNWZkdFFIOGdtckFGc2xrSW9ab05XTVhQ?= =?utf-8?B?OGdIRHpweHV0TXhIeXR6UzBNeUtoSWdWanJMQWpVbVZKVEFBdEdvQVlOeGF6?= =?utf-8?B?MDZQNEY0K1hDa3dzaEhwL1pNRndrdG8xci9CREhsWFF5YUVCbi9OR3BvV0ts?= =?utf-8?B?cXpIN3hkOWVhVUFpKzllbTFjUFpBcVNvK2hrYjVmVkhkLzlUYkJhYUN2eUVF?= =?utf-8?B?SWt1Z0xWNyt3ZFJWaEpKVUw2dzdkNm5MckU0SzcxSjNwZnJLV2JQSGlnU1Qw?= =?utf-8?Q?GUWGF4?= X-Forefront-Antispam-Report: CIP:4.158.2.129; CTRY:GB; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:outbound-uk1.az.dlp.m.darktrace.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(14060799003)(376014)(82310400026)(1800799024)(36860700013)(35042699022); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2025 10:38:42.6953 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a720ab90-ab39-4892-09b0-08ddb62ff3e4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[4.158.2.129]; Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: DU2PEPF00028D08.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6225 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 6/27/25 20:52, Schimpe, Christina wrote: > Hi Luis, > > Thanks for the review. > > <...> > >>> + >>> + /* Starting with v6.6., the Linux kernel supports CET shadow stack. >> >> Typo, period after "v6.6". >> >>> + Dependent on the target the ssp register can be invalid or nullptr >>> + when shadow stack is supported by HW and the linux kernel but not >>> + enabled for the current thread. */ >> >> I feel the comment doesn't quite reflect this case very well. We don't have a >> nullptr here, so I suppose ssp == 0x0 means ssp is unavailable? We should >> make that clear here, but we don't need to have this more generic comment >> pasted here again, as it was explained elsewhere already. > > I agree. I removed the "Starting with v6.6., the Linux kernel supports..." comment > and rewrote the sentence afterwards as follows: > > "Dependent on the target in case the shadow stack pointer is unavailable, the ssp > register can be invalid or 0x0." > > I hope this is a bit better. > That sounds better to me. Thanks. >>> + if (ssp == 0x0) >>> + return {}; >>> + >>> + return ssp; >>> +} >>> + >>> +/* If shadow stack is enabled, push the address NEW_ADDR on the >>> +shadow >> >> s/the address NEW_ADDR on/NEW_ADDR to >> >>> + stack and increment the shadow stack pointer accordingly. */ >>> + >>> +static void >>> +amd64_linux_shadow_stack_push (gdbarch *gdbarch, CORE_ADDR >> new_addr, >>> + regcache *regcache) >>> +{ >>> + std::optional ssp >>> + = amd64_linux_get_shadow_stack_pointer (gdbarch, regcache); >>> + if (!ssp.has_value ()) >>> + return; >>> + >>> + /* The shadow stack grows downwards. To push addresses on the >>> + stack, >> >> s/on the/to the >> >>> + we need to decrement SSP. */ >>> + const int element_size >>> + = amd64_linux_shadow_stack_element_size_aligned (gdbarch); const >>> + CORE_ADDR new_ssp = *ssp - element_size; >>> + >>> + /* Starting with v6.6., the Linux kernel supports CET shadow stack. >> >> Same typo, period after "v6.6". I feel this comment has been repeated >> enough times throughout the code. If it is available at a visible location, I >> think we can do without it elsewhere. > > I agree. > >> For instance, we could even mention the >> kernel version in the news entry, or at the gdbarch initialization code when >> we are fetching a target description. Then it should be enough. > > I would suggest to remove the comment > > "Starting with v6.6., the Linux kernel supports CET shadow stack." > > everywhere except in the allow_ssp_tests procedure, as it fits best there in my opinion. > > Would that be acceptable? I think so. If you want to mention it somewhere in the gdb sources, then maybe the gdbarch initialization function would be another acceptable spot. > > <...> > >> Otherwise this is OK. >> >> Reviewed-By: Luis Machado > > I actually missed to reply to this feedback in the first place. Sorry for the late reply. > I'll post my v5 soon, as I'll be out for one week. If anything suggested above is not acceptable, > it would be great if you could let me know. > Since this is affecting comments only, I think it should be straight-forward to fix. > For now I'll post my v5 as suggested above. No worries. I see v5 on the list and will go through it. Have a nice break.