From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17885 invoked by alias); 10 Jan 2009 13:31:05 -0000 Received: (qmail 17875 invoked by uid 22791); 10 Jan 2009 13:31:05 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-bw0-f13.google.com (HELO mail-bw0-f13.google.com) (209.85.218.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 10 Jan 2009 13:30:33 +0000 Received: by bwz6 with SMTP id 6so26487364bwz.0 for ; Sat, 10 Jan 2009 05:30:30 -0800 (PST) Received: by 10.180.242.5 with SMTP id p5mr2016123bkh.178.1231594229775; Sat, 10 Jan 2009 05:30:29 -0800 (PST) Received: by 10.181.219.4 with HTTP; Sat, 10 Jan 2009 05:30:29 -0800 (PST) Message-ID: <90baa01f0901100530t6590599bucfaa12aea8898c57@mail.gmail.com> Date: Sat, 10 Jan 2009 13:31:00 -0000 From: "Kai Tietz" To: "Joel Brobecker" Subject: Re: [RFC] convert a host address to a string Cc: "Kai Tietz" , gdb-patches@sourceware.org, "Mark Kettenis" In-Reply-To: <20090110071137.GN24105@adacore.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_161463_3391649.1231594229774" References: <20090109131227.GL24105@adacore.com> <20090110071137.GN24105@adacore.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00225.txt.bz2 ------=_Part_161463_3391649.1231594229774 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-length: 1345 2009/1/10 Joel Brobecker : >> I think it is a sub-optimal solution to have just support for Vista64, but >> not for XP. > > To me, the question is not about whether to support XP64 or not. > I agree it would be nice to support XP64 as well. It's about who > has the time and energy to drive the discussion to find an accepted > solution. I decided to drop XP64, because it's not in the list of > things I'm interested in while I'm sensing that it's going to take > a bit of effort to reach a consensus. You already made a very nice > contribution in the coff/pe reader, why not send another patch to > further improve host_address_to_string for XP64? > >> On a second thought, I remembered, that bfd does things right ;) There >> is the macro sprintf_vma in bfd.h, which handles things pretty well >> and can be used here in utils.c, too. > > The problem with that routine is that it is designed to print target > addresses, not host addresses. > > -- > Joel > ok, so I sugget the following patch instead. It is able to generate addresses for XP64 without the use of any vendor specific printf formatters, and uses for targets where sizeof(long) == sizeof(void*) the long variant. Cheers, Kai -- | (\_/) This is Bunny. Copy and paste | (='.'=) Bunny into your signature to help | (")_(") him gain world domination ------=_Part_161463_3391649.1231594229774 Content-Type: text/x-c; name=host_addr_to_string.diff Content-Transfer-Encoding: base64 X-Attachment-Id: f_fpsbcke80 Content-Disposition: attachment; filename=host_addr_to_string.diff Content-length: 3819 SW5kZXg6IHNyYy9nZGIvdXRpbHMuYwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBzcmMub3JpZy9nZGIvdXRpbHMuYworKysgc3JjL2dkYi91dGlscy5j CkBAIC0zMDcxLDExICszMDcxLDU0IEBAIGhvc3RfYWRkcmVzc190b19zdHJp bmcgKGNvbnN0IHZvaWQgKmFkZHIKIHsKICAgY2hhciAqc3RyID0gZ2V0X2Nl bGwgKCk7CiAKLSAgLyogV2UgY291bGQgdXNlIHRoZSAlcCBjb252ZXJzaW9u IHNwZWNpZmllciB0byBzcHJpbnRmIGlmIHdlIGhhZCBhbnkKLSAgICAgd2F5 IG9mIGtub3dpbmcgd2hldGhlciB0aGlzIGhvc3Qgc3VwcG9ydHMgaXQuICBC dXQgdGhlIGZvbGxvd2luZwotICAgICBzaG91bGQgd29yayBvbiB0aGUgQWxw aGEgYW5kIG9uIDMyIGJpdCBtYWNoaW5lcy4gICovCi0gIHNwcmludGYgKHN0 ciwgIjB4JWx4IiwgKHVuc2lnbmVkIGxvbmcpIGFkZHIpOworICAvKiBXZSBk byBub3QgdXNlIHRoZSAlcCBjb252ZXJzaW9uIHNwZWNpZmllciwgYmVjYXVz ZSB0aGUgcmVzdWx0aW5nDQorICAgICBpbWFnZSBjYW4gdmFyeSBmcm9tIGlt cGxlbWVudGF0aW9uIHRvIGltcGxlbWVudGF0aW9uLiAgRm9yIGluc3RhbmNl LA0KKyAgICAgc29tZSBpbXBsZW1lbnRhdGlvbnMgZm9ybWF0IHRoZSBwb2lu dGVyIHZhbHVlIHdpdGggYSBsZWFkaW5nICIweCINCisgICAgIHdoZXJlYXMg b3RoZXJzIGRvbid0IChTb2xhcmlzLCBmb3IgaW5zdGFuY2UpLiAgQWxzbywg aXQgaXMgdW5zcGVjaWZpZWQNCisgICAgIHdoZXRoZXIgdGhlIGFscGhhYmV0 aWNhbCBkaWdpdHMgYXJlIHByaW50ZWQgdXNpbmcgdXBwZXJjYXNlIGxldHRl cnMNCisgICAgIG9yIG5vdCAoaW4gR0RCLCB3ZSB3YW50IGxvd2VyY2FzZSku DQorDQorICAgICBTbyB3ZSB1c2UgdGhlICV4IHR5cGUgaW5zdGVhZC4gIFRo aXMsIGhvd2V2ZXIsIGludHJvZHVjZXMNCisgICAgIGEgY291cGxlIG9mIGlz c3VlczoNCisNCisgICAgICAgMS4gVGhlICV4IHR5cGUgZXhwZWN0cyBhbiBp bnRlZ2VyIHZhbHVlLCBub3QgYSBwb2ludGVyLg0KKyAgICAgICAgICBTbyB3 ZSBmaXJzdCBuZWVkIHRvIGNhc3Qgb3VyIHBvaW50ZXIgdG8gYW4gaW50ZWdl ciB0eXBlDQorICAgICAgICAgIHdob3NlIHNpemUgaXMgaWRlbnRpY2FsIHRv IHRoZSBzaXplIG9mIG91ciBwb2ludGVyLg0KKyAgICAgICAgICBXZSB1c2Ug dWludHB0cl90IGZvciB0aGF0Lg0KKw0KKyAgICAgICAyLiBUaGUgJXggdHlw ZSBhbG9uZSBleHBlY3RzIGFuZCBpbnQsIHdoaWNoIGlzIG5vdCBhbHdheXMN CisgICAgICAgICAgbGFyZ2UgZW5vdWdoIHRvIGhvbGQgYW4gYWRkcmVzcy4g IFVzdWFsbHksIHR5cGUgImxvbmciDQorICAgICAgICAgIGhhcyB0aGUgc2Ft ZSBzaXplIGFzIHBvaW50ZXJzLCBidXQgY2VydGFpbiBBQklzIGRlZmluZQ0K KyAgICAgICAgICB0aGUgc2l6ZSBvZiBwb2ludGVycyB0byBiZSBsYXJnZXIg dGhhbiB0aGUgc2l6ZSBvZiBsb25nDQorICAgICAgICAgICg2NGJpdCBXaW5k b3dzIGlzIG9uZSBzdWNoIGV4YW1wbGUpLg0KKw0KKyAgICAgICAgICBTbywg dG8gYmUgY2VydGFpbiB0byBoYXZlIGEgdHlwZSB0aGF0J3MgbGFyZ2UgZW5v dWdoDQorICAgICAgICAgIHRvIGhvbGQgYW4gYWRkcmVzcywgd2UgbmVlZCB0 byB1c2UgImxvbmcgbG9uZyIuICBCdXQNCisgICAgICAgICAgdGhlIHRyaWNr IGlzIHRoYXQgbm90IGFsbCBwcmludGYgaW1wbGVtZW50YXRpb25zIHN1cHBv cnQNCisgICAgICAgICAgdGhlICJsbCIgbW9kaWZpZXIuICBPbiB0aG9zZSBw bGF0Zm9ybXMgd2hlcmUgdGhlICJsbCINCisgICAgICAgICAgbW9kaWZpZXIg aXMgbm90IGF2YWlsYWJsZSwgd2UnbGwgYXNzdW1lIHRoYXQgdHlwZSAibG9u ZyINCisgICAgICAgICAgY2FuIGJlIHVzZWQgdG8gcHJpbnQgYW4gYWRkcmVz cy4NCisNCisgICAgICAgICAgVG8gbWFrZSBzdXJlIHRoYXQgdGhlIHR5cGUg d2UgcGFzcyB0byBzcHJpbnRmIG1hdGNoZXMNCisgICAgICAgICAgdGhlIHR5 cGUgd2Ugc3BlY2lmaWVkIGluIG91ciBleHByZXNzaW9uLCB3ZSBwZXJmb3Jt DQorICAgICAgICAgIGEgc2Vjb25kIGNhc3QgdG8gInVuc2lnbmVkIGxvbmcg bG9uZyIgaWYgd2UgdXNlZCAiJWxseCIsDQorICAgICAgICAgIG9yICJ1bnNp Z25lZCBsb25nIiBpZiB3ZSB1c2VkICIlbHgiLiAgKi8NCisNCisjaWYgZGVm aW5lZChQUklOVEZfSEFTX0xPTkdfTE9ORykgJiYgQklUU0laRU9GX1NJWkVf VCA9PSA2NCAmJiBcDQorICBTSVpFT0ZfTE9ORyA9PSA0DQorICBzcHJpbnRm IChzdHIsICIweCVsbHgiLCAodW5zaWduZWQgbG9uZyBsb25nKSAodWludHB0 cl90KSBhZGRyKTsNCisjZWxpZiBCSVRTSVpFT0ZfU0laRV9UID09IDY0ICYm IFNJWkVPRl9MT05HID09IDQNCisgIHVuc2lnbmVkIGxvbmcgbG9uZyB2YWwg PSAodW5zaWduZWQgbG9uZykgKHVpbnRwdHJfdCkgYWRkcjsNCisgIGlmICgo dmFsICYgfjB4ZmZmZmZmZmZ1bGwpICE9IDApDQorICAgIHNwcmludGYgKHN0 ciwgIjB4JWx4JTA4bHgiLA0KKyAgICAgICAgICAgICAodW5zaWduZWQgbG9u ZykgKHZhbCA+PiAzMiksICh1bnNpZ25lZCBsb25nKSB2YWwpOw0KKyAgZWxz ZQ0KKyAgICBzcHJpbnRmIChzdHIsICIweCVseCIsICh1bnNpZ25lZCBsb25n KSAodWludHB0cl90KSB2YWwpOw0KKyNlbHNlDQorICBzcHJpbnRmIChzdHIs ICIweCVseCIsICh1bnNpZ25lZCBsb25nKSAodWludHB0cl90KSBhZGRyKTsN CisjZW5kaWYNCiAgIHJldHVybiBzdHI7CisgIEJJVFNJWkVPRl9TSVpFX1Qg U0laRU9GX0xPTkcKIH0KIAogY2hhciAqCg== ------=_Part_161463_3391649.1231594229774--