From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id JUpzFyeULmULWTAAWB0awg (envelope-from ) for ; Tue, 17 Oct 2023 10:03:19 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=oupzkJTv; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 519C41E0C1; Tue, 17 Oct 2023 10:03:19 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0D2521E00F for ; Tue, 17 Oct 2023 10:03:17 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A2A4F3857B9B for ; Tue, 17 Oct 2023 14:03:16 +0000 (GMT) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2054.outbound.protection.outlook.com [40.107.237.54]) by sourceware.org (Postfix) with ESMTPS id 462103858D33 for ; Tue, 17 Oct 2023 14:03:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 462103858D33 Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 462103858D33 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.237.54 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697551385; cv=pass; b=LLv/ECKOurvAriGzQPcJpsQbln/XNCBymiQVaCyeDG+1sX14GpOubF9Mhaz3LpzEAvKeNuQBIRa0mXbS7vGEMDjlilARSSX/Lh5WOGgmSoFH0LVNGf7x7tYGbqZ9V3xpsJSJcUB9YigkkQAgsXHnVLGR5t2UOVGQL1d1B2CzUAM= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697551385; c=relaxed/simple; bh=eroforar0CDWujzy9C5JIQtNegAN1lSb/5py/RDjmiU=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=x26jTJHk/vQJCdVWITJEppWHsQ4bFG15FbWC9Oap2oQDCGNiK3BfQzjyg2KD8qu+a3ga6slKFomfNVGIQkhqUgDZrAIvpzeRAEl8cxaYMYtiY/gR67KBH5JZ0+RS2otsU0wIUZClZxAKGzQs6pvHbpZt5nQ86HzYbaXdYXVmwS4= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IxNpn5fdRRRXg9IcY+59jEgcentvkTe/KmECW+vS+reouc13c/x/TRnDeaWDcCns+V5WiRyi2vbUnUmbAz9VFD33T7EfLuOHXj7i59ETd9q7gBeXF9AeEM4eo3dD5OvuGPNU3JYDk0l+zFSGdVsTxObHp8bgxgeg9eOi0Z+RP+4Wj6yyyrejAn9WnEvtoifCy6LOeyf8CSZPh3C0b4dvJNMbnDQC8yQMUJjbU5vX1cA3YOyaeFfuxuiMJZo4pnXQxk/qqNdjRGdUc5YTLweDvi6Xvx5G4M0fF/6DnaEYibu/ZUrJ1drIfdHHRtS7SsXMsJ3FApCfLbREL6QTjTlXRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0RRCZxOOU5upbeoE/+OvbKjdJxY7IVsJlonWbtUByYo=; b=WXiWMHF/E+nKQGNAqdsrj8AE3aRPAxNcygeM9tusog6b6HTceF4BruHtlWoRENNvxukNNAXK9bX5JWWsBGMl0NBp7nPRsWdYw8EL5EFJl7A0nPepU1GUPlADDJkzDeZn2hohk6YpiMEyQVghQnVDPsDQKvIPgZpzxy7PfLG0ljm6/zqeNC7E38cKP4c2RktRfJD771ZBB2t3d7L6Mi2kz0Y7LRoTd3ZkZ3sQA74IGsePgH9uHbveltuBBK4qbeJ3szkjvivSazgaAjrvV+DmRjatIWJLWUTZ/E02ooGd2TxIVzxOgi0vHnsjJWUO6tI9vY2Y2DsX4UG5pUjiBXwvTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0RRCZxOOU5upbeoE/+OvbKjdJxY7IVsJlonWbtUByYo=; b=oupzkJTv+y9288ssK992Cp0MAjRBYp2mQuFW3dCO06+uCoxjc+e57h2ioxzOhiDF+NSCrKB79tbcdqEqH1B4omUQt3tfb/HQEDSAJAziZFEmtn7SlDkH+QP+RnPHBWZZdRltMjWw33/qgqN/2zjukzbD3z7qzEgySfXAhvpnWmA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) by IA1PR12MB8077.namprd12.prod.outlook.com (2603:10b6:208:3f4::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.36; Tue, 17 Oct 2023 14:03:02 +0000 Received: from CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::3120:8014:c770:9f8f]) by CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::3120:8014:c770:9f8f%7]) with mapi id 15.20.6863.047; Tue, 17 Oct 2023 14:03:02 +0000 Message-ID: <90ad0c46-f58f-40c5-bfb3-607501c70cf6@amd.com> Date: Tue, 17 Oct 2023 15:02:56 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 03/11] gdb: Use C++17's std::make_unique instead of gdb::make_unique To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20231013144418.3180617-1-lancelot.six@amd.com> <20231013144418.3180617-4-lancelot.six@amd.com> <874jiqs7lk.fsf@tromey.com> Content-Language: en-US From: Lancelot SIX In-Reply-To: <874jiqs7lk.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0090.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::6) To CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR12MB9079:EE_|IA1PR12MB8077:EE_ X-MS-Office365-Filtering-Correlation-Id: 0179734b-9214-488e-80c8-08dbcf19c6a0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6j0ZOaOxLVScKJx5INfZNHGerhw7s2k7nxJiJWknHTjzjhe5tSJ00zECQELiA2mBaFAtAeumb/CGW5zX24mS3IzVNdKWQtomH2F+HfL/9Yh0HaWG25w7Bhi4aoQAX3ROC6wR8GsT9dglRhx6JSsiNhsXMyPFjbGtiJUASwWXEVDcviXhQtZXdi7/vDawKdD21SH1h4j0Xpi8H82UADJp900EiAPoKolZuINRN0nR8FZ9IoAbvAPOcNS9VZ0R5iOjiGrEli/qh/ScC3/t17m7Cz2FVYESAiv3R1BDKd5ecPhHnfvHpEEnYYn4ARgP/Kytvq9f/fln63ZPifAFBrjHf5JvxT2mkUbvFt6agTMDSx6w0UAPyKi+weot1zzJXo6aBORyhf4PI6XaHiJe1d844JMNuLUX9w9mSTlXkiwFh/K+KlXIiiAcO60DYNGFqbdPfjvdTvIE5oL8/dC+VkPPES/WB2czc3DCXoXxziUQqsISacBydTOBTj74jgpJiU6sAW2DY7NHwrvWblUxekXpOe/as0Ybf8f5DiL5PrhF1YM6XrKQOY8IgtOvhDWTOafVuE99ryS0MK/wVao3d/9jlZwhdvzx6kz7IRu9aYClo289YasE4Q2vmGPreIgHozpJiUdiIa3cx46TMz4ci9Q1KA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB9079.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(136003)(346002)(376002)(39860400002)(396003)(230922051799003)(64100799003)(451199024)(186009)(1800799009)(26005)(31686004)(36756003)(86362001)(31696002)(5660300002)(478600001)(2906002)(6486002)(41300700001)(6506007)(38100700002)(2616005)(6666004)(6916009)(66476007)(8936002)(66556008)(66946007)(316002)(4326008)(8676002)(4744005)(6512007)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?azhLcjdXMHQrcDVhSzRKdWl2QWF2YUJNZ3A3R0xOSm9KdnM1ckZ3OXZjd290?= =?utf-8?B?TElLNTBZMTNlK0ZpZTNKSTNTREJTb2dqSHA1ZnViOHA0bVYzQ0JTdmhMR2la?= =?utf-8?B?U3g1MmV5MnNPalA4UVJibmpSVEczZCthZ0VrQXhhaHZaNlh4V09RNmhWeEtJ?= =?utf-8?B?ak1uNVJlRzNDaTlqb0F0dnVaTFlOS3ZLdEtLUGZSM3dMYUhwb1lNT0FQL2N6?= =?utf-8?B?NzR2L0paMmx1eGZaZktWMDZrRTVzWmNOQytTenhOR2ozaUMrSG8rbklXVStZ?= =?utf-8?B?ZFBQN3FZU3JDUkZLd0ZMK04rcngwZUxTcEdpNTFUbXQ5SnlNd1R0NHZFKzZX?= =?utf-8?B?Z2YwT2dRNnNqQXRFanZqekN2MTRsdjRLU0RaRjRjWUt6MDQzcXgwemRvb2Ir?= =?utf-8?B?eFRlVGNoK0k4RHBGNzlhSFlmelpJbENzam5FZEFLNU1BN2pvMHdBdVp3NjRj?= =?utf-8?B?eEd1WCt3bDgvYTBIc1VuWnNUMkViRXZCZzZQSjRBYWM2WXpFKzg1bXpiSXha?= =?utf-8?B?WWNsQjdTQVViWC9XS2grQ0xMajdZd21iMnNwUWd4QlhkSS9ldHEyNkNBN3pV?= =?utf-8?B?dHkzem9Razl4eU5SckhBeFJxeEVFcFFPdTFTUkVNL0FyRDFiTEZmMlVacW1M?= =?utf-8?B?YkFXUXlkTkFsMVhsWVZ1T0xhdUpheDM4NXV5bDF6eXpEODhUZzFJR1I3V2hZ?= =?utf-8?B?c2hNS24wUVkxcXNTajlJVEhuak85NU9aVlJTSDM5NmFoc2wwRjBFKy9lZ0Zv?= =?utf-8?B?eW54bU1zSlgrMDd5aG52Z0FXMXdFekZjRm52dWNDTDl0N2xlVmIvTjhXbGZ2?= =?utf-8?B?ZGlZbUJVTmJQOWpDN1owQ2xlZjlZdkJ4WkdjNmZad0tyR3JyK2llaHVZSDFL?= =?utf-8?B?RXNOSTJGM1FkUFNIUHZzb0ZZdnJaUVRhcVdTZW83Y0pGSCt5K05udERwaVRY?= =?utf-8?B?OGdzSXBxSDc3Y2tNN2ZHUHFvczZuRzVJaE9YNk90R2NPVzhUazlkeEExTm9D?= =?utf-8?B?VXJDRHMvTFZQR2QwY2pDRmpieXV1QndUbTJ1Z1RGSnA2Y0xNTVZPNm5IMWI1?= =?utf-8?B?MXlaQVFYMXlUeStwQnF5Yk1hMVdTQzFlcUJnbnFuNjJCdVp6N3RtaGc3SUtq?= =?utf-8?B?OXpGeXNDK3lmK3d0VWtsZzJkYzQzUFVVb1NXY050elFDYlFaczBPczQ1eGdZ?= =?utf-8?B?VnJpa1Zya2FheDc3NThrODhCK2YrblJNek5EYk0wVmNsbTg2WGVoNWdzc21z?= =?utf-8?B?MlhPZEpybU1pVkJ6L1l5ajdCbk5wLzNEUWtVNDZmWWZCSy9IejdmRFJKRTdt?= =?utf-8?B?U0hSWE9JTUp5cHFSMmxFNmVyT3ordmpXclB5SGZVUHBJRU9SbEZ0ZWRFU0JO?= =?utf-8?B?MUZOTDlCL3RjNm0wa0lJN1g5Y0w2RzJkUE9ob3QxZW9XbldkRE9sRk9CSlM4?= =?utf-8?B?eGNhOTlkeXRhRVpwUmZTSk53djl0cWgxVmtHTmZnK1BhM3VPenJzLzlSNjlM?= =?utf-8?B?NzQ3VG4wY1RKMS81a1RhdGp0OFliamZsb2JveHRZdXM3bnJ2LytNb2diMFdu?= =?utf-8?B?QlBjRm5HZi9WakZ2ckJEYkdLSUI5K2gxVFpPcmdqV2ZwYy9acytLYlp6N2lx?= =?utf-8?B?cGlrc3dDTzZsQ0lCOVFCbmxWTkg4Uk9ic1VYbUZWNVRhdnlRY1FkajFaUDJK?= =?utf-8?B?U2Roa1FVd3RSdDBVekVyckhlb2E3YlBYdVNQTkhOMVkzNWdmYW9nejZNRWZo?= =?utf-8?B?Zk9uK1JrQ3Y3UVZSa1ZmSjlXYytZRmhoUnZpdHkrTlY4WDhxandWVngzYzZi?= =?utf-8?B?VEVJWTlxMWdXUTJqNHpBbUExVEdmQWFiUFFZd2cvZm1ybXdXUytMUGFsQVNo?= =?utf-8?B?YjBydmwwWUZscitzM05LS1FnbTFIMktvYTh0dlZSUnRGMFdGQUJVcmdZbGZ2?= =?utf-8?B?cW1lbWRwTkpyek8wc2FMR0tkd3p1NWpBZnRRc1ZBTGFNWFFGZmg4TTBQTDMw?= =?utf-8?B?VGg1OHVvNUZPSXRPMWlPWTFrd1NNR3RvOGJuNkhMR1FLS2paMUFnSmhHeklW?= =?utf-8?B?TEpab0VIeERMeEN4TnV3dGs2KzRZcHBEOFAwMnkxQmpMRnl2bWdRRHJaQWhD?= =?utf-8?Q?uMoE0hdxyDkvknA0ecABFQKbh?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0179734b-9214-488e-80c8-08dbcf19c6a0 X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB9079.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 14:03:01.9507 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FJHbwRAZldvwHrD6Q8kdHGg7bwVwLSQSpdqxXVeb1TRn1Xq7uZ6AIKYODj+/OyeZQPFbbVZwKExwgqbsieE6bQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8077 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FORGED_SPF_HELO, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org > > Lancelot> +#include > > I don't really understand why these includes are needed, since > gdb_unique_ptr.h includes , so presumably it's already visible > at every spot that's being touched. > > Not sure it really matters, but I was curious. > > Tom Hi, I don't think they are needed, given the transitive include. I think I got them mostly out of habit of "make_unique" is provided by . I'll drop those from the patch. Thanks, Lancelot.