From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43293 invoked by alias); 12 Sep 2017 11:35:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43281 invoked by uid 89); 12 Sep 2017 11:35:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=originated X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Sep 2017 11:35:36 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id v8CBZUq7007437 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 12 Sep 2017 07:35:35 -0400 Received: by simark.ca (Postfix, from userid 112) id 344FC1ECE3; Tue, 12 Sep 2017 07:35:30 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id A02BB1E988; Tue, 12 Sep 2017 07:35:29 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 12 Sep 2017 11:35:00 -0000 From: Simon Marchi To: Sergio Durigan Junior Cc: Simon Marchi , gdb-patches@sourceware.org, Mark Wielaard Subject: Re: [PATCH 2/2] Make collect_probes return an std::vector In-Reply-To: <87tw08ixc9.fsf@redhat.com> References: <1505053377-10061-1-git-send-email-simon.marchi@ericsson.com> <1505053377-10061-2-git-send-email-simon.marchi@ericsson.com> <87tw08ixc9.fsf@redhat.com> Message-ID: <9092b2ca14aafd2010678fc01b761641@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 12 Sep 2017 11:35:30 +0000 X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00332.txt.bz2 On 2017-09-12 02:17, Sergio Durigan Junior wrote: >> diff --git a/gdb/probe.h b/gdb/probe.h >> index 61e3031..75e9a5c 100644 >> --- a/gdb/probe.h >> +++ b/gdb/probe.h >> @@ -214,15 +214,22 @@ struct probe >> their point of use. */ >> >> struct bound_probe >> - { >> - /* The probe. */ >> +{ >> + bound_probe () >> + {} >> >> - struct probe *probe; >> + bound_probe (struct probe *probe_, struct objfile *objfile_) >> + : probe (probe_), objfile (objfile_) >> + {} > > What do you think about putting simple comments on these constructors > summarizing what you explained in the commit message? Ok, I'll do that before pushing. >> >> - /* The objfile in which the probe originated. */ >> + /* The probe. */ >> >> - struct objfile *objfile; >> - }; >> + struct probe *probe = NULL; >> + >> + /* The objfile in which the probe originated. */ >> + >> + struct objfile *objfile = NULL; >> +}; >> >> /* A helper for linespec that decodes a probe specification. It >> returns a std::vector object and updates LOC or >> -- >> 2.7.4 > > Otherwise, LGTM. > > Thanks, Thanks, Simon