From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CMV4D6Fu/GXKhBAAWB0awg (envelope-from ) for ; Thu, 21 Mar 2024 13:30:09 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=freebsd.org header.i=@freebsd.org header.a=rsa-sha256 header.s=dkim header.b=l9FpNMtq; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3A9EF1E0C0; Thu, 21 Mar 2024 13:30:09 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 23EA01E08C for ; Thu, 21 Mar 2024 13:30:07 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BD6BA3858D28 for ; Thu, 21 Mar 2024 17:30:06 +0000 (GMT) Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by sourceware.org (Postfix) with ESMTPS id 7F8433858D28 for ; Thu, 21 Mar 2024 17:29:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7F8433858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7F8433858D28 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=96.47.72.81 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1711042187; cv=pass; b=JErPUkIIigXyZ2WiMb+dlq3AuYdyFyONbJ8FZRzLXXNg80L+O006L0MMcMCJ19sGm27uYVivoK8RFBALhnLIGmFIXi2Fk1NsWKJpWH0iB2Pl/t0h2F8vkRzDsjpISCKSpKP5H/Npj0qEk2gteolUMobaCDZo+ShLQdmmaW62kiQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1711042187; c=relaxed/simple; bh=pjSFjhwtYGgIMeUXmZ2A1ypPzS2hBCw6+HmLd+P2sUI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=R9gamoTu0NUB62aI/+f2FzUw7FVFqTb5s+NO8kL4+QAxlxS5pE2li+XCXFkLAjcY8XE14jcpFyJE/kWk/XTqdOh872M3l8YB4lzJ9i/lU9+WPWKcsUgDgwa3OMQAQVJRaXX4nhrTdyx+FLYQOHukje05n51pwpRRtE+cstHbdKo= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4V0ssQ2YKRz3wHS; Thu, 21 Mar 2024 17:29:46 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V0ssQ1kWnz42ry; Thu, 21 Mar 2024 17:29:46 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711042186; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=78hBQakrGBNtCMkST+lUiKDUH6afOihDkiXeVt8AjgY=; b=l9FpNMtqOiCz852gMzAC8K6GtU2NE4oxeHsuJh9TtMsiQ0aCUd9hVPurppRmorvZNt0mAO xxPVwHjjth+JhdH959iC/ktz8s6gHn4U24EDCY1xnCPDMJFUVlX7LeIWzfXR2mIRJ+CHCw lRIUazperej7Hh1zDaRqFAftFACIHC8GUYZw+Dcr8hD5BGried/zwU5s7x+hxTtQMORg1P TpvTKrrFmhYL9efnwmHDA4X3k8y64XZC/X0gLAQUNAMjCFXw/hD55h78hZHYHXQuGbs651 edPF5RQmC/ABvNIfaiEc6bskykPd0M1714lVe3cVcVC3b5RpHP9hc4En5/o3pw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1711042186; a=rsa-sha256; cv=none; b=nvl16/Bhv/t+ewfVk5OLPicgF+FFZlgzyA5zmpc/dyn2ic0FlLtalNPd9+04iUPHssLZ7S 35wLKUJaeTMGLK5tM15ayoqYQvrAUqlizcr1WO8nWpWS083yJAE2benvRf+jMbby2JZhar aPdhdSjBAtnDAdBYUvffkIO88pdk5fOVBnWFJz7AYBzOy7RcjsZ0j1to8ecL105Pu417ah BiDNSEqtcFvpUkOLM3WA8nGB9Ty42PDUQyrWbBc5OnS2QnT87F9aDou6xeDWb7vOjyG4t5 cxpDwWSjv68GOEBgUog+vXhFkeJmaXLmcyPWJP0+xMcds7Z9n1SsYn1cK2XosQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711042186; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=78hBQakrGBNtCMkST+lUiKDUH6afOihDkiXeVt8AjgY=; b=oqZK2+09E7p4c8DEP/puD40Eh5PiDTDbWj3xTQzERHgNKfaRREK+U/ObL9GQ0VjBn0J8MZ fb7J4SKnoMZtQ5jGEiZlZXLGU5jrqpgTU/oCTIyjQNCQzc9q8+s5/+lgbfhkzHrEMnmshc Jc6gFqylmz5hf6HXPxeKf7MLotcODy0PQ7l0E6/iae/pN20sPXosuvn0f9/FyHSm40qbI3 WQ0Cdj/9gYHPdOhlv5GrOpByl/328Xq+59NW9N6DfYwpXzgksLwUuUz3xj2+5EAt/0uSp5 /vA7/MIeCeH9TVhWMR725IR2Zjfq8cKKtxj7emNE+JuNyxiLaPcdmVxjxDOKNA== Received: from [128.232.109.28] (user-109-28.vpn.cl.cam.ac.uk [128.232.109.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4V0ssP1gNwz15mq; Thu, 21 Mar 2024 17:29:45 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <9072029f-310a-4683-9946-498a5bc58c18@FreeBSD.org> Date: Thu, 21 Mar 2024 10:29:44 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] gdbserver: Clear X86_XSTATE_MPX bits in xcr0 on x32 Content-Language: en-US To: "Willgerodt, Felix" , "H.J. Lu" , "gdb-patches@sourceware.org" References: <20240320111318.117728-1-hjl.tools@gmail.com> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 3/20/24 7:45 AM, Willgerodt, Felix wrote: >> -----Original Message----- >> From: H.J. Lu >> Sent: Mittwoch, 20. März 2024 12:13 >> To: gdb-patches@sourceware.org >> Cc: Willgerodt, Felix ; jhb@FreeBSD.org >> Subject: [PATCH v2] gdbserver: Clear X86_XSTATE_MPX bits in xcr0 on x32 >> >> Since MPX isn't available for x32, we should clear X86_XSTATE_MPX bits >> on x32. >> >> PR server/31511 >> * linux-x86-low.cc (x86_linux_read_description): Clear >> X86_XSTATE_MPX bits in xcr0 on x32. >> --- >> gdbserver/linux-x86-low.cc | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/gdbserver/linux-x86-low.cc b/gdbserver/linux-x86-low.cc >> index 3af0a009052..933d1fb012a 100644 >> --- a/gdbserver/linux-x86-low.cc >> +++ b/gdbserver/linux-x86-low.cc >> @@ -938,6 +938,10 @@ x86_linux_read_description (void) >> xcr0 = xstateregs[(I386_LINUX_XSAVE_XCR0_OFFSET >> / sizeof (uint64_t))]; >> >> + /* No MPX on x32. */ >> + if (machine == EM_X86_64 && !is_elf64) >> + xcr0 &= ~X86_XSTATE_MPX; >> + >> xsave_len = x86_xsave_length (); >> >> /* Use PTRACE_GETREGSET if it is available. */ >> -- >> 2.44.0 > > +1 from me. > > Reviewed-by: Felix Willgerodt Looks good to me as well. Approved-By: John Baldwin -- John Baldwin