From: msnyder@sonic.net
To: msnyder@sonic.net
Cc: "Jim Blandy" <jimb@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] stack.c, memory leak (no-effect code?)
Date: Sat, 18 Aug 2007 00:20:00 -0000 [thread overview]
Message-ID: <9068.12.7.175.2.1187396419.squirrel@webmail.sonic.net> (raw)
In-Reply-To: <16770.12.7.175.2.1187044033.squirrel@webmail.sonic.net>
>>
>> msnyder@sonic.net writes:
>>> This patch is to fix a memory leak, but while you're looking at it...
>>> does it seem to you that these two blocks have any effect?
>>>
>>> [Sorry if I posted this before, I've been searching for it...]
>>
>> You did post something very much like this, but I recall that the
>> blocks in question in the older post really didn't have any effect.
>> These at least set funname.
>>
>> I'm kind of surprised that they don't set funname to demangled when
>> it's non-NULL.
>
> OK, how about the patch itself?
So, checking in the patch, ignoring the possibility of dead code.
prev parent reply other threads:[~2007-08-18 0:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-10 22:19 msnyder
2007-08-13 19:41 ` Jim Blandy
2007-08-13 22:27 ` msnyder
2007-08-18 0:20 ` msnyder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9068.12.7.175.2.1187396419.squirrel@webmail.sonic.net \
--to=msnyder@sonic.net \
--cc=gdb-patches@sourceware.org \
--cc=jimb@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox