From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29976 invoked by alias); 10 Apr 2017 04:09:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24550 invoked by uid 89); 10 Apr 2017 04:08:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=Hx-languages-length:407 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 10 Apr 2017 04:08:24 +0000 Received: by simark.ca (Postfix, from userid 33) id E0DE01E7F5; Mon, 10 Apr 2017 00:08:24 -0400 (EDT) To: Tom Tromey Subject: Re: [RFA 08/14] Remove some cleanups from gnu-v3-abi.c X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 10 Apr 2017 04:09:00 -0000 From: Simon Marchi Cc: gdb-patches@sourceware.org In-Reply-To: <20170408201208.2672-9-tom@tromey.com> References: <20170408201208.2672-1-tom@tromey.com> <20170408201208.2672-9-tom@tromey.com> Message-ID: <9067796064c9df3220f55405282dc9f8@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.4 X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00226.txt.bz2 On 2017-04-08 16:12, Tom Tromey wrote: > @@ -821,7 +812,7 @@ compare_value_and_voffset (const void *a, const > void *b) > > static void > compute_vtable_size (htab_t offset_hash, > - VEC (value_and_voffset_p) **offset_vec, > + std::vector *offset_vec, > struct value *value) Pass the vector by reference? Otherwise, LGTM. Simon