From: Pedro Alves <pedro@palves.net>
To: Claudiu Zissulescu <claudiu.zissulescu-ianculescu@amd.com>,
gdb-patches@sourceware.org
Cc: lancesix@amd.com, simark@simark.ca
Subject: Re: [PATCH v3] gdb: Remove redundant clear_proceed_status() call
Date: Tue, 23 Jun 2026 15:58:16 +0100 [thread overview]
Message-ID: <904bda90-33ee-4cb0-b5a0-695084857a86@palves.net> (raw)
In-Reply-To: <20260623125317.11174-1-claudiu.zissulescu-ianculescu@amd.com>
On 2026-06-23 13:51, Claudiu Zissulescu wrote:
> +set spawn_id [spawn_wait_for_attach $::binfile]
> +set prog_pid [spawn_id_get_pid $spawn_id]
> +
> +mi_clean_restart
> +
> +mi_gdb_test "-target-attach $prog_pid" ".*\\^done.*" "attach \$PROG_PID"
Add at the end:
kill_wait_spawned_process $spawn_id
as a belt & suspenders.
I'd say the subject should have been adjusted as well, to something like "Windows gdb: Fix -target-attach result".
With those fixed:
Approved-By: Pedro Alves <pedro@palves.net>
Thanks,
Pedro Alves
prev parent reply other threads:[~2026-06-23 14:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-23 12:51 Claudiu Zissulescu
2026-06-23 14:58 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=904bda90-33ee-4cb0-b5a0-695084857a86@palves.net \
--to=pedro@palves.net \
--cc=claudiu.zissulescu-ianculescu@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=lancesix@amd.com \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox