From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128368 invoked by alias); 14 Nov 2017 21:38:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 128351 invoked by uid 89); 14 Nov 2017 21:38:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD autolearn=no version=3.3.2 spammy=regularly, Hx-languages-length:1063 X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Nov 2017 21:38:18 +0000 Received: from ESESSHC006.ericsson.se (Unknown_Domain [153.88.183.36]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id 52.B3.08439.7426B0A5; Tue, 14 Nov 2017 22:38:16 +0100 (CET) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.36) with Microsoft SMTP Server (TLS) id 14.3.352.0; Tue, 14 Nov 2017 22:38:15 +0100 Received: from [142.133.60.14] (192.75.88.130) by DB4PR07MB314.eurprd07.prod.outlook.com (2a01:111:e400:982f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.20.239.4; Tue, 14 Nov 2017 21:38:13 +0000 Subject: Re: [PATCH] Assertion 'xfered>0' in target.c for remote connection To: Paul Carroll , Sergio Durigan Junior CC: "gdb-patches@sourceware.org" References: <1155839491.1748621.1509663923992.ref@mail.yahoo.com> <1155839491.1748621.1509663923992@mail.yahoo.com> <87lgjo6oqi.fsf@redhat.com> From: Simon Marchi Message-ID: <9030ce55-663c-bfac-7586-dd1934190815@ericsson.com> Date: Tue, 14 Nov 2017 21:38:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BN6PR08CA0069.namprd08.prod.outlook.com (2603:10b6:404:b9::31) To DB4PR07MB314.eurprd07.prod.outlook.com (2a01:111:e400:982f::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8df964dd-4f5b-482e-2697-08d52ba8026e X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603258);SRVR:DB4PR07MB314; X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB314;3:T6eWgH0rSOWpQYu7uinVTpasQKgLPwGQdph8bSZna17BWdWrOysfvTGyYFR2L0opujkBX29zCeYhguKCzdn9982KYe9G7KYgj+B0Wmt826ROh7KIneyIAwCkamMQ5/Ox7jcqRzLLJkl2OtbGOI8uxYJrvgqLXkTV5O1PsmJICbbRYKjgHW5lWBipb3GA4xYEztuZzKpJ/tvIOG5T6OdG9ZwjvQfFtzb9jL+PiwFkCFRFKFd3LkEJ6AStEYZsQATC;25:XQV82ub0XKDfiPaCQBB01lfcO4Cf+5xBFoSKeGM+yOi4WgI2TTfhVLWAH9Exc9ej8lPzvll2MdMROCgpQFXizf/Sq8qQlWr9UBk41wKEQIZfa2xGi99roSiPf2Bzj0+8Lpipuc7X03fZMI4togvp/drkIdnwCD+r3I/XZSmJte+8jNzA4st+CvD2TcT6zQ6X5kPWHt2Xq7cr9GyX+wNbC2mepl0t82Gj4bp90WJm14dAgzYULS8yhJjfBP28ktqOEhsk1or3LNH9CulGBpp/jQR3A4yf65kxECVnvPPyn/9OGK3Fk2eP+42PohMn2zVj0ZUzTgq3p5n3/XVI2/IheA==;31:h4GNFlOnRGsh80HehWQgQdVS/pTRJmaJihudmwnUn0yH9QQttjsS2SeRwdRi6W9gXeUhyL6kjwd+GSWTBJdThBUO+S7qNtK325v8gTgnkPy5FcbbiDeBKDqC/5uK8RQPm764x6nwN8j0IYtVxVAUjTshji/6WrV5uAEUqQe4wn4+9WneE+lYRdtmy3fSQx1fWvYvSCL9r5TXkFxHsnRh5TgF56Z0xyLi5KrqXcQ66z4= X-MS-TrafficTypeDiagnostic: DB4PR07MB314: X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB314;20:Qxh6lFHfttl8wBLpZ0Z1sK5rO+niO46ienTckEOqoRTzX/SdNSrerdGDvfZrdAaiWeFSSPYQJTVaBy5u12byMLgJAwZGm/dp/9V2fgrxnrUEsG5+TxaKSIcSNA5LgqkRFHRkMm494Rwn2VzZNxL3szhacQv2p+6pU3/GgynLqaEkkmQZs/DaviDqBP6Iynv63MrwcUeZGy9KfB+GaZWPxXFK6GL6vxxrl0VL/C2Rl7VKiI5T/g7aR7hmJmMzPHGU7Z2k3ee1VJ95iZDEM5R6dz/SmtLNllWOyl8p2N1DgKKUMvwszjQV0kNqikfrO2HHPTkqauc0rgT5NCnZQCXOrb+3PVdi/cB/Uq9bn07SmFNtgYjPyDE6hoFdHW0pBYHfLkkX0leLWjtzwn9bVgifC0erYVNg50KlGjDJ+2NLbStamZhp51oCrbTV85PYeJV1m4R1tcb85u3R5VXzL2w0qV6P2RL/VFcm7Gio0xpadgtLSbEc7Q1oTgGlm9dyVsqz;4:7XiDxqUCHXuAZ1nc884g+Huy23k6RurWZKqPlzwmMdYLsxLfrICo9L0zpQYsbnJV0w2NGxY49LqXNP6BpklxowcyblqjyIpdGZbRNzTq05DeKZbPIs6klJHoWfK2S1P2FUsnxn+s1/Ebg9+CfhS6aKi+g7AQUClD806utjqyegdQj1lc/kS+INOgCgP6xDDBp9tDOG4EhT9voNN2YpZymdsCbED9CtVj0buUV2QbviFQAddKLFNaSFRunSqdX3tgdhKFIWmIF+yAjTyNbTwl+beonr2nbHZITDIa0yqxvpeX5+WHCCkIOxlGVRvTlrbVtxHxDL20MutiXyVJISk8fvlSoLPwpy4/C1DERtYqN60= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(158342451672863)(21532816269658); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(3231022)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6041248)(20161123558100)(20161123555025)(20161123560025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DB4PR07MB314;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DB4PR07MB314; X-Forefront-PRVS: 04916EA04C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6049001)(346002)(376002)(39860400002)(189002)(377424004)(24454002)(199003)(966005)(6246003)(7736002)(31686004)(8676002)(36756003)(6486002)(66066001)(105586002)(229853002)(305945005)(106356001)(4001150100001)(6116002)(478600001)(49976008)(47776003)(65806001)(2950100002)(93886005)(6666003)(3846002)(64126003)(101416001)(65956001)(53546010)(53936002)(81156014)(81166006)(8936002)(23676003)(4326008)(33646002)(83506002)(6306002)(31696002)(316002)(50466002)(86362001)(189998001)(97736004)(54356999)(230700001)(16576012)(5660300001)(50986999)(25786009)(65826007)(76176999)(2906002)(68736007)(58126008)(110136005)(16526018)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:DB4PR07MB314;H:[142.133.60.14];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjRQUjA3TUIzMTQ7MjM6ZzZ4M3RucFNxQzhMaldjZ1M1cDRDWFNQOFU1?= =?utf-8?B?dDdDUHgwdU1UN3pZeXZGLzdQWXRDTmVIODYzc0FHRjhJTTVqWDY0bE1FY0Ji?= =?utf-8?B?VkZmVS9Ma01DUHBpbndOZVk5NTloRVNJUXV6cWFLSTZ6Mko1ZGJ6Umk3WnR5?= =?utf-8?B?ZkF0djBFS3dVWHlGS0lCcThYYnQyRXdFRzl4MlZhTU90dGoxNmw5dkRXV2RI?= =?utf-8?B?cjI2bjBmVFBVaGVselNxUzNPS0lmY1V6ZFNKMFg5MzRJd29OU3V3SzVVMXho?= =?utf-8?B?VnN0elZkeFMwNHk3dWNXK2s3aUhDSUNSQXZGZm1LKzJBWHdyOTBVTENMR2s5?= =?utf-8?B?V2RaaHRyUDBBcWd2T3J4WVNwekREKytxL3gra1c3QTdqaU5lTDNSVTFkY2hV?= =?utf-8?B?Wkdod3p4QzFEZ05aSUQ1d1F1RTRwL2pFNWpxS1pzWHN0bGw1cVRDeWRSYUJO?= =?utf-8?B?Q3BLc1pCQ21XK1NJZDAyQzdQU2wxVVlxVWN6UWl1ei9TK3NkelZuMDVyWDEr?= =?utf-8?B?bVJzVFllenBnYjI2M0tuRGg2MWF3TXVXSkkyalFYMnVRMTlVMnhDWWd6SWNm?= =?utf-8?B?WnhsNytpbXdLcXNHT2NjQmVZY3JNVjVsQUhHbU9POGRpTmR4bE52dHdnYkRF?= =?utf-8?B?UmlwYnAwL3VCMmFocjdaaDJ2aHBhMjdCL251R1NTT3BWMzE2eE5xK2k0T2d6?= =?utf-8?B?OFZHc0R4M2RKbVZxWFF5c0hIN3J3M0xXWnoxZzZ5YmxZQ0NjUUZBdHZwVEVM?= =?utf-8?B?QTN0Yk5QZTlRS2RlVWd1bkRRdWtQZHlibnhzSGI4WFh3Wk9sc21kOTlxcStQ?= =?utf-8?B?TTRLYkY4SzNRM3BkRlp5dXpLTEtXVGRVbkJXWDVYYnJpQzFteTRJdWRNT0Yr?= =?utf-8?B?ZlNWM3lNTjdlZ1pKaTh4dkxPcThzRkE4aW9BL2xzcjkzU2c5ZWk5bDBkc3VE?= =?utf-8?B?ODlzRDdwbVNjU0pwWFNtMy9NaVFTU2JGUm9Uc1lycVVQZkN5WnRGemM0Q3py?= =?utf-8?B?ZGRQc0JVY3Noa2xNbGt0dEFpY004Ris1a3NPY1VCUnk1aklabDJvSXFHU21G?= =?utf-8?B?dUVkTDlkTGhtRlBRN2RSSUc4V3M5bTllSW1DV29NeE5EaGg3MGdCL3RtUmYz?= =?utf-8?B?MWxBdmw4djdvNWxhUXdQbWFDN1FoekhWNTZwVmdHNmtMTC9JOUxNcjZMUUxi?= =?utf-8?B?WXpmdGdxZy9XV0MxNktlY1hYbXh4cEJsdmlCbWdiTzFNdHlBZXVyRWdqVE1I?= =?utf-8?B?bFF6M1dGQmY1QnlHTHpaUWQ0YkFMc3IwZC95QTZCQkN1aTg5ZlNzaER2UGNK?= =?utf-8?B?b2RSalNNMW5xNVdKY1VlcWNPelYwb3FzYytGZTBEUUNibUFyWnZ5V3ExNlZx?= =?utf-8?B?OVpVZjlSVGlNRkQzTlVLbW81Q2s1cHFYNlB1Q3JWZUxvYktDbk5EWVRDbnF2?= =?utf-8?B?WjUxWHNMSm1QSVZlVXVLWlNUUTgyTmNUNmE2ZUFOVzVESnBaWDV0TlNSVzU1?= =?utf-8?B?b0g2cEJlZU5PbEJ6QnpFYkxXcno2eU1TQmRjN2trWTVjOW5FS1lNZERYSDkx?= =?utf-8?B?WGVsWDZ5NzJTL3o5OENoSGRIWEJFSmh2QThOVldyYWxkMmhvZ0J0Yk41NXFS?= =?utf-8?B?MkZRUy9WZ1k4clZ2c2hVTSszSWlZazBaV0ZVcCt6WHdyRmtuS3BIcU1kUkNK?= =?utf-8?B?Y21pN1hUOFNMaUp3VEU1dDBaOWNUeFYwOEs2UG43MG1yOGYxc0R5R3c2M0ZR?= =?utf-8?B?YjRrWUZBQ09ocWQ3ck5uK2JWNjVOYlpmYVVveE90UTA1dVk5dDJTd2ZwKzk2?= =?utf-8?B?T3BWTzg5eU1Rc3ZZTmIvaW5WU2dERGpzdWY3eWQxcmM1OHBkR2NmN0xPZ3dZ?= =?utf-8?B?TUhrdk9ubkVCK0I3V0tHdDJnSnd6ZWhPNU41Wkt5TUFOVjF1VVI0U2RDWlJT?= =?utf-8?B?UjBaajFiZmVpYkMyeWgyRk01NEtRdXZ2eTJhS3BaYUI4SGtLZHJPQ2JyRmpR?= =?utf-8?B?TmVLbURFNnZDZnpnTmxXNkR0Y2w5UlppRnlRPT0=?= X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB314;6:fdlYdoNUGzDzYBr31VAGdXyMBkWnOGwxhGvOMpGXhcCbmAxfMOtmDEOo5xt0aTXecvciYg8C/O2eZbf8IZLZaFmuEw3c8El8HzlGnBfBoh3Afau62ysDLRm2ziEP/0ww1BKDYcUDKtA/7JuVAssvKdgi9Ph94wcswKC5J+dMf+Y4uXvR/80KOn32qeKDmR75OUC2666kLF38mmCBXDMd18R919WjZdbCPnOER5OKF1NczEr58AofMS00kvMKneKW8wsnujc1wk/n0PBj3uUbOOxm3CObqxr6M2x5x8Gp/clRMRTRM54+/c0w5GC1o2hyhteDnCXC/4kZFwNE/f+DuriNnIKsJcvy0Sm6cERAQoI=;5:mfne6lMZRZ1FaFtFNmfxbkrjFeZh7zvxGVWcLwYfbjyDy2jAhIo94qaHgnxRoAnCtZ+vSbFlMImNuRGZdMl1nLhackKidoh7UPTVAcBqyiKaP3sX4mIzbPpeajWy35IlaZJdgTYg93qR+3J/JQAlX+TiIzNDqtIh4HVfmLdmkJw=;24:6fKi0llU3sGEW2POUsCLUIOfNtUImFFHCbPXENzxFuAjE8npl2oxL1JX9Y7Ptr3wvsN6j4paP4AddSrkfEcW5xKTvx2OYqnVJKVuWnFSSuU=;7:XGcOWbTvQmofpYSASdfQLg4o5zy0DibD30FWMsr0WbT5VN1QAtGEiMylyMIr4adOgXrKP3I73G1Jv6YmYRKyTJ/FNzuyLatJV03cmLtjDGNJ8/hESvEZQYPIO+RWKiK4/DdL/S5x6uXmGYDZopjmdGXofCsGXhw9Bwyu6ERbWVEFS2/FPx0C2aKp0kRGhdn06sGgbzOt6M+22DmWFTgDx8vVxuUv4TWT3csb6IqPWMuqreq1kt7wCo4xjv3N763n SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2017 21:38:13.1816 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8df964dd-4f5b-482e-2697-08d52ba8026e X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR07MB314 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00257.txt.bz2 On 2017-11-14 10:02 AM, Paul Carroll wrote: >>> We have a customer who is using a Corelis gdb server to connect to gdb. >>> Occasionally, the gdb server will send a 0-byte block of memory for a read. >>> When this happens, gdb gives an assertion from target.c: >>> >>> internal-error: target_xfer_partial: Assertion `*xfered_len > 0' failed. >>> >>> This problem is almost identical to that fixed in https://sourceware.org/ml/gdb-patches/2014-02/msg00636.html >>> >>> In this case, remote.c needs to be modified to return TARGET_XFER_EOF instead of TARGET_XFER_OK or TARGET_XFER_UNAVAILABLE when 0 bytes are transferred. The patch look good to me, given that all other implementations do this. It is small enough that it doesn't require a copyright assignment I think. I see you have contributed to binutils in the past. Do you already have push access to the binutils-gdb repo? If not we can push it for you, or we can get you an account if you plan on contributing regularly. Thanks, Simon