From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3771 invoked by alias); 4 Jan 2015 10:31:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3741 invoked by uid 89); 4 Jan 2015 10:31:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-oi0-f42.google.com Received: from mail-oi0-f42.google.com (HELO mail-oi0-f42.google.com) (209.85.218.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sun, 04 Jan 2015 10:31:01 +0000 Received: by mail-oi0-f42.google.com with SMTP id v63so44596696oia.1; Sun, 04 Jan 2015 02:30:59 -0800 (PST) X-Received: by 10.202.205.131 with SMTP id d125mr47129302oig.121.1420367459065; Sun, 04 Jan 2015 02:30:59 -0800 (PST) Received: from [192.168.2.74] (76-253-1-90.lightspeed.sntcca.sbcglobal.net. [76.253.1.90]) by mx.google.com with ESMTPSA id u15sm28125591obg.28.2015.01.04.02.30.57 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 04 Jan 2015 02:30:57 -0800 (PST) References: <5473A3D3.901@redhat.com> Mime-Version: 1.0 (1.0) In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-Id: <9024D36F-DB7E-4B33-90E8-253A7B1A8108@gmail.com> Cc: Jeff Law , binutils , "gdb-patches@sourceware.org" , GCC Patches , Ian Lance Taylor From: pinskia@gmail.com Subject: Re: [PATCH/TopLevel] Fix compiling libgo with a combined sources Date: Sun, 04 Jan 2015 10:31:00 -0000 To: "Bin.Cheng" X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg00034.txt.bz2 > On Jan 4, 2015, at 1:35 AM, Bin.Cheng wrote: > >> On Sun, Jan 4, 2015 at 6:55 AM, Andrew Pinski wrote: >>> On Mon, Nov 24, 2014 at 1:32 PM, Jeff Law wrote: >>>> On 11/22/14 21:20, Andrew Pinski wrote: >>>> >>>> Hi, >>>> The problem here is here is that OBJCOPY is not being set to the >>>> newly built objcopy when compiling libgo. This patch adds >>>> OBJCOPY_FOR_TARGET to the toplevel configure/Makefile so that when >>>> libgo is compiled OBJCOPY is set to OBJCOPY_FOR_TARGET. >>>> >>>> I noticed this issue when building an aarch64 cross compile on an >>>> older system where objcopy did not understand aarch64. >>>> >>>> OK? Bootstrapped and tested on x86_64 with no regressions. Also >>>> tested with a combined build for a cross compiler to >>>> aarch64-linux-gnu. >>>> >>>> Thanks, >>>> Andrew Pinski >>>> >>>> >>>> * Makefile.def (flags_to_pass): Pass OBJCOPY_FOR_TARGET also. >>>> * Makefile.tpl (HOST_EXPORTS): Add OBJCOPY_FOR_TARGET. >>>> (BASE_TARGET_EXPORTS): Add OBJCOPY. >>>> (OBJCOPY_FOR_TARGET): New variable. >>>> (EXTRA_TARGET_FLAGS): Add OBJCOPY. >>>> * Makefile.in: Regenerate. >>>> * configure.ac: Check for already installed target objcopy. >>>> Also GCC_TARGET_TOOL on objcopy. >>>> * configure: Regenerate. >>> >>> OK >> >> >> Committed to GCC and gdb/binutils repos now. >> >> Thanks, >> Andrew > > Hi Andrew, > >> + elif test "x$target" = "x$host"; then >> + # We can use an host tool >> + OBJCOPY_FOR_TARGET='$(OBJDUMP)' > Is it a typo for '$(OBJCOPY)' ? Yes it is a pasto. I think the fix for this would be obvious. Thanks, Andrew > > Thanks, > bin