From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18815 invoked by alias); 7 May 2004 08:18:22 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18792 invoked from network); 7 May 2004 08:18:19 -0000 Received: from unknown (HELO legolas.inter.net.il) (192.114.186.24) by sources.redhat.com with SMTP; 7 May 2004 08:18:19 -0000 Received: from zaretski ([80.230.142.26]) by legolas.inter.net.il (MOS 3.4.6-GR) with ESMTP id BSL34137; Fri, 7 May 2004 11:05:37 +0300 (IDT) Date: Fri, 07 May 2004 08:18:00 -0000 From: "Eli Zaretskii" To: Daniel Jacobowitz Message-Id: <9003-Fri07May2004110502+0300-eliz@gnu.org> CC: orjan.friberg@axis.com, weigand@i1.informatik.uni-erlangen.de, kettenis@chello.nl, gdb-patches@sources.redhat.com In-reply-to: <20040506180450.GA13648@nevyn.them.org> (message from Daniel Jacobowitz on Thu, 6 May 2004 14:04:50 -0400) Subject: Re: Display of read/access watchpoints when HAVE_NONSTEPPABLE_WATCHPOINT Reply-to: Eli Zaretskii References: <200405042208.AAA07379@faui1d.informatik.uni-erlangen.de> <4098A4F6.5020106@axis.com> <20040506142146.GA24608@nevyn.them.org> <2914-Thu06May2004205906+0300-eliz@gnu.org> <20040506180450.GA13648@nevyn.them.org> X-SW-Source: 2004-05/txt/msg00184.txt.bz2 > Date: Thu, 6 May 2004 14:04:50 -0400 > From: Daniel Jacobowitz > > I'm saying that I don't think exposing the internals of the execution > state machine to the separate module responsible for breakpoints, even > to a function only used by the execution state machine, is a good idea. > If two interfaces of STOPPED_BY_WATCHPOINT need access to something > from ecs, then pass it independently, or come up with a better-defined > interface. If the issue is whether to pass the entire structure or some of its members, then we I don't mind either way and thus we don't really disagree; modifying the arguments passed to STOPPED_BY_WATCHPOINT does not count as redesigning the interface in my book.