From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-138429-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 90422 invoked by alias); 18 Apr 2017 16:43:39 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 90048 invoked by uid 89); 18 Apr 2017 16:43:38 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=
X-HELO: simark.ca
Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Apr 2017 16:43:37 +0000
Received: by simark.ca (Postfix, from userid 33)	id 645081E48B; Tue, 18 Apr 2017 12:43:37 -0400 (EDT)
To: Andreas Arnez <arnez@linux.vnet.ibm.com>
Subject: Re: [PATCH 3/9] PR gdb/21226: Take DWARF stack value pieces from LSB  end
X-PHP-Originating-Script: 33:rcube.php
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Content-Transfer-Encoding: 7bit
Date: Tue, 18 Apr 2017 16:43:00 -0000
From: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
In-Reply-To: <m3efwppthi.fsf@oc1027705133.ibm.com>
References: <1491586736-21296-1-git-send-email-arnez@linux.vnet.ibm.com> <1491586736-21296-4-git-send-email-arnez@linux.vnet.ibm.com> <0144cae486cd82860db324db6f2e1e1e@polymtl.ca> <m3efwppthi.fsf@oc1027705133.ibm.com>
Message-ID: <8ffbcbb40eedc3f8486b00f223f5e014@polymtl.ca>
X-Sender: simon.marchi@polymtl.ca
User-Agent: Roundcube Webmail/1.2.4
X-IsSubscribed: yes
X-SW-Source: 2017-04/txt/msg00513.txt.bz2

On 2017-04-18 12:31, Andreas Arnez wrote:
>> It would be really nice for the readers if you could put some comment 
>> like
>> this, even though it may seem obvious to you:
>> 
>>   /* The size of a DWARF stack value.  */
>>   ULONGEST obj_size = 8 * TYPE_LENGTH (value_type (p->v.value));
>> 
>> I found I had to add them to the code to be able to follow.
> 
> OK, but it seems that the variable name 'obj_size' causes the 
> confusion;
> so I'd rather skip the comment, change the variable name to
> stack_value_size_bits instead and let it speak for itself.

I agree.

Thanks,

Simon