From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id aPKUGmL5B2e9wAgAWB0awg (envelope-from ) for ; Thu, 10 Oct 2024 11:57:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1728575842; bh=zID4+Tpx9g3SFsOaAqHkwFbRkW+KsOJpq1D+7820SVA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=mnSb7ry0+yMpUrKfClJjglHT513miQ4ysIpLAlcc3eBI35CpJh3jZWRZA+y6k4vhC kDfjQfd0M3oFQtTCGwZk1xhqoQtLvdYYv8K63DxUD6JHqbrDoxgK26xpXWj2ZuzdiM T8fhd7DuE3jGdEPg9qKE9qKwHN9DalSZ61JJ1TFw= Received: by simark.ca (Postfix, from userid 112) id 68B741E357; Thu, 10 Oct 2024 11:57:22 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE,URIBL_BLOCKED,URIBL_DBL_BLOCKED_OPENDNS autolearn=unavailable autolearn_force=no version=4.0.0 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=SlgsPtl8; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=ZqAWx8xB; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7C8A61E355 for ; Thu, 10 Oct 2024 11:57:21 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F147A385AC0D for ; Thu, 10 Oct 2024 15:57:20 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 268A63857BB9 for ; Thu, 10 Oct 2024 15:57:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 268A63857BB9 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 268A63857BB9 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728575824; cv=none; b=cObpWGcUN/e48TilJc2Sb7TxtmK+Ow8RwgIbx1nD7Vzf+zhA9wLpa1/QYhWsflrEsZW7aJklMxKdvNaAa1SguBeLeHTTcOgkktRNJw0H88MDbsPJ0iJyT3vJdix0d2PKuomBKZPX1DLcBeQUv8eJIQiL3USRS3X8+KgjaR8Tcjo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728575824; c=relaxed/simple; bh=zID4+Tpx9g3SFsOaAqHkwFbRkW+KsOJpq1D+7820SVA=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=sTrup+KKjiowV9KacwSxv4K9N2pmlGmICOMWcfKSDOEidDTCcUYy9BeYKLO7C6dD8MH749rC263zJpO9VeG9XRGK/QsvA6Lu3IhdCJPkKD9AqpNdYwPSUXZcQsAglwIUh/NF+JlWwGmxMtYbzikZqr48bwbDk65EaHBGUQntNFc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1728575822; bh=zID4+Tpx9g3SFsOaAqHkwFbRkW+KsOJpq1D+7820SVA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=SlgsPtl8htK1Wb6+F3A2jEbEekmary9LjoAYoSpcp8wizacbGwoxx35riOkWeSn6c 7JFS01FvYd0AR+TLXKT9rRIJI+KY9JVyl+ST4cman4RSPi+OFt5tdT56brKR0ClM+7 kFi4q/juvKl/01oYyXJkKtDxQL01S9uGk/Lu9MRo= Received: by simark.ca (Postfix, from userid 112) id BF1CB1E357; Thu, 10 Oct 2024 11:57:02 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1728575821; bh=zID4+Tpx9g3SFsOaAqHkwFbRkW+KsOJpq1D+7820SVA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ZqAWx8xBO4iMhGyYtbpuU8bOq7aM8eNpCt8qR75tiLYI69DgbNW9GfvZ/enlvt4PE waT4bwqVZyyWK0vtBtOaRKxX2tRDrrp2rYXg1FHCmUMRq8cFD8ps/ixyiJTn9Dad5b ADMDJyAGYlu0hTCVQkmaUeXGcz0fdskl3L0fcrsM= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 93D651E355; Thu, 10 Oct 2024 11:57:01 -0400 (EDT) Message-ID: <8fdf695d-9bd2-4573-aaf1-72a97a96a21f@simark.ca> Date: Thu, 10 Oct 2024 11:57:01 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/5] Set osabi in remote target descriptions To: Andrew Burgess , gdb-patches@sourceware.org Cc: Luis Machado References: Content-Language: en-US From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2024-10-08 13:11, Andrew Burgess wrote: > I tried doing some remote debugging of a Window machine from a Linux > machine and ran into some problems caused by gdbserver failing to set > the osabi in the target description that is sent to GDB. This series > fixes this issue. > > In v2: > > - Patches 3 & 4 are new. These are refactoring to allow for the > updated patch 5. > > - Patch 5 is mostly the same, except the osabi is now set based on > the enum values, rather than the osabi name strings. > > Thanks, > Andrew I'm done sending comments, nothing is a blocker, so feel free to address them or not, then: Approved-By: Simon Marchi Simon