From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ofbhHb8RnmgMagMAWB0awg (envelope-from ) for ; Thu, 14 Aug 2025 12:41:35 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=SZl7IS9O; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6878F1E0B3; Thu, 14 Aug 2025 12:41:35 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A32971E04C for ; Thu, 14 Aug 2025 12:41:34 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2CB863858D37 for ; Thu, 14 Aug 2025 16:41:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2CB863858D37 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=SZl7IS9O Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 3DE5B3858D37 for ; Thu, 14 Aug 2025 16:40:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3DE5B3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3DE5B3858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755189646; cv=none; b=PtuoJYtP9o6vlyRI4nW3ocHLOEbwdN16MGpZ2MmiVObOLtMzojg3NjW/WPtf8GWZxKYdgf/rwGHqPKhGnu160RBI8+flLmq03YqHGc03M6AUBsZ8rDlmJPNWwwx2PTZpLib+ul7LogHuteaB0iK2ddslCHHUk8fuKTODyLPLTds= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755189646; c=relaxed/simple; bh=PJJ5eBKVeg6rU5bn8qmmpUPqqRXZ/kFd+ihWEdy5+FA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=LoZYVl0cA7TmOrs7aI3xtMAn/EL2NUmP1MPnUmJNJ5Ngf7LDTfEoxx4Em3icskpZm+gOU/1778eXN+1VlWLvaSeJVM3U7dBiHo17Wn+oNGxrL6zMIMheDIHzcoEijFvosniQZMAUFp79qDkmlj27CVuNoTf8dmlGXDB1TI5b1l4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3DE5B3858D37 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755189645; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E/kElwTOqL/UNtq5oxR3yqWaPNTYo5zHX93WiiZvqsQ=; b=SZl7IS9ODwuUdiRDO+DQYIB2Lc4ygi+EP2BumSl93a4jB7yEf2fLy/PvKRepKCqM/aX3NA rhDVGLJyJTF73TQxA37ty0j/kXuPJoY62LqNNx4IVJGt6CtMWrM82rqLlO5KcCxjrM8E27 l2W9u1WVhG0hEdxPUI2iQDcND+NAfso= Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-169-iqXde4GCNkCZPPw3fKIx-g-1; Thu, 14 Aug 2025 12:40:43 -0400 X-MC-Unique: iqXde4GCNkCZPPw3fKIx-g-1 X-Mimecast-MFC-AGG-ID: iqXde4GCNkCZPPw3fKIx-g_1755189642 Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-b4716fa1e59so846738a12.0 for ; Thu, 14 Aug 2025 09:40:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755189642; x=1755794442; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=E/kElwTOqL/UNtq5oxR3yqWaPNTYo5zHX93WiiZvqsQ=; b=bivIjtO0v2BAohqSTJHfobov4ekdIyE+u0eZmFzds22tMH2RTiEpLl2ZMm0ojRAuGd AYf14Ha+nWdOMsrycNdmhno+D4394bEQVqyyNWEDZlbtjEEjwK/JFbUZ0vs+YL8Z30dn BLHxkqY7r1O2OlAfbQKYE4WxIpw5jAYz5WfexWVpHDAJ7xL1dRnNcJ52qhDHalohnhw6 bR8u3stAYi0L9k61afohd7nOFBIbBACnjoBcI8dTGn9MJdLuDmEd5s2s2/Sy7rmLc2cg MXI7bFLatk3NNAsY8IKZbF5YPTs51O2eUfVum3GQJfrmq/CeMBPtg28zdIvKeL4gN8wt 3yWw== X-Gm-Message-State: AOJu0YyIDKXJxZ0j0oWiQL8pcIFljrSrO9zFjRXAUrV/+cHnSz4J6Gtm KMI3QAVNK3Ow5XpfOAZkUUV1E/AowMSYoRIZioWO2kufBgbQuKusFIb5eNSRVjZ7s3+Ac++jbPz 9L+XLG+8ylssD+CjNlTYAuIJs+3Lhm9PXCbfS01r2x0iwOWA/tFRdd9nedzDZ7BF+D0apt7c= X-Gm-Gg: ASbGncvndwNAtqdyBFs9CcUwNbF1n4L1WOzRw0YcujW8pBW/dVCsJ+Rz2z9Pz9l9+zb 0IXAdqHGDp2FGwmh3LCgAE6NJxjrsMMHi4yTPnRV8rVLdFpezJSPxYv4kWeCP6jzIoiprm/aEJY 2YRkQJ6ZLooJy3lc2sFXMpg2TEfVO1mMGx4RmWNnZD0RzHIw+Zrt5LwFmKXSStQ2RIvXPOO8pVc T9nGxWFI6nNhAq9hzrSeRhMgTt516eJOLC4ZQJp67DzKo9ZQoth+zFNq9B4Bh+WK8fe6pNyHHsP KFOMt9SMhxt3zNA0BscVnqjouPs6xwiHXrbNP1i2CvY0Oj2Yb8M= X-Received: by 2002:a17:903:230a:b0:23f:f6ca:6a3 with SMTP id d9443c01a7336-244586c4480mr60774735ad.43.1755189641823; Thu, 14 Aug 2025 09:40:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHKvkOTp4iXzRwhOA2weVMPZobEOzc9i85Op5Yp8XWnyptK6b/WiGUruW+8QI3gxhC1ja34fg== X-Received: by 2002:a17:903:230a:b0:23f:f6ca:6a3 with SMTP id d9443c01a7336-244586c4480mr60774235ad.43.1755189641296; Thu, 14 Aug 2025 09:40:41 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:9a69::1000? ([2804:14d:8084:9a69::1000]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-241d1ef67aesm357282455ad.6.2025.08.14.09.40.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Aug 2025 09:40:40 -0700 (PDT) Message-ID: <8fd7220e-9911-47e2-b398-eef7ec66736b@redhat.com> Date: Thu, 14 Aug 2025 13:40:38 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] gdb: modernize get_frame_pc_if_available To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20250813130355.2236103-1-guinevere@redhat.com> <20250813202138.2311478-1-guinevere@redhat.com> <87o6shnaxr.fsf@tromey.com> From: Guinevere Larsen In-Reply-To: <87o6shnaxr.fsf@tromey.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ShmK-wZSwTL-CFTM9Z2_r4iSB-R4ElfjHs1SMMo4uKs_1755189642 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/14/25 1:08 PM, Tom Tromey wrote: >>>>>> "Guinevere" == Guinevere Larsen writes: > Guinevere> The convenience function get_frame_pc_if_available would take a pointer > Guinevere> to a variable that should be set if available, and would return a > Guinevere> boolean indicating whether that action was successful or not. > > Thanks. > > Guinevere> - if (!get_frame_pc_if_available (frame, &pc)) > Guinevere> + if (!(pc = get_frame_pc_if_available (frame))) > > This is kind of cheating but in most spots in the patch it is cleaner > than the alternative. So I'm inclined to let it slide. > > Guinevere> annotate_frame_begin (print_level ? frame_relative_level (frame) : 0, > Guinevere> - gdbarch, pc); > Guinevere> + gdbarch, (pc.has_value ()) ? *pc : 0); > > I think this can be written: pc.value_or (0). > Ok with that change. > > Approved-By: Tom Tromey > > Tom > Thanks for the quick review! fixed and pushed! -- Cheers, Guinevere Larsen She/it