From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56408 invoked by alias); 10 Jul 2018 02:05:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 56393 invoked by uid 89); 10 Jul 2018 02:05:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Jul 2018 02:05:31 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 2824F1E08D; Mon, 9 Jul 2018 22:05:30 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1531188330; bh=wYDiZEtBUWBHtosRHMql0qXMmYWx7Q28cVvbZelw9l8=; h=Subject:To:References:From:Date:In-Reply-To:From; b=D07i9NoOdMZ4qDIZ2cW0bXF9ueLjPP+J+trqn082pos9Z/uGVe7gsgf0oXTF8uOfD HOSO4ECZwuJ44wEB3NnKu27twyMQIKygnAhykr/WKmFcHLvg7n2jWqm2z6QIhHzEyK zXnFfag56fNVfpR8ydnU0o3HLXqdgqqTPOmI1uRE= Subject: Re: [RFA 24/42] Move pending_blocks and pending_block_obstack to buildsym_compunit To: Tom Tromey , gdb-patches@sourceware.org References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-25-tom@tromey.com> From: Simon Marchi Message-ID: <8fb1dcaa-41ad-8ade-aab2-f1890fec6865@simark.ca> Date: Tue, 10 Jul 2018 02:05:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180523045851.11660-25-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00239.txt.bz2 On 2018-05-23 12:58 AM, Tom Tromey wrote: > @@ -344,7 +348,6 @@ find_symbol_in_list (struct pending *list, char *name, int length) > > scoped_free_pendings::scoped_free_pendings () > { > - gdb_assert (pending_blocks == nullptr); > } You can remove the constructor (here and in the .h). Otherwise, LGTM. The ownership model of the pending blocks is not very clear to me yet, but I'm sure it will become by the end of the series. Simon