From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id B8q3NfnTp2lRmxMAWB0awg (envelope-from ) for ; Wed, 04 Mar 2026 01:40:57 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=wWcERdAG; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=sgc7ZioU; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=wWcERdAG; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=sgc7ZioU; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C05691E08D; Wed, 04 Mar 2026 01:40:57 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id ECB791E08D for ; Wed, 04 Mar 2026 01:40:55 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 6DFB14BA23C9 for ; Wed, 4 Mar 2026 06:40:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6DFB14BA23C9 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=wWcERdAG; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=sgc7ZioU; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=wWcERdAG; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=sgc7ZioU Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 455D04BA2E0E for ; Wed, 4 Mar 2026 06:40:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 455D04BA2E0E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 455D04BA2E0E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772606420; cv=none; b=fSUk83A6GM/ywU/4EWRmByNG3ha8Cw2U6yyEcDeiuPqwg7RRvBSZG8/DCY1sv8j0EliiESbHHDkR/xLASpafQ/eByAWeIFpWOPZydFXaIOz/yl2FS+wdq+pD+XF+x5//jvqvKjDb9YglWi+03yHfIsNZn9cuUxyzKG3JjGWwsMk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772606420; c=relaxed/simple; bh=XsftakYurAgVEPU0sApYu+2KuLqahBctxxqCTZArVkQ=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=XCL+ldLtnwWn/Pb+vWHN/cnWUAYsgRU7lxBUPUrjDapAyD4pjUgMf5SJthtG4MAWlrxC4218Khp+8+Uo1i6ZQaiRw98mDqqsFTdLNNSo7p1dSAJKY0bA79B3Gdln8n6q6lGikFmnzKW9PkVUFkPhhn9Agud6WwFM7OOulY1H35Y= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 455D04BA2E0E Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1992C3F346; Wed, 4 Mar 2026 06:40:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772606419; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4ZZ2KVDY9lqF5yxCc1WaPU4zfpYvKw6zb4upDfVVl7w=; b=wWcERdAG9tED0ljx2aSU7tEhWx0jMoWIEgO3gMTxB78jYVQfH/6v3f+n4fT4aWZC2T5ss5 lFMrgAJsk+j8e721Utbtq05vX7WY2t2dlRTbx9v5rLoCyOVMPD0jZoBD3U1Z4g3aJBfwez OUBaSL3DzKwfJA/jv9ZUWvQjd4CaZqc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772606419; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4ZZ2KVDY9lqF5yxCc1WaPU4zfpYvKw6zb4upDfVVl7w=; b=sgc7ZioUEPhU2WPjGjLyPaNrSsywT/U7A3BFAHs56em26qPxAHVva4uh9ykgb4E+YiAK4R fUZAlbp/UbXNSMBQ== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772606419; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4ZZ2KVDY9lqF5yxCc1WaPU4zfpYvKw6zb4upDfVVl7w=; b=wWcERdAG9tED0ljx2aSU7tEhWx0jMoWIEgO3gMTxB78jYVQfH/6v3f+n4fT4aWZC2T5ss5 lFMrgAJsk+j8e721Utbtq05vX7WY2t2dlRTbx9v5rLoCyOVMPD0jZoBD3U1Z4g3aJBfwez OUBaSL3DzKwfJA/jv9ZUWvQjd4CaZqc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772606419; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4ZZ2KVDY9lqF5yxCc1WaPU4zfpYvKw6zb4upDfVVl7w=; b=sgc7ZioUEPhU2WPjGjLyPaNrSsywT/U7A3BFAHs56em26qPxAHVva4uh9ykgb4E+YiAK4R fUZAlbp/UbXNSMBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 025B53EA69; Wed, 4 Mar 2026 06:40:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 0LDFOtLTp2mYHAAAD6G6ig (envelope-from ); Wed, 04 Mar 2026 06:40:18 +0000 Message-ID: <8f572769-fb70-4250-8f31-6d0c6c166f92@suse.de> Date: Wed, 4 Mar 2026 07:40:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/testsuite: Skip gdb.base/watchpoint-unaligned.exp on s390x To: Kevin Buettner , gdb-patches@sourceware.org References: <20260303221842.488050-1-kevinb@redhat.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <20260303221842.488050-1-kevinb@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; FROM_HAS_DN(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_TWO(0.00)[2]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MID_RHS_MATCH_FROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:email] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/3/26 11:17 PM, Kevin Buettner wrote: > The watchpoint-unaligned.exp test requires both read and write > hardware watchpoints. s390x only supports write watchpoints, causing > one test failure when the rwatch command fails with "Target does not > support this type of hardware watchpoint." > > Add a require for allow_hw_watchpoint_access_tests to skip this test on > architectures without read watchpoint support. Hi Kevin, thanks for fixing this. LGTM, with one nit. While indeed the comment at the top mentions read watchpoints, the test-case contains some hardcoded downgrading to regular watchpoints for [istarget "s390*-*-*"], and consequently most of the test-case passes on s390x. It's only the last bit (which runs size8twice) that fails, so moving the check here: ... + if {![allow_hw_watchpoint_access_tests]} { + continue + } set cmd "rwatch" ... is a more minimal fix, in the sense that it only skips the failing test. Approved-By: Tom de Vries Thanks, - Tom > --- > gdb/testsuite/gdb.base/watchpoint-unaligned.exp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.base/watchpoint-unaligned.exp b/gdb/testsuite/gdb.base/watchpoint-unaligned.exp > index d3bba6ae010..4b93dbf8234 100644 > --- a/gdb/testsuite/gdb.base/watchpoint-unaligned.exp > +++ b/gdb/testsuite/gdb.base/watchpoint-unaligned.exp > @@ -17,7 +17,7 @@ > > # Test inserting read watchpoints on unaligned addresses. > > -require allow_hw_watchpoint_tests > +require allow_hw_watchpoint_tests allow_hw_watchpoint_access_tests > > standard_testfile > if { [prepare_for_testing ${testfile}.exp ${testfile} ${srcfile}] } {