Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Jim Blandy" <jimb@red-bean.com>
To: "andrzej zaborowski" <balrogg@gmail.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Disallow pseudo-registers in agent expression.
Date: Tue, 05 Feb 2008 15:58:00 -0000	[thread overview]
Message-ID: <8f2776cb0802050758o1d3b80cfw11e88ec413f0c423@mail.gmail.com> (raw)
In-Reply-To: <8f2776cb0802050734x1f79a335kfa3eaa104f25fedc@mail.gmail.com>

I've committed the following, to fix part of this.

gdb/ChangeLog:
2008-02-05  Jim Blandy  <jimb@red-bean.com>

	* ax-gdb.c (gen_expr): Yield ordinary error if asked to trace a
	pseudoregister, not an internal error.
	Reported by: Andrzej Zaborowski

diff -r fb37ff1fb896 -r da7d103c89a5 gdb/ax-gdb.c
--- a/gdb/ax-gdb.c	Tue Feb 05 07:36:35 2008 -0800
+++ b/gdb/ax-gdb.c	Tue Feb 05 07:56:09 2008 -0800
@@ -1607,6 +1607,10 @@ gen_expr (union exp_element **pc, struct
 	if (reg == -1)
 	  internal_error (__FILE__, __LINE__,
 			  _("Register $%s not available"), name);
+	if (reg >= gdbarch_num_regs (current_gdbarch))
+	  error (_("'%s' is a pseudo-register; "
+		   "GDB cannot yet trace pseudoregister contents."),
+		 name);
 	value->kind = axs_lvalue_register;
 	value->u.reg = reg;
 	value->type = register_type (current_gdbarch, reg);


  reply	other threads:[~2008-02-05 15:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-26 19:09 andrzej zaborowski
2008-01-26 19:15 ` andrzej zaborowski
2008-01-27 21:11   ` Jim Blandy
2008-01-29  0:19     ` andrzej zaborowski
2008-01-29  1:49       ` Jim Blandy
2008-02-05 15:34         ` Jim Blandy
2008-02-05 15:58           ` Jim Blandy [this message]
2008-02-05 16:07             ` Jim Blandy
2008-02-05 18:23           ` andrzej zaborowski
2008-02-05 19:16             ` Jim Blandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f2776cb0802050758o1d3b80cfw11e88ec413f0c423@mail.gmail.com \
    --to=jimb@red-bean.com \
    --cc=balrogg@gmail.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox