From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1076 invoked by alias); 22 Jan 2008 23:26:18 -0000 Received: (qmail 1066 invoked by uid 22791); 22 Jan 2008 23:26:17 -0000 X-Spam-Check-By: sourceware.org Received: from py-out-1112.google.com (HELO py-out-1112.google.com) (64.233.166.180) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 22 Jan 2008 23:26:00 +0000 Received: by py-out-1112.google.com with SMTP id v53so3137091pyh.33 for ; Tue, 22 Jan 2008 15:25:58 -0800 (PST) Received: by 10.35.47.10 with SMTP id z10mr10078398pyj.15.1201044358101; Tue, 22 Jan 2008 15:25:58 -0800 (PST) Received: by 10.35.36.15 with HTTP; Tue, 22 Jan 2008 15:25:58 -0800 (PST) Message-ID: <8f2776cb0801221525w1d26661dgf6452f876197a591@mail.gmail.com> Date: Tue, 22 Jan 2008 23:26:00 -0000 From: "Jim Blandy" To: "Pedro Alves" Subject: Re: arm_addr_bits_remove Cc: gdb-patches In-Reply-To: <47965D31.3040602@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <47965D31.3040602@codesourcery.com> X-Google-Sender-Auth: e688ccd263cea7ef X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00534.txt.bz2 I'm not an ARM expert by any means, so I don't object to the patch, but I wonder if allowing arm_pc_is_thumb to return the wrong answer for the first address beyond the end of a function will cause other problems elsewhere. If it is valuable to make arm_pc_is_thumb accurate in this case, when it can't find a minsym at memaddr, and memaddr > 0, would it make sense to look for a minsym at memaddr - 1, and see if MSYMBOL_SIZE (m) != 0 && SYMBOL_VALUE_ADDRESS (m) + MSYMBOL_SIZE (m) == memaddr, and use m if so?