From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13848 invoked by alias); 3 May 2006 23:50:22 -0000 Received: (qmail 13839 invoked by uid 22791); 3 May 2006 23:50:22 -0000 X-Spam-Check-By: sourceware.org Received: from wx-out-0102.google.com (HELO wx-out-0102.google.com) (66.249.82.198) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 03 May 2006 23:50:06 +0000 Received: by wx-out-0102.google.com with SMTP id h30so235469wxd for ; Wed, 03 May 2006 16:50:04 -0700 (PDT) Received: by 10.70.74.3 with SMTP id w3mr59334wxa; Wed, 03 May 2006 16:50:04 -0700 (PDT) Received: by 10.70.129.13 with HTTP; Wed, 3 May 2006 16:50:04 -0700 (PDT) Message-ID: <8f2776cb0605031650o1cf451bex682613fd1434a110@mail.gmail.com> Date: Wed, 03 May 2006 23:50:00 -0000 From: "Jim Blandy" To: "Nick Roberts" Subject: Re: Variable objects: references formatting Cc: "Vladimir Prus" , gdb-patches@sources.redhat.com In-Reply-To: <17497.14121.225320.477428@farnswood.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <17497.14121.225320.477428@farnswood.snap.net.nz> X-Google-Sender-Auth: 52ae50b9ca14b2d7 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00026.txt.bz2 On 5/3/06, Nick Roberts wrote: > There are som many things about this patch that I don't understand: I may have made a mistake in reviewing, but please don't be elliptical: just say what you think is wrong. The patch is against an older version of varobj.c, and does seem to be cut from a larger patch, but it applies, and given the surrounding code in c_value_of_variable, and the behavior of c_val_print, the general sense of the change seems correct. Have you tried creating varobjs for values that are references to structs and displaying them, which I think is the case actually being addressed?