From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23354 invoked by alias); 3 May 2006 18:08:27 -0000 Received: (qmail 23345 invoked by uid 22791); 3 May 2006 18:08:26 -0000 X-Spam-Check-By: sourceware.org Received: from wx-out-0102.google.com (HELO wx-out-0102.google.com) (66.249.82.197) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 03 May 2006 18:08:24 +0000 Received: by wx-out-0102.google.com with SMTP id s8so189458wxc for ; Wed, 03 May 2006 11:08:23 -0700 (PDT) Received: by 10.70.74.6 with SMTP id w6mr2547873wxa; Wed, 03 May 2006 11:08:23 -0700 (PDT) Received: by 10.70.129.13 with HTTP; Wed, 3 May 2006 11:08:22 -0700 (PDT) Message-ID: <8f2776cb0605031108j2371fd7dodcc9f6cecf305c5d@mail.gmail.com> Date: Wed, 03 May 2006 18:08:00 -0000 From: "Jim Blandy" To: "Vladimir Prus" Subject: Re: Variable objects: references formatting Cc: gdb-patches@sources.redhat.com In-Reply-To: <8f2776cb0605031050q6b9f1b2ale98d0734d4dec3f9@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <8f2776cb0605031050q6b9f1b2ale98d0734d4dec3f9@mail.gmail.com> X-Google-Sender-Auth: 54ccffb108b08330 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00020.txt.bz2 On 5/3/06, Jim Blandy wrote: > On 5/3/06, Vladimir Prus wrote: > > At the moment, when using variable objects to display a struct or a cla= ss, > > the result of -data-evaluate-expression is "...". However, when display= ing > > a reference to a class, the result of -data-evaluate-expression is > > {}-enclosed list of members and their values. > > > > This disparity does not seem to be reasonable, the attached patch fixes= it: > > I think you're right, and the patch looks good. I'll apply it. Some further stuff I came across, for future reference: - ChangeLog entries need to have two spaces between the date and the name, and the name and the email address. They need an asterisk before the filename. Check out the other ChangeLog entries for examples. - When declaring a pointer to a type, GNU coding style writes 'type *ptr', not 'type* ptr'. - In GDB, when traversing types, remember to call check_typedef to avoid having your traversal stopped by typedef nodes.