From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-42943-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 28936 invoked by alias); 20 Feb 2006 19:59:48 -0000
Received: (qmail 28911 invoked by uid 22791); 20 Feb 2006 19:59:46 -0000
X-Spam-Check-By: sourceware.org
Received: from xproxy.gmail.com (HELO xproxy.gmail.com) (66.249.82.196)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 20 Feb 2006 19:59:44 +0000
Received: by xproxy.gmail.com with SMTP id s17so723224wxc         for <gdb-patches@sourceware.org>; Mon, 20 Feb 2006 11:59:43 -0800 (PST)
Received: by 10.70.96.11 with SMTP id t11mr4164423wxb;         Mon, 20 Feb 2006 11:59:42 -0800 (PST)
Received: by 10.70.125.17 with HTTP; Mon, 20 Feb 2006 11:59:42 -0800 (PST)
Message-ID: <8f2776cb0602201159r70222f70r538b97cdeb973e79@mail.gmail.com>
Date: Mon, 20 Feb 2006 20:03:00 -0000
From: "Jim Blandy" <jimb@red-bean.com>
To: "Andrew STUBBS" <andrew.stubbs@st.com>, "Jim Blandy" <jimb@red-bean.com>,  	"GDB Patches" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Allow spaces in filenames to load command
In-Reply-To: <20060220170702.GH16058@nevyn.them.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <43949300.1040203@st.com> 	 <8f2776cb0512051250u2a6083dbma95e6b352410dea8@mail.gmail.com> 	 <43956C93.5070709@st.com> 	 <8f2776cb0512061504la4a7a5brada0edaeb051f0e4@mail.gmail.com> 	 <8f2776cb0512061912o2d37bef9y7404a51858bfd6cf@mail.gmail.com> 	 <43971EC3.3060405@st.com> <43972145.6020903@st.com> 	 <20060220170702.GH16058@nevyn.them.org>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2006-02/txt/msg00381.txt.bz2

On 2/20/06, Daniel Jacobowitz <drow@false.org> wrote:
> On Wed, Dec 07, 2005 at 05:52:05PM +0000, Andrew STUBBS wrote:
> > 2005-12-07  Andrew Stubbs  <andrew.stubbs@st.com>
> >
> >       * symfile.c (generic_load): Use buildargv() and tilde_expand()
> >       to parse file names with quoting, spaces and tildes properly.
> >       (load_command): Quote all special characters before calling
> >       target_load() such that buildargv() doesn't break file names.
> >       (_initialize_symfile): Mention the load offset in the help for
> >       the load command.
> >       * remote-sim.c: Include readline.h.
> >       (gdbsim_load): Use buildargv and tilde_expand() to parse file
> >       names with quoting, spaces and tildes properly.
> >       * target.h (target_load): Comment the parameters better.
> >       * Makefile.in (remote_sim.o): Add readline.h dependency.
>
> This all looks plausible to me.  Jim, do you want to take a look at
> this, since you were previously?

Yes --- this look good.

Ideally, the code added to load_command to do the quoting should be in
libiberty/argv.c.  But this patch is fine as is.