Re: RFA: Support Windows extended error numbers in safe_strerror

Daniel Jacobowitz
2006-02-05T02:01:23Z

On Sat, Feb 04, 2006 at 07:27:10PM -0500, Christopher Faylor wrote:
> On Sat, Feb 04, 2006 at 12:03:38PM +0200, Eli Zaretskii wrote:
> >Then perhaps we should create a new -nat.c file, say mingw-nat.c, and
> >maintain it separately. (For that matter, I'd really love to see
> >win32-nat.c be renamed to cygwin-nat.c, since that's what it really is
> >going to be.) If neither Daniel nor Mark M. can afford becoming
> >responsible maintainers for such a new native file, I volunteer to do
> >my best to do that.
> >
> >Would you agree to such a solution?
>
> That is *exactly* what I expected to come out of this discussion. And,
> I suspect that it won't just be win32-nat.c which will have to be changed.
> There will be a header file or two, and probably some configuration magic.
>
> And, really, it is a bad design decision to have two different files
> using the same debugging mechanism. If this was to be done right then
> win32-nat.c should somehow be factored out further so that the common
> bits can be shared. Cygwin and MinGW are alike enough that they should
> share code.
>
> However, that is, again, not something that I have any interest in doing.
> This is a personal preference and I'm afraid that it is very unlikely that
> anyone is going to convince me otherwise.

Wouldn't dream of trying.

I think that mingw32 hosting support and mingw32 native support can be
treated separately; do you disagree? I'm not actually interested in
adding the latter, not at the moment anyway, and neither are you; if
someone becomes interested, we can hold them to an appropriately high
standard of separation from Cygwin support.

My only interest is in cross debuggers (mostly ARM and PPC at the
moment) hosted on MinGW32. So you've already seen most of what I
expect to do. I'll plan to rename ser-windows.c to something less
ambiguous; and since there was a clear reaction that the call to
FormatMessage doesn't belong in utils.c, I'm going to put that in a new
file too (I am considering "mingw32-hdep.c"). We can include that
in Windows support, or separate the two, whichever you'd prefer.

In case it isn't clear, one of my foremost goals here is to prevent
maintenance burden: on the one hand, for my employer, and on the other
hand, for the GDB community. Both hands are important to me, but
it's not easy to balance them.

--
Daniel Jacobowitz
CodeSourcery