From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24178 invoked by alias); 18 Jan 2006 01:15:31 -0000 Received: (qmail 24170 invoked by uid 22791); 18 Jan 2006 01:15:31 -0000 X-Spam-Check-By: sourceware.org Received: from zproxy.gmail.com (HELO zproxy.gmail.com) (64.233.162.207) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 18 Jan 2006 01:15:26 +0000 Received: by zproxy.gmail.com with SMTP id m22so1487746nzf for ; Tue, 17 Jan 2006 17:15:24 -0800 (PST) Received: by 10.36.22.15 with SMTP id 15mr6427324nzv; Tue, 17 Jan 2006 17:15:24 -0800 (PST) Received: by 10.37.2.42 with HTTP; Tue, 17 Jan 2006 17:15:24 -0800 (PST) Message-ID: <8f2776cb0601171715h4afaf38cm6e25b1983e73b1a9@mail.gmail.com> Date: Wed, 18 Jan 2006 01:15:00 -0000 From: Jim Blandy To: gdb-patches@sourceware.org Subject: Re: [ob] More warnings; Call for assistance In-Reply-To: <20060117151730.GA2420@nevyn.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <20060117151730.GA2420@nevyn.them.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00234.txt.bz2 On 1/17/06, Daniel Jacobowitz wrote: > LA_PRINT_STRING takes a const gdb_byte * argument for the string. But th= is > is a NUL-terminated string in the debugger's memory; I think stepping back > to char * is the best fix here. That's the expprint.c warnings. I wrote that up, but then I didn't like it. The use of 'char *' should be reserved for host-format character strings, but it looks to me like LA_PRINT_STRING expects a string in the target format. (Not that the interface documentation offers much help here.) Look at the way c_printstr unpacks the string character by character using extract_unsigned_integer. Look at the way LA_EMIT_CHAR is responsible for calling target_char_to_host. If folks agree, then I'll make the comments in language.h clearer, and try to finish off this change.