Re: [PATCH] Add support for Analog Devices Blackfin processor (part 1/6: gdb)

Jim Blandy
2006-01-04T05:28:35Z

Why do you need the changes to configure.host, and the bfin.mh file?
You can't run GDB itself on the blackfin processor, can you? It
doesn't have an MMU, and I've never heard of GDB running on uClinux.

In bfin_linux_pc_in_sigtramp, you should pass in the frame and use
safe_frame_unwind_memory instead of deprecated_read_memory_nobpt. It
looks to me like you always have a frame handy --- is that right?

+ frame_unwind_register (next_frame, BFIN_SP_REGNUM, buf);
+ sp = extract_unsigned_integer (buf, 4);

Is it possible to simply use frame_unwind_register_unsigned in places like this?

Am I reading bfin_frame_prev_register correctly when I conclude that
the only saved registers it can find are the PC and the FP? How are
the test suite results?

+#include "bfd-in2.h"
+

Why is this needed? Shouldn't the #include "bfd.h" in defs.h be sufficient?

Other than that, it looks nice.