Re: [PATCH] Add support for Analog Devices Blackfin processor (part 1/6: gdb)

Jim Blandy
2006-01-09T05:35:53Z

On 1/8/06, Jie Zhang <jzhang918@gmail.com> wrote:
> Again here is a new patch with source code clean up as you pointed out.

Thanks. It looks good.

There is something that I noticed before but forgot to ask about (sorry):

+/* The list of available "set bfin ..." and "show bfin ..." commands. */
+
+static struct cmd_list_element *setbfincmdlist = NULL;
+static struct cmd_list_element *showbfincmdlist = NULL;
+

These seem to be unused. If there is missing code to be added, then
that needs to be posted for review. But if they can simply be
deleted, I think the GDB port is okay to commit as soon as the
paperwork is ready (I'm just waiting for the Analog Devices assignment
for GDB to appear in copyright.list, along with the ones for GCC,
libstdc++, and binutils).